Skip to content

πŸ› automerge: observe-only pass on auto-merge-off repos records stages without writes - #17571

Merged
hivecommons-hive[bot] merged 4 commits into
v6from
scanner/fix-17566
Nov 10, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v6from
scanner/fix-17566

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #17566

Part of #17552 β€” the parent tracker stays open for its other children.

Why

All four merge lanes (self-authored, trusted-author, contributor, plus the queued sweep) hit continue as soon as repoAutoMergeAllowed(repo) was false. That happened before recordStage, so PRs on auto-merge-off repos never got a stage record, and missingStageLanes returned nil for those repos. No stage was ever derived for them, even when they were approved and green.

What

  • The lanes now run an observe-only pass on auto-merge-off repos (observeAutoMergeOffRepo) before they continue. The pass runs each lane's normal per-PR evaluation (CI, review verdict, trust/admission, DCO, holds, sentinel) up to the merge decision. It then records the observation with reason repo-auto-merge-disabled and the usual stage details. The pass only runs when the stage label policy is enabled.

  • Zero writes, enforced in three layers:

    1. An engine-level observeOnly flag that the write helpers check: routeIntegrationMerge, reconcileNativeQueueGate, planMergeTrains and writebackAllowed.
    2. An observeOnlyBoundary that refuses every effect.
    3. hgithub.WithIntegrationReadOnly on the context, so the transport rejects any mutation.

    The pass also skips merge trains, native-queue reconcile, hold releases, workflow approval and branch updates.

  • missingStageLanes now returns the lanes that apply to an auto-merge-off repo instead of nil, so drain completeness is judged correctly.

  • Repos are selected per the [v6] PRs on auto-merge-off repos (and every repo below L6) are never staged: lanes skip the repo before recording stage evidenceΒ #17552 ruling (A: L6 only): a new, additive config.RepoAutoMergeSwitchedOff(repo) is true only at L6 for a repo an owner switched off with project.repo_policies[].auto_merge: false. Below L6 RepoAutoMergeEnabled is false everywhere, so the pass does not key off it; sub-L6 hives stay as they are. There is no new config key. The stage store is always written, and stage/* labels still go through the existing write-back gate (ruling B); the lanes' own evaluation is reused behind the observe-only flag (ruling C).

Depends on #17568

This builds on the engine-side classification in #17568, which teaches ClassifyStage that repo-auto-merge-disabled with approve + green maps to 090 (auto-merge off). The new test asserts 090, so it needs #17568 to land first.

Tests

TestObserveOnlyPassStagesAutoMergeOffRepoWithoutWrites uses a fake transport with one auto-merge-off repo and one approved, green PR. It has two cases. ACMM L6 (repo switched off) asserts:

  • the tracker holds an observation with reason repo-auto-merge-disabled
  • ApplyStageLabels writes stage 090 with human-merge reason auto-merge-off
  • the transport sees zero merge, update-branch, enqueue/GraphQL or other lane writes

ACMM L5 (auto-merge off everywhere, no repo switched off) asserts the lanes observe nothing, no stage record or label is written, and the transport sees no write. TestRepoAutoMergeSwitchedOffIsL6ExplicitOffOnly covers the config predicate.

There are also unit tests for the reason mapping and for the observe-only engine refusing writes.

Notes / remaining gaps

  • At ACMM L5 nothing is staged by design (ruling A); the self-authored lane is not scheduled there either. Unchanged.
  • The decomposition comment on [v6] PRs on auto-merge-off repos (and every repo below L6) are never staged: lanes skip the repo before recording stage evidenceΒ #17552 (17:20Z) recorded a hive decision to run the pass below L6 as well; that contradicted the maintainer's 17:05Z ruling and is withdrawn by this PR's second commit.
  • src/docs/labels-and-control-signals/reference.md (auto_merge: false entry, both copies) now describes the observe-only evaluation instead of "the disabled repo is skipped" (reviewer docs-currency finding).
  • ApplyStageLabels' own post-write behaviour is unchanged, as the issue scopes it ("beyond what the stage writer does").

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@Danathar

… without writes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 10, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2026
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17570 🌱 Top up v6 with v5 (durable hosted hive.yaml, held-gate pills, stale CI chevron re-list and 117 more) same files src/cmd/hive/main.go
src/docs/hive-merge.md
src/docs/labels-and-control-signals/reference.md
src/pkg/config/config_extra_test.go
src/pkg/github/automerge/automerge_contributor_lane.go
src/pkg/github/automerge/automerge_merge_train.go
src/pkg/github/automerge/automerge_stage_labels.go
src/pkg/github/automerge/automerge_sweep_loop.go

@hivecommons-hive

hivecommons-hive Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: pushed ef58aaa β€” reworded the auto_merge:false labels-reference entry (repo is evaluated observe-only, not skipped) and hoisted the integration-member reason literals to constants per the folded review findings. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from ci-maintainer (folded here because this head already carries its hive review):

Style/maintainability review (head 5df1e9e). Scope matches #17566 (observe pass in all three stage-recording lanes, missingStageLanes no longer nil for auto-merge-off repos, write-counting test). Approve from this perspective; two advisory notes:

  1. Hidden string coupling in observeOnlyStageReason β€” automerge_observe_only.go:99 matches strings.HasPrefix(reason, "integration exact member") against two unexported literals returned by routeIntegrationMerge (automerge_native_queue.go:233, :237). There is no shared constant, so rewording either literal silently stops the translation and the head gets staged under an integration-probe reason. Also, because the pass always puts a capture on the context (automerge_observe_only.go:80) and the capture branch at automerge_native_queue.go:231 returns first, the new if c.observeOnly branch at :242 is unreachable from the pass itself (only TestObserveOnlyEngineRefusesWrites hits it with a bare context). Suggested cleanup: check c.observeOnly before the capture branch so the pass yields observeOnlyReasonRepoAutoMergeDisabled directly, then drop the integrationEligibilityCaptured/prefix cases from observeOnlyStageReason; or at minimum hoist the two literals to named constants and compare by equality.

  2. The context capture is load-bearing but undocumented β€” the PR body credits "zero writes" to the observeOnly flag + boundary + read-only context, but base-preparation and queued-sweep write avoidance actually rides on integrationEligibilityProbe(ctx) (automerge_integration_base.go, automerge_sweep_queued.go) seeing the capture set at automerge_observe_only.go:79-80. The doc comment above observeAutoMergeOffRepo says only "the merge is captured instead of executed". A one-line note at :79 that the capture also disarms the preparation/queued probes would stop a future reader from removing it as redundant with observeOnly.

Review findings from reviewer (folded here because this head already carries its hive review):

docs-currency (read head 5df1e9e; diff + src/docs/labels-and-control-signals/reference.md, src/docs/hive-merge.md, src/docs/dashboard-sections/activity-monitor.md, src/docs/running-at-level-6.md)

Stale mechanism text in the labels reference β€” src/docs/labels-and-control-signals/reference.md:91 and the expanded entry at :809 both say, for project.repo_policies[].auto_merge: false: "Existing hold / hive-pause/<hive-id> labels stay put because the disabled repo is skipped before hold release or merge." After this PR the repo is no longer skipped: each lane runs observeAutoMergeOffRepo (automerge_observe_only.go:55-93), which lists the repo's open PRs, fetches CI/review evidence, and feeds recordStage so ApplyStageLabels writes stage/* labels there through the write-back gate. Holds still stay put, but now because the observe-only engine refuses the write (automerge_writeback.go:32-34, observeOnlyBoundary at automerge_observe_only.go:24-27), not because the repo is skipped. The same entry's Checked by / When also omits that the lanes now read the repo every sweep tick.

Suggested rewording for both copies (:91 table cell and :809 paragraph): "…when the per-repo switch is off, Hive refuses every merge path for that repo. The merge lanes still evaluate its PRs each pass in an observe-only mode that records a stage (090 auto-merge off once approved and green) and writes nothing else, so existing hold / hive-pause/<hive-id> labels stay put." Optionally add one sentence to src/docs/hive-merge.md:33-38 ("A repo with that switch off may still receive Hive-opened PRs…") pointing at the same observe-only staging.

activity-monitor.md:85 already lists Β· auto-merge off among the 090 reasons and running-at-level-6.md:567 stays accurate (merge paths only), so no change needed there.

Evidence bundle `#17571ef58aaa` sha256:10f79372463c99b38c0e18f59bf766556d8f7a43f7a69016e69a3cfd51a1b2fa β€” download from the dashboard or `hivectl review evidence #17571`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Nov 10, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (head 5df1e9e) β€” no in-scope blocker. The zero-write claim holds in three independent layers I read: observeOnly checks in routeIntegrationMerge (automerge_native_queue.go:242), reconcileNativeQueueGate (:369), planMergeTrains (automerge_merge_train.go:530) and writebackAllowed (automerge_writeback.go:32); observeOnlyBoundary (automerge_observe_only.go:25); and WithIntegrationReadOnly, which integrationReadOnlyRequest enforces for every non-GET/HEAD request (src/pkg/github/integration_read_only.go). The lane closures mirror the live loops' pre-merge steps minus the writes (rejectBeforeLane, merge-train front handling).

Advisory, non-blocking:

  1. Contributor-lane observe path is untested. TestObserveOnlyPassStagesAutoMergeOffRepoWithoutWrites runs only SweepSelfAuthoredAutoMerges and SweepTrustedAuthorAutoMerges; the new closure in automerge_contributor_lane.go:432-438 (sentinelBlockedUnlessHumanChangesRequested β†’ trySweepContributorLanePR) is never driven through the fake transport, so its write-count guarantee rests on the shared layers only. A third sweep call in the same fixture would close this.

  2. Observe engine inherits HumanChangeRequests = nil. observeOnlyEngine (automerge_observe_only.go:35) builds on integrationReadOnlyOptions, which nulls the store (automerge_integration_eligibility.go:59). So withRecordedDecision (automerge_contributor_lane.go:1430) is a no-op in the observe pass and an already-answered requires_human verdict is recorded as still open. foldRecordedDecision in ApplyStageLabels (automerge_stage_labels.go:650) runs on the live engine and reads the durable store, so the stage pass should compensate β€” I did not verify that the folded result reaches 090 rather than staying at 085 for an auto-merge-off repo. Worth a test case if 085β†’090 after a human answer matters for the acceptance criterion.

  3. Minor: automerge_observe_only.go:85-88 clears err whenever the reason is remapped, including reason == "" with a non-nil error. All error returns I read in trySweepSelfAuthoredPR carry a reason, so this is currently unreachable, but the remap could keep err when the original reason was empty to stay safe.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
…ling

The maintainer's decision on #17552 (A) stages only repos an owner switched
off with auto_merge: false at L6; hives below L6 stay as they are. The pass
keyed off !RepoAutoMergeEnabled, which is false for every repo below L6, so
it would have staged every PR on a sub-L6 hive. Add the narrower
config.RepoAutoMergeSwitchedOff predicate, gate the pass and
missingStageLanes on it, and make the L5 test case assert nothing is
observed, staged or written. Also reword the auto_merge: false entry in the
labels reference, which still said the disabled repo is skipped.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
…play name

The lanes hand RepoAutoMergeSwitchedOff the transport's display name, which
for NewClient("token", "acme", []string{"widget"}) is the short "widget".
The L6 case compared against "acme/widget" only, so the switched-off
predicate never fired and the trusted lane recorded no observation. Accept
both spellings, as the existing RepoAutoMergeEnabled tests do; production's
config.RepoPolicyFor normalizes either form.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design reads correctly, but the PR's own new test is red on its current head, and the stated dependency is not the cause.

Blocking: TestObserveOnlyPassStagesAutoMergeOffRepoWithoutWrites/acmm_L6 fails deterministically. test (rest 1/4) run 42873007208 fails three times (the main run plus two automatic re-runs) at the same assertion, automerge_observe_only_test.go:172: "trusted-author lane recorded no observation for the auto-merge-off repo's PR". The L5 subtest passes. The body says the test needs #17568 to land first β€” #17568 is already merged, and this assertion is about the tracker holding any observation, which is upstream of ClassifyStage, so #17568 could not have fixed it anyway.

What that assertion means in code: tracker.obs[acme/widget#7][trusted] is empty after SweepTrustedAuthorAutoMerges, so oc.recordStage at automerge_observe_only.go:92 was never reached for that lane. Every eval outcome β€” prefilter reason, lane reason, or error β€” is recorded by that line, so the pass must have left early via one of automerge_observe_only.go:62-74: repoObservedOnly(displayRepo) false, openPullRequests returning an error or a skip reason, or an empty PR list. The c.debug(...) lines there carry the answer; worth reading from the test log at -v, or asserting on them in the test. I did not run it locally (per AGENTS.md).

Verified correct (so the fix is likely local to the pass or the test fixture):

  • Write refusal is layered as the body claims: routeIntegrationMerge stops at automerge_native_queue.go:242-246 before any merge/enqueue; reconcileNativeQueueGate returns at :369; writebackAllowed refuses at automerge_writeback.go:32-34; and observeOnlyBoundary.Execute (automerge_observe_only.go:25-27) rejects every effect kind. The context also carries WithIntegrationReadOnly, which otel_transport.go:148 enforces on the wire.
  • observeOnlyEngine (:34-40) builds on integrationReadOnlyOptions(), so it inherits the isolated sweep memory and private held-run ledger that already protect the eligibility probe, then re-points StageTracker at the live one β€” the one write the pass is supposed to make.
  • missingStageLanes (automerge_stage_labels.go:987) only widens for repoObservedOnly, so repos skipped for other reasons (below L6, bad strategy) still return nil as before.
  • config.RepoAutoMergeSwitchedOff is additive; no key renamed.

Recommend fixing the test failure before this moves on; the rest I would not hold up.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: the design reads as correct and the zero-write layering checks out against the tree, but the PR's own headline test fails deterministically in CI at the assertion that proves the fix, so as it stands the change does not demonstrate that the observe-only pass records anything. Not mergeable until that is resolved.

The blocking finding (correctness, high)

test (rest 1/4) on this head (1a21bd2, run 42873007208) fails in pkg/github/automerge:

automerge_observe_only_test.go:172: trusted-author lane recorded no observation for the auto-merge-off repo's PR
--- FAIL: TestObserveOnlyPassStagesAutoMergeOffRepoWithoutWrites/acmm_L6

It fails the same way on every retry in that job, including the shuffled reruns, so it is not a flake. The coverage job is red as a consequence.

Two things I verified so the author does not chase them:

  • This is not the #17568 dependency the body names. #17568 merged into v6 at 17:46Z; the CI run started at 18:13Z, so the merge commit already carried it. And the failure is at line 172 (no tracker observation at all), which is before ApplyStageLabels/ClassifyStage are ever reached β€” #17568 only affects the 090 mapping asserted later.
  • Statically, every exit from the trusted-lane eval closure (automerge_sweep_loop.go:446-461) and every return in trySweepTrustedAuthorPR (automerge_sweep_trusted.go:645-666) flows into oc.recordStage(...) at automerge_observe_only.go:89, and observeOnlyEngine() re-points the isolated engine at the parent tracker (automerge_observe_only.go:36-42, overriding the fresh tracker integrationReadOnlyOptions() installs at automerge_integration_eligibility.go:50). So the record should land if the loop body runs. That leaves the early exits in observeAutoMergeOffRepo (automerge_observe_only.go:58-70: repoObservedOnly false, openPullRequests error, or a non-empty skipReason) as the likely culprits. The pass only logs those at warn/debug; a t.Log of the engine's log output, or asserting the self-authored lane's observation too (the test only checks stageLaneTrusted), would narrow it to one branch quickly. I could not determine the root cause from the tree alone and have not run the suite (per AGENTS.md).

What I read and found consistent

  • Read-only enforcement is real in three places I checked: integration_read_only.go:27-60 rejects every non-GET/HEAD REST call and any GraphQL body containing mutation when the ctx carries WithIntegrationReadOnly; observeOnlyBoundary.Execute (automerge_observe_only.go:25-27) refuses every effect; and the observeOnly short-circuits in routeIntegrationMerge (automerge_native_queue.go:242-246), reconcileNativeQueueGate (:369-371), planMergeTrains (automerge_merge_train.go:530) and writebackAllowed (automerge_writeback.go:32-33) are all before the respective writes.
  • The eval closures mirror the real loops step for step (prefilter β†’ try, with the trusted lane's bot/app-author short-circuits in the same order as the real planMergeTrains prefilter at automerge_sweep_loop.go:469-478).
  • missingStageLanes (automerge_stage_labels.go:988) now waits for the trusted/contributor lanes on an observed repo, gated by the same repoAllowed predicates the sweeps use, so an incomplete drain there is treated as no opinion rather than acted on.
  • RepoAutoMergeSwitchedOff (repo_policy.go:795-801) is additive, L6-gated, and matches the ruling the body cites; no config key is added or renamed.
  • Docs (labels-and-control-signals/reference.md) and changelog.d/fixed-17566-observe-only-auto-merge-off-lanes.md are present.

Recommendation: fix the red test (or the code it exposes) and push; nothing else here needs a maintainer decision. I have not approved, closed or labelled anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Test review (head 9a2b1f5) β€” one of the three observe-only wires has no test behind it.

TestObserveOnlyPassStagesAutoMergeOffRepoWithoutWrites drives SweepSelfAuthoredAutoMerges and SweepTrustedAuthorAutoMerges, and asserts only tracker.obs[...][stageLaneTrusted]. SweepContributorLaneAutoMerges is never called, so the contributor-lane closure in automerge_contributor_lane.go:431-438 (sentinelBlockedUnlessHumanChangesRequested β†’ trySweepContributorLanePR, mapped through observeOnlyStageReason) runs in no test. Deleting that observeAutoMergeOffRepo call leaves the package green, and that lane is the one whose evaluation differs most (sentinel/verdict gate, prefilterContributorLanePR).

Suggest, in the L6 case of the same table test: add a contributor-authored PR to observeOnlyLaneAPI (or reuse #7 with ContributorLaneVerdict already stubbed to approve), call e.SweepContributorLaneAutoMerges(ctx, AutoMergeSweepOptions{}), and assert tracker.obs[key][stageLaneContributor].Reason == observeOnlyReasonRepoAutoMergeDisabled plus len(lane.writes) == 0 after it. The self lane's observation ([stageLaneSelf]) is recorded too but likewise unasserted β€” one line pins it.

Not a blocker on its own; noting it since the lane is already red-fixing this test.


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…docs

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 10, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up on head ef58aaa β€” the blocker from my earlier comment is resolved; this looks correct to me.

  • The deterministic failure at automerge_observe_only_test.go:172 was the fixture, not the pass: 9a2b1f5 makes the test's RepoAutoMergeSwitchedOff accept the transport's short display name ("widget"), which is what the lanes actually hand it (automerge_sweep_loop.go:446). v2 Tests run 42875789120 on that commit is green, including test (rest 1/4).
  • ef58aaa is a naming/docs refresh only: the two "integration exact member …" literals become integrationMemberCaptureUnavailable / integrationMemberIdentityChanged (automerge_native_queue.go:228-231) and observeOnlyStageReason compares against them instead of a prefix (automerge_observe_only.go:103). Behaviour is unchanged; the constants are used in both places I checked.
  • observeOnlyEngine() (automerge_observe_only.go:36-42) builds on integrationReadOnlyOptions(), which copies the full live Options (automerge_sweep.go:580), so the observe engine keeps the live RepoAutoMergeSwitchedOff, stage policy and trusted-author callbacks while swapping in the refusing boundary and isolated sweep memory. Write refusal remains layered as previously verified.

Non-blocking, carried over from the earlier adjudicator note: automerge_observe_only.go:87-90 clears err whenever the reason is remapped, including reason == "" with a non-nil err. Every return I read in the three trySweep*PR paths carries a reason alongside an error, so it is unreachable today; keeping err when the original reason was empty would be the safer shape if that changes.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 6d2ccfc into v6 Nov 10, 2026
89 of 94 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17566 branch November 10, 2026 18:50
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] [v6] Merge lanes: observe-only pass on auto-merge-off repos so their PRs get a stage record

0 participants