Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/added-knowledge-advisor-llm-rank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **knowledge advisor:** with `knowledge.advisor_llm` set, a small model now ranks the mid-task advisor's candidates and picks one stored entry or nothing; it never writes advice. `shadow` delivers the matcher's top entry and logs the model's pick, `rank` delivers the pick with an optional `holdout_percent` control arm, budgets (6 calls per agent-hour, 300 per UTC day) and timeouts fail closed or to the matcher per `on_error`, and every decision writes one `knowledge advisor: decision` log line (#17155).
9 changes: 8 additions & 1 deletion src/cmd/hive/knowledge_adviser.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ func (a *knowledgeAdviser) Policy(agent string) crux.KnowledgeAdvisorPolicy {
// Primer has no kick context for paths, so the observed file goes in as the
// primer's file path and the scope's segments as keywords.
func (a *knowledgeAdviser) Advise(agent string, scope crux.KnowledgeScope) []crux.KnowledgeAdvice {
return a.adviseUpTo(agent, scope, knowledgeAdviseMaxPerScope)
}

// adviseUpTo is Advise with the per-scope cap as a parameter, so the ranking
// pass (#17155) can ask for its larger candidate set without changing what
// phase 1 hands the runtime.
func (a *knowledgeAdviser) adviseUpTo(agent string, scope crux.KnowledgeScope, limit int) []crux.KnowledgeAdvice {
primer := a.primer()
cfg := a.cfg()
if primer == nil || cfg == nil {
Expand All @@ -87,7 +94,7 @@ func (a *knowledgeAdviser) Advise(agent string, scope crux.KnowledgeScope) []cru
ctx, cancel := context.WithTimeout(context.Background(), knowledgeAdviseTimeout)
defer cancel()
primed := primer.PrimeScoped(ctx, agentScope, paths, scope.Keywords)
advice := selectKnowledgeAdvice(primed.Facts, a.primed(agent), knowledgeAdviseMaxPerScope)
advice := selectKnowledgeAdvice(primed.Facts, a.primed(agent), limit)
a.logger.Debug("knowledge advisor: scope entered",
"agent", agent, "scope", scope.Key, "candidates", len(primed.Facts), "advice", len(advice))
return advice
Expand Down
Loading
Loading