Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/pkg/dashboard/webstatic/testdata/tracker-phone-ergonomics.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,19 @@
const stripCell = el => el.matches('.ham-chevron-info, .ham-chevron-decision, .ham-chevron-copy .ham-decision-trigger');
const controls = [...section.querySelectorAll('button, a[href], input, select, summary, [role="button"], [role="menuitem"], [tabindex]:not([tabindex="-1"]):not(.ham-row):not(.ham-sub)')]
.filter(el => visible(el) && !inlineText(el) && !stripCell(el));
// A compact control may extend its hit area with an absolutely positioned
// empty ::before (the progress pill, #17183): its tap target is the pseudo
// box, not the painted box. Negative insets grow the rect.
const hitRect = el => {
const r = el.getBoundingClientRect();
const b = getComputedStyle(el, '::before');
if (b.position !== 'absolute' || b.content !== '""' || getComputedStyle(el).position === 'static') return r;
const px = v => parseFloat(v) || 0;
return { width: r.width - px(b.left) - px(b.right), height: r.height - px(b.top) - px(b.bottom) };
};
const small = [];
for (const el of controls) {
const r = el.getBoundingClientRect();
const r = hitRect(el);
if (r.width + tolerance < 44 || r.height + tolerance < 44) small.push(`${el.tagName.toLowerCase()}.${[...el.classList].join('.')} ${Math.round(r.width)}×${Math.round(r.height)}`);
}
assert(small.length === 0, `${small.length} control(s) under 44×44 at 390×844: ${[...new Set(small)].slice(0, 12).join(', ')}`);
Expand Down
Loading