Skip to content

🌱 ci: re-pin crux file-size ratchet to current crux main - #17152

Closed
Karibhou wants to merge 4 commits into
hivecommons:v5from
Karibhou:ci/repin-crux-ratchet
Closed

Karibhou wants to merge 4 commits into
hivecommons:v5from
Karibhou:ci/repin-crux-ratchet

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Re-pins crux-file-size-ratchet.yml from crux 13372ca (baseline 1658/1389) to crux main fefb7a3 (1657/1348, green ratchet run). Current src/crux sizes: manager.go 1598, manager_kick.go 1208 — pass.

Fixes #17149

— hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: f2b6009f7

Picks up crux's tightened baseline (manager.go 1657, manager_kick.go 1348).

Hive-Run: hivecommons#17149
Hive-Plan: issue-17149
Hive-Spec: crux-file-size-ratchet#pin
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The only red required check is PR Type: the verifier reads the first character of the title and accepts only the emoji set (⚠ ✨ 🐛 📖 🚀 🌱). Suggested fix — retitle to:

🌱 ci: re-pin crux file-size ratchet to current crux main

No code change needed; this is a fork branch so I am not pushing to it. (Note: crux#125 merged just now, lowering the crux-side baseline to 907 — worth confirming the pinned SHA still matches crux main before retitling.)


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task; your current task is parked (claim kept alive) until this PR is green.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin itself checks out; the only thing blocking this is the title.

  • PR Type check is red because the title ci: re-pin crux file-size ratchet to current crux main has no leading emoji. Per this repo's convention this is a chore — 🌱 ci: re-pin crux file-size ratchet to current crux main — and the check reads the first character. Nothing else in the rollup is failing.

Verified in the trees:

  • fefb7a3251093348a87a16cef19de269204ee4be is on hivecommons/crux main (ancestor of current head 7f93191), commit 🌱 sync: hive@19e7a6815bc9.
  • .github/go-file-size-ratchet.txt moves from 1658 agent/manager.go / 1389 agent/manager_kick.go at 13372ca to 1657 / 1348 at fefb7a3 (crux#118), as the body states. src/crux/agent/manager.go is 1598 lines and manager_kick.go 1208 at this PR's head, so both pass with headroom, and the crux-file-size-ratchet job is green.
  • The workflow change is only the ref: of the sparse checkout (.github/workflows/crux-file-size-ratchet.yml:37); permissions: contents: read and the script path are unchanged.

Once the title carries the 🌱 prefix this looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor
f2b6009

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @Karibhou, head f2b6009f7d77) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/crux-file-size-ratchet.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@Karibhou Karibhou changed the title ci: re-pin crux file-size ratchet to current crux main 🌱 ci: re-pin crux file-size ratchet to current crux main Nov 8, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Reviewed head f2b6009 (.github/workflows/crux-file-size-ratchet.yml, one-line pin bump). Note: the GitHub API cap was reached during this review, so I read the PR via git fetch pull/17152/head and could not open #17149; judged against the PR title/commit message.

Pin is already behind crux main, and the gap is in the ratchet baseline itself (.github/workflows/crux-file-size-ratchet.yml:37)

The title says "re-pin to current crux main", but fefb7a3 is a sync: commit two behind refs/heads/main (7f93191, 2026-11-08T01:50Z). The only difference between them on the pinned paths is 7f93191 "lower proxy/rules.go file-size ratchet baseline to 907 (#125)" — i.e. the very file this workflow checks out. Hive's src/crux/proxy/rules.go is exactly 907 lines at merge-base, so taking 7f93191 is safe, and pinning fefb7a3 just guarantees another re-pin PR for the same reason as this one. The manager baselines the commit message cites (1657/1348) are identical at both commits.

          ref: 7f9319143fc22cd4d4b6b72f64f1aceaf67453dd # crux main, 2026-11-08

stage 095-pre-merge-soak → 072-returned-to-contributor: conflicting

…907, crux#125)

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@Karibhou

Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Addressed:

  • PR Type: retitled with the 🌱 prefix.
  • Pin behind crux main: bumped to 7f9319143fc22cd4d4b6b72f64f1aceaf67453dd (current refs/heads/main, includes crux#125's proxy/rules.go baseline 907) in 16cc7585f. Checked every entry of that baseline against src/crux at v5 @ 27e49a5bb: none over (proxy/rules.go 907/907, agent/manager.go 1598/1657, agent/manager_kick.go 1208/1348).
  • The sentinel-alert label (workflow path) is for a maintainer to clear; the change is still only the ref: line.

🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm the crux ratchet re-pin to 7f93191 (crux main HEAD, 2026-11-08) is intended and clear the sentinel-alert; the only diff is the ref: line in .github/workflows/crux-file-size-ratchet.yml.

Workflow pin bump; facts check out. Routing to a maintainer because of the sentinel-alert label, not because of anything wrong in the diff.

What I verified against the repositories (not the PR body):

  • The diff is exactly one line: .github/workflows/crux-file-size-ratchet.yml:37, ref: 13372ca… → ref: 7f93191…. Permissions (contents: read), persist-credentials: false, the sparse-checkout set and the run step are untouched.
  • 7f9319143fc22cd4d4b6b72f64f1aceaf67453dd is the current refs/heads/main of hivecommons/crux (authored by hivecommons-hive[bot], 2026-11-08T01:50Z, "lower proxy/rules.go file-size ratchet baseline to 907 (#125)").
  • compare/13372ca...7f93191 is 132 commits ahead, 0 behind. .github/scripts/check-file-size-ratchet.sh — the only thing this workflow executes — is not among the changed files. The bump therefore changes the baseline (.github/go-file-size-ratchet.txt: agent/manager.go 1658→1657, agent/manager_kick.go 1389→1348, plus the new proxy/rules.go 907 line) and nothing that runs.
  • crux-file-size-ratchet passes on this head (8s).

One body/diff gap, minor: the PR body still says the pin moves to fefb7a3; the diff pins 7f93191, two commits later. The author's follow-up comment already explains the bump to include crux#125, so this is stale prose rather than a wrong change — worth a one-line body edit when the label is cleared.

Nothing here for me to judge beyond that; the trust decision on a workflow edit is a maintainer's.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @16cc758
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @clubanderson should confirm the crux ratchet re-pin to 7f93191 (crux main HEAD, 2026-11-08) is intended and clear the sentinel-alert; the only diff is the ref: line in .github/workflows/crux-file-size-ratchet.yml.
  • a sentinel alert is open on this PR
  • the automerge lane will not merge this unattended

Head: verdict requires_human @16cc758, 63/63 checks green, DCO yes, sentinel alert, soak 0s of 10m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.
  • Resolve the sentinel alert and have a maintainer clear its label.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson approved head 16cc7585f522, which edits CI workflow / action files. That explicit owner approval releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. A new push re-arms the fence until the new head is approved again; the hive's own merge of the base branch, which leaves the diff unchanged, does not.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson approved head 16cc7585f522, which edits CI workflow / action files. Head 5cde2082a00d is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson approved head 5cde2082a00d, which edits CI workflow / action files. Head 456838729b3f is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether hive's crux file-size ratchet keeps a pinned crux SHA (this PR, #17152) or tracks crux main at check time (#17222) — the two PRs change the same line of .github/workflows/crux-file-size-ratchet.yml and cannot both merge.

Conclusion: the change itself is correct and current, but it conflicts with #17222 (same line, opposite approach), so a maintainer needs to pick one before either lands. I have not closed anything.

What I verified

  • The diff changes exactly one line, .github/workflows/crux-file-size-ratchet.yml:37, ref: 13372ca… → ref: 7f9319143fc22cd4d4b6b72f64f1aceaf67453dd.
  • 7f93191 is on crux main lineage (crux#125, 2026-11-08T01:50Z). Its .github/go-file-size-ratchet.txt is byte-identical to crux main today (2e7cd97): 1657 agent/manager.go, 1348 agent/manager_kick.go, 907 proxy/rules.go, …. So the gate this PR installs matches what crux actually enforces right now, and the crux-file-size-ratchet check on this PR is green against it.
  • Minor body/diff drift: the body says it re-pins to fefb7a3; the diff pins 7f93191, which is two commits later (the crux#125 baseline lowering for proxy/rules.go). The diff is the better of the two — just noting it so nobody goes looking for fefb7a3 in the file.

Why this needs a human, not a rebase

#17222 edits the same ref: line to ref: main and rewrites the header comment to say the pin is deliberately gone. These are not duplicates; they are two answers to #17149's question:

  • Pin (this PR): reproducible, and hive CI only ever executes a reviewed crux commit's check-file-size-ratchet.sh. Cost: it goes stale every time crux lowers a baseline — crux has moved 11 commits past this pin in the ~14h since it was cut — so this fix needs repeating.
  • Track main (#17222): never stale. Cost: a hive PR check runs a shell script fetched from an unpinned branch of another repository, so a change to crux main changes what hive CI executes without a hive PR.

Both repos are in the same org and crux's Go tree is itself synced from hive, so the trust gap is narrow — but it is a workflow-trust-surface choice, which is why I am routing it rather than calling it.

If the pin approach wins, this PR is ready as-is. If main wins, this one can be closed in favour of #17222.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@Karibhou

Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Rebase onto v5 resolves to an empty diff: merged #17222 (7b2ec48) changed this workflow to check out crux at ref: main instead of any pinned SHA, which supersedes this re-pin (and does so on purpose, so the baseline cannot drift again). Re-pinning to a SHA would revert #17222's fix. This PR has nothing left to ship and can be closed.

— hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: 68f8dd297

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive will not publish head 456838729b3f upstream: it edits GitHub workflow / action files, which would run with this repository's context once pushed to a branch here. The hive will not re-home or supersede this head.

Ask: a maintainer pushes the fix to this PR's branch and merges it, or cherry-picks the change onto a maintainer-owned branch. Moving to stage/085-needs-decision so a person sees it.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing: superseded by merged #17222 (7b2ec48), which reads the crux ratchet baseline from crux main — a rebase of this branch onto v5 yields an empty diff, as the author noted above.

@hivecommons-hive hivecommons-hive Bot closed this Nov 8, 2026
@Karibhou
Karibhou deleted the ci/repin-crux-ratchet branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] crux-file-size-ratchet.yml pins a stale crux baseline (1658/1389) looser than crux main (1657/1348)

1 participant