Repository navigation
π fix(fleetreport): stage flap suppression is not an unclassified runtime error - #17147
Conversation
β¦time error The stage engine's same-head reversal guard (suppressStageFlap) logs "stage flap suppressed" at WARN each time it refuses to undo its last label write. That is the guard working as designed, but the slogfeed skip added in hivecommons#17109 only matched the stage-label store's dampener message, so repeated suppressions still filed unclassified_error_repeated selfreports. Skip both messages in stageDampenerSuppression. Fixes hivecommons#17142 Hive-Run: hivecommons#17142 Hive-Plan: selfreport-triage Hive-Spec: fleet-report#slogfeed-skip-list Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read this against the tree at f395cd3; looks correct to me.
src/pkg/stageengine/writer.go:78emits exactly"stage flap suppressed"at WARN, so the newcaseinstageDampenerSuppression(slogfeed.go) matches the real message, not an approximation.stageDampenerSuppressionis already in the skip chain atslogfeed.go:117(feed), so no additional wiring was needed β the one-function change is sufficient.- The new test case's attrs (
ref/head/from/to/reason) mirror the actualWarncall shape inwriter.go:78-79.
Only note (non-blocking): the function name stageDampenerSuppression now also covers the stage engine's reversal guard; the doc comment and fleet-report.md say so, which is enough β keeping the existing name is the right call per house style.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Ready for a human merge: verdict approved @f395cd3, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; hive merges it on its next merge pass once CI is green.
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hive queued this PR but could not set the |
Summary
stageengine.suppressStageFlap(src/pkg/stageengine/writer.go) logsstage flap suppressedat WARN whenever it refuses a same-head, same-evidence reversal of its last stage-label write inside the flap window (#16881). That is the guard working as designed, but the slogfeed skip added in #17109 only matched the stage-label store'sstage transition suppressed by dampenermessage, so 5 suppressions in 10m onhosted-available-oke-11-placeholder-r05xstill filed thisunclassified_error_repeatedselfreport (diagnostic:from=060-reviewed to=050-review-pending reason=base-refresh:queued-behind#17109).Change
src/pkg/fleetreport/slogfeed/slogfeed.go:stageDampenerSuppressionnow matches bothstage transition suppressed by dampenerandstage flap suppressed. The WARN stays in local logs.slogfeed_test.go:TestStageDampenerSuppressionLogsWithoutFleetReportis table-driven over both messages; the new case uses the attrs from this issue's diagnostics and asserts no observation while the wrapped handler still sees all 12 records.src/docs/fleet-report.md: skip-list entry names the new message.changelog.d/fixed-17142.md.Verification
Per AGENTS.md, only
gofmt -lwas run locally (clean); CI is the verdict for tests.Fixes #17142
β hive: backend=omp model=anthropic/claude-opus-5-5
π Hive Agent:
contributor| SHA:f395cd355