Skip to content

πŸ› fix(fleetreport): stage flap suppression is not an unclassified runtime error - #17147

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/stage-flap-selfreport-17142
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/stage-flap-selfreport-17142

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Summary

stageengine.suppressStageFlap (src/pkg/stageengine/writer.go) logs stage flap suppressed at WARN whenever it refuses a same-head, same-evidence reversal of its last stage-label write inside the flap window (#16881). That is the guard working as designed, but the slogfeed skip added in #17109 only matched the stage-label store's stage transition suppressed by dampener message, so 5 suppressions in 10m on hosted-available-oke-11-placeholder-r05x still filed this unclassified_error_repeated selfreport (diagnostic: from=060-reviewed to=050-review-pending reason=base-refresh:queued-behind#17109).

Change

  • src/pkg/fleetreport/slogfeed/slogfeed.go: stageDampenerSuppression now matches both stage transition suppressed by dampener and stage flap suppressed. The WARN stays in local logs.
  • slogfeed_test.go: TestStageDampenerSuppressionLogsWithoutFleetReport is table-driven over both messages; the new case uses the attrs from this issue's diagnostics and asserts no observation while the wrapped handler still sees all 12 records.
  • src/docs/fleet-report.md: skip-list entry names the new message.
  • changelog.d/fixed-17142.md.

Verification

Per AGENTS.md, only gofmt -l was run locally (clean); CI is the verdict for tests.

Fixes #17142

β€” hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: f395cd355

…time error

The stage engine's same-head reversal guard (suppressStageFlap) logs
"stage flap suppressed" at WARN each time it refuses to undo its last
label write. That is the guard working as designed, but the slogfeed skip
added in hivecommons#17109 only matched the stage-label store's dampener message, so
repeated suppressions still filed unclassified_error_repeated selfreports.
Skip both messages in stageDampenerSuppression.

Fixes hivecommons#17142

Hive-Run: hivecommons#17142
Hive-Plan: selfreport-triage
Hive-Spec: fleet-report#slogfeed-skip-list
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this against the tree at f395cd3; looks correct to me.

  • src/pkg/stageengine/writer.go:78 emits exactly "stage flap suppressed" at WARN, so the new case in stageDampenerSuppression (slogfeed.go) matches the real message, not an approximation.
  • stageDampenerSuppression is already in the skip chain at slogfeed.go:117 (feed), so no additional wiring was needed β€” the one-function change is sufficient.
  • The new test case's attrs (ref/head/from/to/reason) mirror the actual Warn call shape in writer.go:78-79.

Only note (non-blocking): the function name stageDampenerSuppression now also covers the stage engine's reversal guard; the doc comment and fleet-report.md say so, which is enough β€” keeping the existing name is the right call per house style.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @f395cd3, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; hive merges it on its next merge pass once CI is green.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; hive merges it on its next merge pass once CI is green.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive hivecommons-hive Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive
hivecommons-hive Bot merged commit 9cfb738 into hivecommons:v5 Nov 8, 2026
77 of 80 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#17147f395cd3` sha256:562e3840e84cced0edad7ca5c07b7c0f376980193ba4547c5da034c0a8123cf5 β€” download from the dashboard or `hivectl review evidence #17147`.

@Karibhou
Karibhou deleted the fix/stage-flap-selfreport-17142 branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: stage flap suppressed

1 participant