Repository navigation
🐛 release: tagged-release.yml exceeded GitHub's 21000-char expression limit - #17128
Conversation
A `${{ github.repository }}` mention in a bash comment inside the
push_line step made GitHub evaluate the whole script as an expression;
after the #17083 growth it passed the 21000-character limit, so every
event since bde4411 has reported 'Invalid workflow file … Exceeded max
expression length 21000' for tagged-release.yml and no release has been
considered on v5 or v6. Reword the comment; the script's value comes from
$GITHUB_REPOSITORY already.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Since bde4411 every push, PR and schedule event has produced a failed
tagged-release.ymlrun with no jobs: Invalid workflow file (Line: 960, Col: 14): Exceeded max expression length 21000. No release has been considered on v5 since v5.189.0, and the v6 relay never fired for the 87bfaf3 build.Cause: the
push_linestep'srun:script contains${{ github.repository }}in a bash comment explaining why the script uses$GITHUB_REPOSITORYinstead. Any${{ }}in arun:block makes GitHub evaluate the whole block as one expression; the #17083 state-machine growth took that block from 18.8k to 20.9k characters and over the limit.actionlintdoes not check this limit.Fix: reword the comment (and record the limit there) — the script's behaviour is unchanged;
test-release-push-retry.shPASSES,check-release-lines.shPASSES,actionlintclean, and norun:block in the workflow now contains a workflow expression above ~3.5k chars.Workflow-only change, no
src/code → no changelog fragment. Same fix goes to v6 directly (its copy carries the same script) so both lines agree before the next top-up.