Skip to content

🐛 release: tagged-release.yml exceeded GitHub's 21000-char expression limit - #17128

Merged
clubanderson merged 1 commit into
v5from
ci/tagged-release-expression-length
Nov 7, 2026
Merged

clubanderson merged 1 commit into
v5from
ci/tagged-release-expression-length

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Since bde4411 every push, PR and schedule event has produced a failed tagged-release.yml run with no jobs: Invalid workflow file (Line: 960, Col: 14): Exceeded max expression length 21000. No release has been considered on v5 since v5.189.0, and the v6 relay never fired for the 87bfaf3 build.

Cause: the push_line step's run: script contains ${{ github.repository }} in a bash comment explaining why the script uses $GITHUB_REPOSITORY instead. Any ${{ }} in a run: block makes GitHub evaluate the whole block as one expression; the #17083 state-machine growth took that block from 18.8k to 20.9k characters and over the limit. actionlint does not check this limit.

Fix: reword the comment (and record the limit there) — the script's behaviour is unchanged; test-release-push-retry.sh PASSES, check-release-lines.sh PASSES, actionlint clean, and no run: block in the workflow now contains a workflow expression above ~3.5k chars.

Workflow-only change, no src/ code → no changelog fragment. Same fix goes to v6 directly (its copy carries the same script) so both lines agree before the next top-up.

A `${{ github.repository }}` mention in a bash comment inside the
push_line step made GitHub evaluate the whole script as an expression;
after the #17083 growth it passed the 21000-character limit, so every
event since bde4411 has reported 'Invalid workflow file … Exceeded max
expression length 21000' for tagged-release.yml and no release has been
considered on v5 or v6. Reword the comment; the script's value comes from
$GITHUB_REPOSITORY already.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@clubanderson
clubanderson merged commit 1d6f973 into v5 Nov 7, 2026
85 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the ci/tagged-release-expression-length branch November 7, 2026 23:28
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant