Skip to content

πŸ› ci: native-queue contract test resolves its pin against release_lines - #17120

Merged
clubanderson merged 1 commit into
v5from
ci/native-queue-contract-release-lines
Nov 7, 2026
Merged

clubanderson merged 1 commit into
v5from
ci/native-queue-contract-release-lines

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Follow-up to the v6 release-line cut (merged as bde4411).

.github/scripts/test-native-queue-workflows.py::test_owned_gate_uses_trusted_base_not_member_code asserted pinned["native-queue-policy.yml"] == ["v6", "-v4"]. Now that v6 is a release_lines entry the manifest pins it as [-v4] (v5 and v6 covered), so the test fails as soon as pr-auto-update-test.yml runs β€” it surfaced on the v5β†’v6 top-up PR, and is latent on v5 (the workflow's path filter did not fire for the manifest change).

The test now resolves the pin against release_lines (+ extras, βˆ’ exclusions) and asserts the covered set is exactly [v5, v6], which is what it meant: the admission gate covers the active feature lines and not feature-frozen v4.

Same change is carried on the v6 top-up PR so both lines agree.

v6 is a release_lines entry since the v6 release-line cut, so
native-queue-policy.yml's pin reads [-v4] (v5 and v6 covered) rather
than [v6, -v4]; the test asserted the old literal and would fail the
next time pr-auto-update-test.yml ran on v5.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17048 πŸ› fix(ci): pr-verifier re-runs on label events so bot-pushed heads satisfy 'verify PR contents' same files .github/scripts/test-native-queue-workflows.py

@clubanderson
clubanderson merged commit 4f6cd05 into v5 Nov 7, 2026
87 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the ci/native-queue-contract-release-lines branch November 7, 2026 22:47
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant