Repository navigation
π ci: native-queue contract test resolves its pin against release_lines - #17120
Merged
Merged
Conversation
v6 is a release_lines entry since the v6 release-line cut, so native-queue-policy.yml's pin reads [-v4] (v5 and v6 covered) rather than [v6, -v4]; the test asserted the old literal and would fail the next time pr-auto-update-test.yml ran on v5. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
kubestellar-prow
Bot
deleted the
ci/native-queue-contract-release-lines
branch
November 7, 2026 22:47
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the v6 release-line cut (merged as bde4411).
.github/scripts/test-native-queue-workflows.py::test_owned_gate_uses_trusted_base_not_member_codeassertedpinned["native-queue-policy.yml"] == ["v6", "-v4"]. Now thatv6is arelease_linesentry the manifest pins it as[-v4](v5 and v6 covered), so the test fails as soon aspr-auto-update-test.ymlruns β it surfaced on the v5βv6 top-up PR, and is latent on v5 (the workflow's path filter did not fire for the manifest change).The test now resolves the pin against
release_lines(+ extras, β exclusions) and asserts the covered set is exactly[v5, v6], which is what it meant: the admission gate covers the active feature lines and not feature-frozen v4.Same change is carried on the v6 top-up PR so both lines agree.