Skip to content
1 change: 1 addition & 0 deletions changelog.d/fixed-17103.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **fleetreport:** the stage dampener's `stage transition suppressed by dampener` warning no longer files an `unclassified_error_repeated` fleet selfreport; the suppression is the stage engine working as designed and stays in local logs (#17103).
2 changes: 2 additions & 0 deletions src/docs/fleet-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ is not a repeated runtime defect (hivecommons/hive#16795). The WARN and its
`minutes_since_kick` / `total_action_nudges` fields stay in local logs; actual
nudge-delivery failures remain eligible for reporting when repeated.

It also skips `stage transition suppressed by dampener` (`stageDampenerSuppression`, `pkg/fleetreport/slogfeed/slogfeed.go`): the stage-label store suppresses flapping transitions during its dampener hold window (hivecommons/hive#17103). That is the dampener working as designed, not a runtime error.

The re-engagement sweep logs `re-engagement kick undeliverable; budget not
charged` at INFO rather than WARN when the cause is `shared session pool is
busy` (`deliverReEngagement`, `src/cmd/hive/main_sweeps.go`): a saturated shared CLI
Expand Down
10 changes: 9 additions & 1 deletion src/pkg/fleetreport/slogfeed/slogfeed.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func Key(msg string) string {
}

func (h *Handler) feed(r slog.Record) {
if expectedKickHold(r) || rateLimitedError(r) || sentinelPacingSkip(r) || upstreamUnavailableError(r) || failClosedStatus500(r) || hubHeartbeatUnavailable(r) || hubHeartbeatCachedFallback(r) || reviewCommentCapped(r) || inferenceBlockedStall(r) || automergeMergeGuardSkip(r) || reviewRetryServerError(r) {
if expectedKickHold(r) || rateLimitedError(r) || sentinelPacingSkip(r) || upstreamUnavailableError(r) || failClosedStatus500(r) || hubHeartbeatUnavailable(r) || hubHeartbeatCachedFallback(r) || reviewCommentCapped(r) || inferenceBlockedStall(r) || automergeMergeGuardSkip(r) || reviewRetryServerError(r) || stageDampenerSuppression(r) {
return
}
class := fleetreport.ClassUnclassifiedRepeated
Expand Down Expand Up @@ -228,6 +228,14 @@ func inferenceBlockedStall(r slog.Record) bool {
return blocked
}

// stageDampenerSuppression reports whether r is the stage-label store refusing
// a flapping transition ("stage transition suppressed by dampener"). That is
// the dampener working as designed, not a runtime error; the WARN stays in
// local logs (hivecommons/hive#17103).
func stageDampenerSuppression(r slog.Record) bool {
return strings.TrimSpace(r.Message) == "stage transition suppressed by dampener"
}

// automergeMergeGuardSkip reports whether r is an automerge sweep lane
// (queued, trusted-author or contributor) declining to refresh a PR's base
// while a merge to that destination is already in flight (reason
Expand Down
16 changes: 16 additions & 0 deletions src/pkg/fleetreport/slogfeed/slogfeed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1044,3 +1044,19 @@ func TestReviewRetryServerErrorLogsWithoutFleetReport(t *testing.T) {
})
}
}

// #17103: the stage dampener suppressing a flap is designed behaviour.
func TestStageDampenerSuppressionLogsWithoutFleetReport(t *testing.T) {
logger, seen, out := newFeed(t)
for i := 0; i < 12; i++ {
logger.Warn("stage transition suppressed by dampener",
"key", "hivecommons/hive#17073", "head", "abc", "from", "071-needs-author",
"to", "050-review-pending", "reason", "base-refresh:queued-behind#17048")
}
if len(*seen) != 0 {
t.Errorf("produced observations: %+v", *seen)
}
if n := strings.Count(out.String(), "\n"); n != 12 {
t.Errorf("wrapped handler saw %d records, want 12", n)
}
}
Loading