Skip to content

🐛 fix(review): A stored "could not read, HTTP 429" requires_human no longer parks the PR; the head is asked again - #17082

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/unreadable-stored-verdict
Nov 7, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/unreadable-stored-verdict

Conversation

@Danathar

@Danathar Danathar commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Summary

#16994 stopped the relay from recording a requires_human that only says a rate limit kept the reviewer from reading the PR. Report files written before that fix are still on disk, though, and every verdict collect still turns them into requires_human. So projectbluefin/testsuite#1116 stayed parked at 085 hours after the upgrade. With this change the collect applies the same check to stored files. It treats them as missing and withdraws a stored requires_human that only they produced, so the head reads incomplete and the planner asks again on the normal pending path. Real holds still park the PR.

What went wrong

What changes

  • Collect: a stored report that UnreadableReviewReason matches is set aside as missing, not aggregated. The refresh log line counts these as unreadable_reports_skipped.
  • Merge: a stored requires_human for that head is withdrawn only when the set-aside reports alone produced it. Every perspective it holds at requires_human, every human summary and its security hold (DecisionFinding) must come from one of them. It must also have no decision question, no in-scope finding and no exhausted fix cycle. Anything else keeps the hold, including a real report that is no longer on disk.
  • No hands-free approve while a perspective is owed: the contributor rule resolves a non-security requires_human to approve whatever the coverage. On a head with a set-aside report, a short-coverage approve now reads incomplete instead. Without this, setting aside the unread security report could have made a head merge-eligible with no security review.
  • Re-asking is bounded: the head goes through the planner's normal missing-perspective path. It gets one kick, nothing more inside pending_ttl, then one re-ask per expiry, counted against max_redispatch. It is not re-asked on every sweep.

Files

  • src/pkg/review/review.go: the collect sets reports aside, the merge withdraws (verdictRestsOnUnreadable), and the coverage guard.
  • src/cmd/hive/main_sweeps.go: the new log field.
  • src/docs/review-swarm.md: verdict-flow rule 6 and the unreadable-review paragraph.
  • changelog.d/fixed-review-unreadable-stored-verdict.md

Tests

New file src/pkg/review/unreadable_stored_test.go, using the five real #1116 summaries:

  • TestStoredRateLimitedRequiresHumanIsWithdrawnAndReasked: the stored 5×unread requires_human is withdrawn on disk and holds nothing for a person. One combined re-review of all five perspectives is queued, there is no re-kick inside pending_ttl, and there is one re-ask after it with the redispatch count at 1. Fails on v6 tip, passes with the fix.
  • TestStoredPartlyUnreadableHeadReadsIncomplete: two perspectives approve and three are unread. The head reads incomplete and only the three unread perspectives are re-asked. Fails on tip, passes.
  • TestStoredRealRequiresHumanStillParks: these still park and nothing is re-asked: a security review of a diff too large to read, a hive-authored PR whose diff is too large, a real security finding, and unread text that also carries an in-scope finding, a decision question or the high-risk marker. Passes on tip and with the fix.
  • TestStoredRequiresHumanFromLostReportIsKept and TestStoredUnreadSecurityDoesNotLetContributorHoldResolveToApprove guard the two safety rules above.

go test ./pkg/review/... ./cmd/hive/ pass. go vet is clean, and check-docs-citations.py and check-docs-links.py pass.

Refs #16994

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…unread reports produced

hivecommons#16994 made the relay skip a requires_human that only says a rate limit
kept the reviewer from reading the PR. Report files written before it are
still on disk and still aggregate to requires_human on every collect, so
projectbluefin/testsuite#1116 stayed at 085 at head ae22434 after the
upgrade.

The verdict collect now applies UnreadableReviewReason too and sets those
files aside as missing. The merge withdraws a stored requires_human whose
every requires_human perspective, human summary and security hold comes
from a set-aside report and that has no decision question, in-scope
finding or exhausted fix cycle. The head reads incomplete (or has no
verdict) and the planner re-asks the missing perspectives through the
normal pending_ttl / max_redispatch path. A head with a set-aside
perspective is never approve while it is owed, so the contributor rule's
hands-free approve cannot mark an unread security review merge-eligible.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 56423f1 into hivecommons:v6 Nov 7, 2026
72 of 75 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#170828bdf0f0` sha256:ccaed03e5f11d994f495520450dcae3bf928e83ff3cc44a188608872a6e198ee — download from the dashboard or `hivectl review evidence #17082`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @Danathar holds role owner and GitHub permission maintain on repo; CI green at 8bdf0f0.

hivecommons-hive Bot added a commit that referenced this pull request Nov 7, 2026
… path needs full coverage (#17092)

On a contributor PR, a perspective's reject next to another perspective's
non-security decision question went to the hands-free rule, which made the
question advisory and dropped the reject with it: approve and
merge-eligible (or the fixer lane with a change request). The head now gets
what the reject alone gives it, reject, and the question stays in reasons.

On a hive-authored PR, the advisory approves for a non-risk decision
question and for a bare non-risk requires_human never checked coverage, so
a head whose security review never arrived (a dead kick, or a rate-limited
review the relay no longer records, #16994) was merge-eligible. With a
perspective missing the head now reads incomplete and the planner re-asks
only that perspective. A fully reviewed head still resolves as advisory.

Refs #16994
Refs #17082
Refs #17087


Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant