Repository navigation
🐛 fix(review): A stored "could not read, HTTP 429" requires_human no longer parks the PR; the head is asked again - #17082
Merged
hivecommons-hive[bot] merged 1 commit intoNov 7, 2026
Conversation
…unread reports produced hivecommons#16994 made the relay skip a requires_human that only says a rate limit kept the reviewer from reading the PR. Report files written before it are still on disk and still aggregate to requires_human on every collect, so projectbluefin/testsuite#1116 stayed at 085 at head ae22434 after the upgrade. The verdict collect now applies UnreadableReviewReason too and sets those files aside as missing. The merge withdraws a stored requires_human whose every requires_human perspective, human summary and security hold comes from a set-aside report and that has no decision question, in-scope finding or exhausted fix cycle. The head reads incomplete (or has no verdict) and the planner re-asks the missing perspectives through the normal pending_ttl / max_redispatch path. A head with a set-aside perspective is never approve while it is owed, so the contributor rule's hands-free approve cannot mark an unread security review merge-eligible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Contributor
hivecommons-hive Bot
added a commit
that referenced
this pull request
Nov 7, 2026
… path needs full coverage (#17092) On a contributor PR, a perspective's reject next to another perspective's non-security decision question went to the hands-free rule, which made the question advisory and dropped the reject with it: approve and merge-eligible (or the fixer lane with a change request). The head now gets what the reject alone gives it, reject, and the question stays in reasons. On a hive-authored PR, the advisory approves for a non-risk decision question and for a bare non-risk requires_human never checked coverage, so a head whose security review never arrived (a dead kick, or a rate-limited review the relay no longer records, #16994) was merge-eligible. With a perspective missing the head now reads incomplete and the planner re-asks only that perspective. A fully reviewed head still resolves as advisory. Refs #16994 Refs #17082 Refs #17087 Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#16994 stopped the relay from recording a
requires_humanthat only says a rate limit kept the reviewer from reading the PR. Report files written before that fix are still on disk, though, and every verdict collect still turns them intorequires_human. So projectbluefin/testsuite#1116 stayed parked at 085 hours after the upgrade. With this change the collect applies the same check to stored files. It treats them as missing and withdraws a storedrequires_humanthat only they produced, so the head readsincompleteand the planner asks again on the normal pending path. Real holds still park the PR.What went wrong
ae22434: at 10:59Z the reviewer wrote five "could not read the delta … every GitHub read returned HTTP 429 (hive agent API hourly cap …) … Not reviewed" reports. The PR went tostage/085-needs-decision(stage comment), and the delegate then asked a person about "the security review withheld approval".stage labels: reviewer verdict route … pr=1116 head=ae22434… raw_verdict=requires_human … stage=085-needs-decision reason=adoption-stalled:reviewer-verdict:requires_human.review.Collectreads everyreview-report-*.jsonand aggregates it as a verdict.mergeCollectedthen keeps a storedrequires_humanover any laterincompletecollect (retainsOverIncomplete), so the hold could only clear once a person acted or the head moved.What changes
UnreadableReviewReasonmatches is set aside as missing, not aggregated. The refresh log line counts these asunreadable_reports_skipped.requires_humanfor that head is withdrawn only when the set-aside reports alone produced it. Every perspective it holds atrequires_human, every human summary and its security hold (DecisionFinding) must come from one of them. It must also have no decision question, no in-scope finding and no exhausted fix cycle. Anything else keeps the hold, including a real report that is no longer on disk.requires_humanto approve whatever the coverage. On a head with a set-aside report, a short-coverage approve now readsincompleteinstead. Without this, setting aside the unread security report could have made a head merge-eligible with no security review.pending_ttl, then one re-ask per expiry, counted againstmax_redispatch. It is not re-asked on every sweep.Files
src/pkg/review/review.go: the collect sets reports aside, the merge withdraws (verdictRestsOnUnreadable), and the coverage guard.src/cmd/hive/main_sweeps.go: the new log field.src/docs/review-swarm.md: verdict-flow rule 6 and the unreadable-review paragraph.changelog.d/fixed-review-unreadable-stored-verdict.mdTests
New file
src/pkg/review/unreadable_stored_test.go, using the five real #1116 summaries:TestStoredRateLimitedRequiresHumanIsWithdrawnAndReasked: the stored 5×unreadrequires_humanis withdrawn on disk and holds nothing for a person. One combined re-review of all five perspectives is queued, there is no re-kick insidepending_ttl, and there is one re-ask after it with the redispatch count at 1. Fails on v6 tip, passes with the fix.TestStoredPartlyUnreadableHeadReadsIncomplete: two perspectives approve and three are unread. The head readsincompleteand only the three unread perspectives are re-asked. Fails on tip, passes.TestStoredRealRequiresHumanStillParks: these still park and nothing is re-asked: a security review of a diff too large to read, a hive-authored PR whose diff is too large, a real security finding, and unread text that also carries an in-scope finding, a decision question or the high-risk marker. Passes on tip and with the fix.TestStoredRequiresHumanFromLostReportIsKeptandTestStoredUnreadSecurityDoesNotLetContributorHoldResolveToApproveguard the two safety rules above.go test ./pkg/review/... ./cmd/hive/pass.go vetis clean, andcheck-docs-citations.pyandcheck-docs-links.pypass.Refs #16994
🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1