Repository navigation
✨ knowledge: prime an agent's own drafts when agent_scopes.include_states lists draft - #17079
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#1707919c9f50` sha256:64f1d1f6a86e0d55b13f490e872dbdc3dfc27acfb8a1427ffafdca473bdee698 — download from the dashboard or `hivectl review evidence #17079`. |
5cd5039 to
19c9f50
Compare
…ates lists draft The kick primer admits approved facts only and the agent scope can only narrow, so knowledge.agent_scopes.<agent>.include_states: [draft] never reached a kick. Thread the agent's identities (name, base agent, owner logins) into TOCScope.DraftAuthors when the scope lists draft, admit drafts whose author: frontmatter matches, and render them with a (draft) marker. Approved-only stays the default for every other agent. Fixes #17076 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
19c9f50 to
71d4cf8
Compare
|
@clubanderson this PR is back in your court (
Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 71d4cf8. |
|
The red relative links and anchors resolve check is not this PR's doing: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Fixes #17076
Follow-up to #17042 and @gregoryhunt's knowledge-scoping investigation from the 2026-11-05 community meeting.
Problem
knowledge.agent_scopes.<agent>.include_states: [draft]never reached a kick: the primer is built with noIncludeStates(approved only) andPrimer.PrimeScopedapplies that filter before intersecting the agent scope, which can only narrow. An agent that just wrote a draft entry could not be primed with it.Change (default-safe)
Fact.Authorfromauthor:/owner:frontmatter (filestore.go).FilterByLifecycleFor/lifecycleAllowedFor(lifecycle.go): same as the existing filter, plus drafts whose author is one of the listed identities. Authorless drafts never match.TOCScope.DraftAuthors+knowledge.ListsDraft(toc.go);PrimeScopedandexpandWithGraphuse the author-aware filter.kick_priming.go: when the agent's scope listsdraftorallexplicitly,DraftAuthors= agent name, base agent (Config.BaseAgentName), owner logins (DashboardConfig.OwnerLogins,github:prefix dropped). Emptyinclude_statesdoes not opt in.(draft)marker after its title.Tests
kick_priming_draft_test.go, table-driven over a temp vault: unscoped agent / scope withoutinclude_states/include_states: [deprecated]→ approved only;draftopt-in → own draft + owner draft injected with(draft), other-author and authorless drafts excluded; replica inherits base identity;allopt-in with no matching author → owner drafts only. PluskickDraftAuthorsidentity resolution.Docs
agent-knowledge-and-memory.md,knowledge-toc.md,knowledge-entries.md(authorkey),knowledge-lifecycle.md,knowledge-curator.md; changelog fragmentchangelog.d/added-knowledge-draft-kicks.md.Builds alongside #17060 (
scope:frontmatter); per-entry audience and repo auto-scope are #17077.