Repository navigation
✨ kick priming: one log line per kick with knowledge bytes injected and entries skipped for the cap - #17064
Merged
Conversation
…nd entries skipped for the cap primeKnowledge now returns its numbers (bytes, entries, skipped-for-cap, cap) alongside the rendered section, and every primed kick logs one line "knowledge: injected N bytes from M entries (skipped K for cap)" with the AGENTS.md and skills block sizes that share the kick. The old "injecting facts into kick" line is folded into it; the debounced over-cap detail line stays. Silent when the primer did not run, so a hive without a knowledge store does not log a zero per kick. Proposed by @gregoryhunt at the 2026-11-05 community meeting. Fixes #17049 Part of #17043 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 7, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17049 — phase 3 of #17043 (RFC: AGENTS.md carries tone only; knowledge becomes scoped skills surfaced on demand). Proposed by @gregoryhunt at the 2026-11-05 community meeting; owner Andy (@clubanderson).
What
One structured line per primed kick, emitted from the kick assembly path:
primeKnowledgeis split intoprimeKnowledgeStats(returnsknowledgeInjection{Section, Bytes, Entries, SkippedForCap, CapBytes, Primed}) pluslogKnowledgeInjection. The five lane call sites keep callingprimeKnowledge(which logs withagents_md_bytes=0 skills_bytes=0, correct for them since they prepend neither block);templates.gouses the stats form and logs once after the AGENTS.md and skills blocks are known, with their sizes.primed=true) — that is the signal a lane's work has no entries. Not emitted when the primer did not run (knowledge disabled, no issues, no keywords) so a hive without a knowledge store is not spammed with zeros — unless an AGENTS.md/skills block was injected, in which case the line still reports the payload.knowledge primer: injecting facts into kickline is folded into this one; the debounceddropped facts over the byte capdetail line (omitted bytes/hints) stays.operator-reference/sweeps-and-operations.md"Kick size and the list caps" gets the line next tokick rendered.Tests (table-driven, no
time.Sleep)TestLogKnowledgeInjection: silent / zero line / omissions + AGENTS.md + skills / AGENTS.md-only, asserting every field via a JSON slog handler.TestPrimeKnowledge_LogsOneLinePerKick: real primer over a temp vault at the 512-byte floor; exactly one line,injected_bytesequals the rendered section,entries + skipped_for_capequals the facts found, and the entry count matches the rendered bullets.Note
Touches the same
primeKnowledgebody as #17060 (scope filter); whichever lands second gets a trivial rebase.