Repository navigation
🌱 ci: native-queue-policy re-triggers queue instead of cancelling the evidence wait - #16943
Conversation
…vidence wait Stage-label flips fire pull_request_target every few minutes; with cancel-in-progress the 22.5-minute evidence wait never completed (173/173 runs cancelled on #16607). Serialise per PR, never cancel. Closes #16942 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green (workflow-path fence: needs an owner approval on this head to release). 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Evidence bundle `#16943d302b8d` sha256:f2f2f2d65b84d83b6afbb1a8b643fd6b2a2b575c3721f554d54a145d132fc006 — download from the dashboard or `hivectl review evidence #16943`. |
There was a problem hiding this comment.
Read the workflow at base v5 and the evaluator it drives; this looks correct to me.
What I verified
.github/workflows/native-queue-policy.yml:18— the group was already keyed per PR (github.event.pull_request.number), so flippingcancel-in-progresstofalseonly changes what happens to the in-flight run: it finishes, and the newest re-trigger queues behind it. Formerge_groupthe group isrun_idand cancellation was already a no-op, so that path is unchanged.- Fail-closed claim holds:
.github/scripts/native-queue-policy.cjs:224and:229re-fetch the PR withpulls.getand re-runassertEligible(hold/needs-human/do-not-merge labels,:22/:91) after the evidence wait, so a queued run evaluates live state, not the payload it was triggered with. permissions:(lines 10–14) are untouched — still allread.- The new contract test runs in CI:
pr-auto-update-test.yml:65invokestest-native-queue-workflows.py, and its path filter (lines 14–15 / 31–32) covers both files in this diff, so the test would have fired here.assertIs(..., False)is the right check — the old value was a string expression, not a boolean.
One behaviour to be aware of (not a defect): with cancel-in-progress: false GitHub keeps at most one pending run per group and replaces it on each new trigger, so intermediate label flips will still show as CANCELLED runs on the PR — but the surviving run is always the newest, which is what you want. Worst-case time to a verdict after a flip during a running wait is roughly two evidence windows (~45 min).
This touches .github/workflows/**, so the contributor-lane:workflow-path owner approval is still the gate; nothing here should block that.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
d302b8d
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16942
native-queue-policycould never reach a verdict on a PR the hive is actively staging: every stage-label flip re-fires thepull_request_targetrun, andcancel-in-progresskilled the in-flight 22.5-minute evidence wait each time (173/173 runs cancelled on #16607). The concurrency group already serialises runs per PR, so turning cancellation off makes a re-trigger queue behind the current run instead of aborting it. The newest run still re-reads the mutable PR state after the previous one finishes, so a hold added after a green run still turns the check red — fail-closed semantics are unchanged.The
labeled/unlabeled/editedtriggers are kept on purpose and now pinned by a structural-contract test in.github/scripts/test-native-queue-workflows.py, alongside the assertion that the group never cancels.The issue assumed the App token could not push
.github/workflows/**; this branch pushed cleanly, so the only remaining human step is the owner approval thecontributor-lane:workflow-pathfence asks for.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88