Skip to content

πŸ› fix(adminmcp): issues_by_band accepts the outside band it reports - #16894

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/adminmcp-issues-band-outside
Nov 6, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/adminmcp-issues-band-outside

Conversation

@Danathar

@Danathar Danathar commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Summary

issues_by_band reports a band it then refuses to filter on. The answer lists outside in bands[] with a count, and rows carry band: "outside", but band: "outside" as an argument is refused as an unknown band. On the hive where this was found, 10 of 21 open issues were in that band. This PR accepts it.

What went wrong

Checked against a live v6 hive:

issues_by_band {}
  bands: ready 11, in-progress 0, agent-filed 0, waiting 0, done 0, outside 10

issues_by_band {"band": "outside"}
  refusal: unknown band "outside"; valid bands: ready, in-progress, agent-filed, waiting, done

outside is the band of open issues the scanner kept off the agent queues; each row's bucket says why. The Overview export adds it after the five donut bands. The admin MCP package cannot import the dashboard package, so it keeps its own copy of the band names, and that copy had only the five.

So an operator asking "which issues is the hive not working, and why?" could not ask for that band, and had to page through every row.

What changes

  • issues_by_band accepts outside, in its schema and in its check.
  • prs_by_band is unchanged. Pull requests have no such band, and band: "outside" is still refused there.
  • A new test in the dashboard package compares the tool's band names with what the export can answer, for both tools, so the copy cannot drift again.

Files

  • src/pkg/adminmcp/tools_band_ops.go: issueBandKeys.
  • src/pkg/adminmcp/adminmcp.go: the band argument of issues_by_band gets a description.
  • src/pkg/adminmcp/tools_band_ops_test.go, src/pkg/dashboard/admin_mcp_band_keys_test.go: tests.
  • src/docs/design/admin-mcp.md: one sentence.
  • changelog.d/fixed-admin-mcp-issues-band-outside.md

Tests

  • TestIssuesByBandAcceptsTheOutsideBand: the two outside rows come back, bands[] stays whole, and prs_by_band still refuses it.
  • TestAdminMCPBandKeysAreTheBandsTheOverviewExportAnswersWith
  • Both fail on v6 without the change.
  • go test ./pkg/adminmcp/ ./cmd/hive-admin-mcp/ and the AdminMCP and Overview tests in ./pkg/dashboard/ pass.

πŸ€– Generated with Claude Code

The issues Overview export answers with a sixth band, "outside" (open
issues the scanner kept off the agent queues), in bands[] and on rows.
issues_by_band returned it with its count and refused band=outside as
unknown: adminmcp keeps its own copy of the band keys and the copy had only
the five donut bands.

issueBandKeys gains "outside". A dashboard test compares both tools'
band keys with what the export can answer, so the copy cannot drift
again. prs_by_band is unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 6, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16889 πŸ› fix(adminmcp): reads stop masking values that cannot be a credential same files src/pkg/adminmcp/adminmcp.go
#16884 ✨ feat(adminmcp): read and act on the Activity monitor; writes run as the verified caller same files src/docs/design/admin-mcp.md
src/pkg/adminmcp/adminmcp.go

@hivecommons-hive

hivecommons-hive Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Reviewed by reviewer-2 β€” no findings.

Reviewer notes

Looks correct to me.

Verified in the tree: src/pkg/dashboard/overview_export.go:83 and :296 build the valid/row band sets as issueBandOrder + overviewBandOutside, and rows are stamped Band = outside at :282, so BandReadResult's m["band"] == band filter (src/pkg/adminmcp/tools_band_ops.go:79) now matches real rows instead of refusing a key it just listed. The parity test in admin_mcp_band_keys_test.go pins adminmcp's copy to the export's set, which is the right place since adminmcp can't import dashboard. No findings.

Evidence bundle `#1689419354e6` sha256:cf70e9f2e5f4c68a8b9c0dd5129597c7e2937f171581a278b37436a136a1e56b β€” download from the dashboard or `hivectl review evidence #16894`.

@hivecommons-hive
hivecommons-hive Bot merged commit 762de88 into hivecommons:v6 Nov 6, 2026
72 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant