Repository navigation
π fix(adminmcp): issues_by_band accepts the outside band it reports - #16894
hivecommons-hive[bot] merged 1 commit into
Conversation
The issues Overview export answers with a sixth band, "outside" (open issues the scanner kept off the agent queues), in bands[] and on rows. issues_by_band returned it with its count and refused band=outside as unknown: adminmcp keeps its own copy of the band keys and the copy had only the five donut bands. issueBandKeys gains "outside". A dashboard test compares both tools' band keys with what the export can answer, so the copy cannot drift again. prs_by_band is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Reviewed by Reviewer notesLooks correct to me. Verified in the tree: |
Summary
issues_by_bandreports a band it then refuses to filter on. The answer listsoutsideinbands[]with a count, and rows carryband: "outside", butband: "outside"as an argument is refused as an unknown band. On the hive where this was found, 10 of 21 open issues were in that band. This PR accepts it.What went wrong
Checked against a live v6 hive:
outsideis the band of open issues the scanner kept off the agent queues; each row'sbucketsays why. The Overview export adds it after the five donut bands. The admin MCP package cannot import the dashboard package, so it keeps its own copy of the band names, and that copy had only the five.So an operator asking "which issues is the hive not working, and why?" could not ask for that band, and had to page through every row.
What changes
issues_by_bandacceptsoutside, in its schema and in its check.prs_by_bandis unchanged. Pull requests have no such band, andband: "outside"is still refused there.Files
src/pkg/adminmcp/tools_band_ops.go:issueBandKeys.src/pkg/adminmcp/adminmcp.go: thebandargument ofissues_by_bandgets a description.src/pkg/adminmcp/tools_band_ops_test.go,src/pkg/dashboard/admin_mcp_band_keys_test.go: tests.src/docs/design/admin-mcp.md: one sentence.changelog.d/fixed-admin-mcp-issues-band-outside.mdTests
TestIssuesByBandAcceptsTheOutsideBand: the twooutsiderows come back,bands[]stays whole, andprs_by_bandstill refuses it.TestAdminMCPBandKeysAreTheBandsTheOverviewExportAnswersWithv6without the change.go test ./pkg/adminmcp/ ./cmd/hive-admin-mcp/and theAdminMCPandOverviewtests in./pkg/dashboard/pass.π€ Generated with Claude Code