Repository navigation
π fix(selfreport): classify watchdog agent credential failures - #16866
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16866efbcb77` sha256:5ea336673891d49c72dfe2d098692bc2c8e64312ccd1dac789c6c1ac851eacab β download from the dashboard or `hivectl review evidence #16866`. |
There was a problem hiding this comment.
Looks correct to me β traced the path rather than the diff alone.
- The emit site is
src/crux/watchdog/reconciler.go:804:r.logger.Error("watchdog: agent credential failure", β¦), so the new keyword is an exact (lower-cased substring) match forLogFedClassatsrc/pkg/fleetreport/runtime.go:214-226. - The feed in
src/pkg/fleetreport/slogfeed/slogfeed.go:120-131callsKey()first;Key(slogfeed.go:104-107) now returns""becauseMatchesExplicitClasssees the keyword, so the record drops out ofunclassified_error_repeatedand intoLogFedClassβagent_login_required, which is the stated goal. - No other class keyword contains
credentialorwatchdog, so the random-order map walk inLogFedClasscannot pick a different class. - The watchdog logger is the
slogfeed-wrapped one fromsrc/cmd/hive/main.go:535, so the record actually reaches this feed.
One note, not a defect: reconciler.go:801 only logs on the Authenticated condition's transition to False, while the class keeps MinCount: 5 in 10 minutes. The report therefore still needs a flapping pane (which is what #16861 observed); a single clean failure stays silent, same as before this change.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
docs-currency (delta re-review at efbcb77) β the delta since 70b37be is only Merge branch 'v5' (upstream #16848 / #16867, already on base); the PR's own diff vs merge-base is unchanged (3 files). No prior findings to re-check. Approve.
Advisory (non-blocking): src/docs/fleet-report.md:143 describes agent_login_required as fired only by the login scanner (login required detected, pkg/loginscan). src/pkg/fleetreport/runtime.go:203 now also feeds it from watchdog: agent credential failure; other rows in that table (e.g. line 141) list every keyword, so this row should mention the watchdog source too, so operators grepping the report class find the right emitter.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The watchdog's
agent credential failurelog line (reason PaneShowsLogin) fell through tounclassified_error_repeated. Add it as a keyword of the existing log-fedagent_login_requiredclass so owners get login guidance. Test added to TestRecurringRuntimeMessagesAreClassified.Closes #16861
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88