Skip to content

πŸ› fix(selfreport): classify watchdog agent credential failures - #16866

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16861
Nov 6, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16861

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The watchdog's agent credential failure log line (reason PaneShowsLogin) fell through to unclassified_error_repeated. Add it as a keyword of the existing log-fed agent_login_required class so owners get login guidance. Test added to TestRecurringRuntimeMessagesAreClassified.

Closes #16861

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 6, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

hivecommons-hive Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16866efbcb77` sha256:5ea336673891d49c72dfe2d098692bc2c8e64312ccd1dac789c6c1ac851eacab β€” download from the dashboard or `hivectl review evidence #16866`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me β€” traced the path rather than the diff alone.

  • The emit site is src/crux/watchdog/reconciler.go:804: r.logger.Error("watchdog: agent credential failure", …), so the new keyword is an exact (lower-cased substring) match for LogFedClass at src/pkg/fleetreport/runtime.go:214-226.
  • The feed in src/pkg/fleetreport/slogfeed/slogfeed.go:120-131 calls Key() first; Key (slogfeed.go:104-107) now returns "" because MatchesExplicitClass sees the keyword, so the record drops out of unclassified_error_repeated and into LogFedClass β†’ agent_login_required, which is the stated goal.
  • No other class keyword contains credential or watchdog, so the random-order map walk in LogFedClass cannot pick a different class.
  • The watchdog logger is the slogfeed-wrapped one from src/cmd/hive/main.go:535, so the record actually reaches this feed.

One note, not a defect: reconciler.go:801 only logs on the Authenticated condition's transition to False, while the class keeps MinCount: 5 in 10 minutes. The report therefore still needs a flapping pane (which is what #16861 observed); a single clean failure stays silent, same as before this change.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (delta re-review at efbcb77) β€” the delta since 70b37be is only Merge branch 'v5' (upstream #16848 / #16867, already on base); the PR's own diff vs merge-base is unchanged (3 files). No prior findings to re-check. Approve.

Advisory (non-blocking): src/docs/fleet-report.md:143 describes agent_login_required as fired only by the login scanner (login required detected, pkg/loginscan). src/pkg/fleetreport/runtime.go:203 now also feeds it from watchdog: agent credential failure; other rows in that table (e.g. line 141) list every keyword, so this row should mention the watchdog source too, so operators grepping the report class find the right emitter.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 27c5e4e into v5 Nov 6, 2026
78 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16861 branch November 6, 2026 03:01
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: watchdog: agent credential failure

0 participants