Repository navigation
🐛 fix(glossary): sync capability-gap wording across doc, Go and JS glossaries - #16859
Conversation
…ossaries Closes #16857 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: pushed 86486e5 regenerating 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from The wording change itself is correct — the new The generated dashboard bundle was not regenerated, and that is what both red checks are (
Fix is mechanical: The body says "No consistency test or generated bundle found referencing these" — both exist and both are the failing checks, so that claim should be dropped from the description. Evidence bundle `#1685986486e5` sha256:b2d8d6817e92293645c8cbb75a008d8982cba665cf9b2fa7a033c04549da5675 — download from the dashboard or `hivectl review evidence #16859`. |
TestStageTrackerDecisionGlossaryMirrorsGo and TestIndexHTMLIsGenerated read the generated artifact, which still carried the old capability-gap detail. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
The wording change itself is right, but the PR is incomplete: it edits the static-src part and leaves the committed generated page stale, and the mirror test will fail on this head.
src/pkg/dashboard/static/index.htmlis a generated, committed artifact (src/docs/dashboard-source-layout.md:3-15, "GENERATED. Do not edit" at line 173; generatorsrc/pkg/dashboard/webstatic/indexgen.go:20—//go:generate go run ./gen -src ../static-src -out ../static/index.html). At395753aline 22733 ofstatic/index.htmlstill carries the oldcapability-gapdetail without the new sentence.TestStageTrackerDecisionGlossaryMirrorsGo(src/pkg/dashboard/stage_tracker_glossary_test.go:17-40) reads the embeddedstatic/index.html(clickable_avatars_test.go:14) andreflect.DeepEquals theSTAGE_TRACKER_DECISION_GLOSSARYblock againstdelegatedecision.GlossaryJSON(). Go was updated, the bundle was not, so they now differ oncapability-gap— consistent withtest (dashboard 3/4)being red on this head.
The body says "No consistency test or generated bundle found referencing these"; both exist (above). Fix: run go generate ./pkg/dashboard/webstatic/ from src/ and commit the regenerated static/index.html alongside the static-src edit. Also verified the added sentence is verbatim the doc row at src/docs/labels-and-control-signals/glossary-and-operations.md:18.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16857
The operator doc glossary row for
capability-gap(added in #16811) ends with a rule: a claim that workflow files cannot be pushed is not a gap when the hive checked it can push them. The in-app glossary (Go decision glossary and the JS tracker popover) stopped before it, so the two described the same rule differently. The doc sentence encodes the real rule, so both in-app glossaries now carry it verbatim.Changed: decision_glossary.go, tracker-filter-fetch.js, changelog.d/fixed-16857.md. No consistency test or generated bundle found referencing these; nothing run locally, CI is the verdict.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88