Repository navigation
π fix(blocked): release only the App-applied blocked label from tooling-blocked issues - #16851
Conversation
β¦ng-blocked issues Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16851cdf8907` sha256:634805677fdcfc62f75a85c95143ba707db92a34a919d1692bf0d233b4a112e0 β download from the dashboard or `hivectl review evidence #16851`. |
There was a problem hiding this comment.
Read the caller tree at the v5 merge-base, not just the diff. This looks correct to me.
Why the gate matches the label it is meant to release. The relay applies blocked via markIssueLabel with the hub-minted task credential (bin/contributor-relay.js:7538-7550, token from GH_TOKEN_CACHE), so the labeled timeline actor is the App bot β exactly what isOwnBotLogin (src/pkg/github/pr_issue_link.go:568-578) compares against after stripping app/ and [bot]. BlockedLabelAppliedByHive (issue_blocked.go:596-605) reuses blockedLabelActor's most-recent-labeled walk, so a human re-applying the label after the bot correctly wins (human re-applied after bot case). The predicate is the same one liftBlockedMarkerless already uses at issue_blocked.go:558.
One low finding β the success log now lies in the "left alone" case. releaseToolingBlockedLabel returns nil when !ours (src/pkg/dashboard/contribute_blocked_tooling.go:128-131), and its only caller releaseToolingBlockedIssue logs released the blocked label on any nil error (contribute_blocked_tooling.go:107-108 at merge-base). An operator reading the hive log will see a release that did not happen. Consider either returning a sentinel the caller logs distinctly, or logging the skip inside the gate. Related: liftBlockedMarkerless WARNs when hiveBotLogins() is empty so a stuck label stays visible (issue_blocked.go:558-562); this path is silent in that configuration.
Scope note. The relay already refuses to apply blocked for tooling-failure reasons (contributor-relay.js:7578-7581, #11775), so this hub-side release mostly serves older relays; the fix is still the right shape for #16841. conflicts-with-open-pr is set β #16832 touches the same function, so whichever lands second will need a rebase.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16841
releaseToolingBlockedLabelremovedblockedunconditionally after a tooling-failure blocked verdict, so a human-appliedblockedwas stripped. It now reuses the existingblockedLabelActorgate (via a small exportedClient.BlockedLabelAppliedByHive, same App-bot/hive-author comparison asliftBlockedMarkerless) and only releases a label the hive applied; otherwise it leaves the label and posts no comment.Test: table-driven
TestReleaseToolingBlockedLabel_OnlyHiveAppliedLabel(bot, human, human re-applied, no event). Changelog fragment added.Base branch:
v5(default; bug fix per CONTRIBUTING). The affected code andblockedLabelActorexist on v5 (src/pkg/github/issue_blocked.go), so it will be forward-merged to v6.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88