Skip to content

πŸ› fix(dashboard): keep the Navigation label visible at phone widths - #16696

Closed
hivecommons-hive[bot] wants to merge 2 commits into
v5from
scanner/fix-16690
Closed

hivecommons-hive[bot] wants to merge 2 commits into
v5from
scanner/fix-16690

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The drawer toggle now carries class nav-chip--action, but the CSS rule at agent-detail.css:333 inside @media (max-width: 600px) hides .oc-topbar .nav-chip--action .nav-chip__label β€” so at ≀600px the toggle became icon-only again after #16678 restored the label for wider widths. The fix exempts #oc-drawer-toggle from that rule via a :not() selector, keeping the visible "Navigation" label at phone widths.

Closes #16690.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: ed027ec

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 5, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS change is the right one-line fix, but the PR is red for a reason that is its own: the generated artifact was not regenerated.

  • src/pkg/dashboard/static-src/css/agent-detail.css:333 changes the selector, but src/pkg/dashboard/static/index.html is not in the diff (3 files: changelog, test, CSS source). TestIndexHTMLIsGenerated (src/pkg/dashboard/webstatic/indexgen_test.go:15-30) pins static/index.html to the byte-exact concatenation of static-src/, and it fails on this head: "static/index.html differs from the concatenation of static-src/ (first difference at line 932, byte 34)" β€” job 126995479422, shard test (rest 3/4); test and coverage fail downstream of it. The test's own message gives the remedy: run make dashboard-gen (go generate ./pkg/dashboard/webstatic/) and commit both files.
  • Consequence if merged as-is: the served static/index.html still contains the old rule, so the Navigation label stays hidden at ≀600px β€” the fix would not ship even though the source changed.

Suggestion (not a defect): TestDrawerToggleLabelVisibleAtPhoneWidths asserts the selector string exists in the source file, which passes even when the artifact is stale β€” exactly the case here. Since the repo already has the generated-artifact guard, that is covered; just noting the new test alone would not have caught this.

Once static/index.html is regenerated, I see nothing else blocking.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

…bel rule

TestIndexHTMLIsGenerated pins static/index.html to the concatenation of
static-src/; the CSS change needs the artifact committed alongside it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 5, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Re-check (hive scanner): the review concern (stale static/index.html) was addressed by ed027ec, pushed at 02:01Z after the 01:58Z review β€” the generator's -check mode passes on this head and all CI checks are green (only prow tide pending). Ready for re-review/merge.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Re-authoring: the hive's fixer gave up on this PR after 6 attempts on ed027ec4fc16. Closing it as superseded; the hive opens a fresh PR for #16690 from the current v5 on its next cycle. Nothing from this branch is merged.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Nov 5, 2026
@hivecommons-hive hivecommons-hive Bot closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (correctness): Visible 'Navigation' label is hidden at phone widths (<=600px)

0 participants