Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ff60153
πŸ› fix: label narrow dashboard navigation (#16678)
hivecommons-hive[bot] Nov 5, 2026
05ba6f5
πŸ“– docs: app_signed_commits is a Settings toggle; add operator-referen…
clubanderson Nov 5, 2026
4e7e404
fix(automerge): only re-sign the hive's own commits in in-place DCO r…
hivecommons-hive[bot] Nov 5, 2026
e3f54c2
fix(automerge): apply one hive-ownership rule across DCO split and sq…
hivecommons-hive[bot] Nov 5, 2026
629ca32
test(crux/cline): cover provider-file denials in the worker (#16705)
hivecommons-hive[bot] Nov 5, 2026
1b1d4a6
πŸ› fix(dco): only flag hive-identity DCO splits so a later ai_author c…
hivecommons-hive[bot] Nov 5, 2026
c142df4
fix(dco): clear the hive-identity split marker when a new head is cac…
hivecommons-hive[bot] Nov 5, 2026
f4cd81b
🌱 images: bump agy 1.4.0,5281842794987520 -> 1.5.0,5269980577660928 (…
clubanderson Nov 5, 2026
0c39413
refactor(crux): share follow-stream overlap rule via internal/streamt…
hivecommons-hive[bot] Nov 5, 2026
3b56541
fix(cmd/hive): decouple crux probe deadline from poll interval (#16727)
hivecommons-hive[bot] Nov 5, 2026
6da0cf3
fix(stage-labels): warn once per PR when the write-back gate refuses …
hivecommons-hive[bot] Nov 5, 2026
4b4177c
fix(github): deflake TestWebhookCIRefetchListsHeadOnceAndRecordsListi…
hivecommons-hive[bot] Nov 5, 2026
0d76754
🌱 Forward-merge v5 into v6 (12 commits)
Nov 5, 2026
6421cb6
Remove orphaned serve/log_tail.go after streamtail switch
hivecommons-hive[bot] Nov 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/changed-app-signed-commits-docs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Docs: `github.app_signed_commits` now has an operator-reference row (default off, App-only, what it rewrites, fallbacks, Settings location) and the level-6 checklist and `github-app-setup.md` point at its dashboard switch (Settings β†’ Forge App β†’ "Re-author agent PRs as GitHub-signed commits") instead of calling it YAML-only.
1 change: 1 addition & 0 deletions changelog.d/changed-crux-streamtail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- crux: the follow-stream overlap rule shared by the CLI and the serve layer now lives in one `internal/streamtail` package instead of two copies.
1 change: 1 addition & 0 deletions changelog.d/fixed-16654-navigation-label.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Label the narrow dashboard's navigation drawer button so operators can find sidebar sections and version details without guessing what the menu icon does (#16654).
1 change: 1 addition & 0 deletions changelog.d/fixed-16685.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- In-place DCO repair no longer appends the App's Signed-off-by to a collaborator's unsigned commit on a hive-authored PR: only commits GitHub links to the App bot or a hive identity are re-signed, and a hive-authored PR carrying anyone else's unsigned commit waits for a person instead ([#16685](https://github.com/hivecommons/hive/issues/16685)).
1 change: 1 addition & 0 deletions changelog.d/fixed-16707.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- A DCO split cached while no `project.ai_author` was configured is no longer treated as computed with the hive identity, so configuring it later re-reads the commits for in-flight heads ([#16707](https://github.com/hivecommons/hive/issues/16707)).
1 change: 1 addition & 0 deletions changelog.d/fixed-16710.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- A stale hive-identity DCO marker is now cleared when a new head is cached App-only, so re-adding `ai_author` after removing it re-reads the commit check instead of serving the App-only split ([#16710](https://github.com/hivecommons/hive/issues/16710)).
1 change: 1 addition & 0 deletions changelog.d/fixed-16721.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Decouple the crux sidecar probe deadline from the poll interval so a fast test ticker no longer reports a live `crux serve` as unreachable (#16721).
1 change: 1 addition & 0 deletions changelog.d/fixed-dco-hive-ownership-consistency.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- DCO checks now treat commits linked to `project.ai_author` as the hive's in both the unsigned split and the squash-unsafe count, and a split cached before hive identities counted is read again once, so an in-flight hive-authored PR is re-signed instead of waiting for a person ([#16701](https://github.com/hivecommons/hive/issues/16701), [#16703](https://github.com/hivecommons/hive/issues/16703)). The docs now state that this login linkage comes from the commit email and is trusted only because the in-place path needs base-repo push access ([#16702](https://github.com/hivecommons/hive/issues/16702)).
1 change: 1 addition & 0 deletions changelog.d/fixed-stage-label-reopen-warn-dedupe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- The stage-label reconciler now warns once per PR head and refusal reason when the write-back gate refuses reopening a hive-closed superseded PR, instead of on every tick.
8 changes: 4 additions & 4 deletions src/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ RUN ARCH="${TARGETARCH:-$(dpkg --print-architecture)}" && \
# complete the interactive OAuth flow itself). This enables a self-hosted Hive
# controller to use its configured agy fallback rung without pretending that
# generic contributor containers can bootstrap Google login.
ARG AGY_VERSION=1.4.0
ARG AGY_BUILD=5281842794987520
ARG AGY_SHA512_AMD64=6c4b298c2a69b6bd0f58567031cc56d8097a32be54c4b633aa80ad395871b389618ab3860d4ba0a12599831b8226b51b03e258ee2ec7fae105a45b8e0fce2188
ARG AGY_SHA512_ARM64=64dfb2a9665ebd19b6e9d687c094673b61ca9f5ffdebc81391cea8e3858773e1c88154f088e8a8691208561d946a7aea9acbec7a3bdca9e5d8a48fa197b0a308
ARG AGY_VERSION=1.5.0
ARG AGY_BUILD=5269980577660928
ARG AGY_SHA512_AMD64=e6031f850929210705d8c2393a5665b82b8c3b19684a6d3c556cafa31f26f77acbf164dfee96ca84a5ae7670ac0cc238a974c981c517b269194bdccff271cbd5
ARG AGY_SHA512_ARM64=509518b2820945db2bea5e013ca43a49df5c78927c3ac341a1115287d52627356e1e9506ac0d2040fb467915fba4dde90061d091fddbddf8ddc212637ae40150
RUN ARCH="${TARGETARCH:-$(dpkg --print-architecture)}" && \
case "$ARCH" in \
amd64|x86_64) AGY_URL_ARCH=x64; AGY_FILE_ARCH=x64; AGY_SHA512="$AGY_SHA512_AMD64" ;; \
Expand Down
6 changes: 3 additions & 3 deletions src/Dockerfile.contributor
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@
# NODESOURCE_KEY_SHA256 is the digest of the raw ASCII-armored key as
# published at the URL below; re-verify against NodeSource's documented
# fingerprint (6F71F5252828 41EEDAF851B4 2F59B5F99B1B E0B4) before bumping.
ARG NODESOURCE_KEY_SHA256=b42e0321dabdc24e892115da705cf061167eac12a317f23d329862d0aa0a271d

Check warning on line 246 in src/Dockerfile.contributor

View workflow job for this annotation

GitHub Actions / build-contributor (linux/arm64, true, true, 75)

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NODESOURCE_KEY_SHA256") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 246 in src/Dockerfile.contributor

View workflow job for this annotation

GitHub Actions / build-contributor (linux/amd64, true, false, 60)

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NODESOURCE_KEY_SHA256") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
RUN mkdir -p /etc/apt/keyrings \
&& curl -fsSL -o /tmp/nodesource.key https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
&& echo "${NODESOURCE_KEY_SHA256} /tmp/nodesource.key" | sha256sum -c - \
Expand Down Expand Up @@ -433,9 +433,9 @@
# API-key mode, so a fresh container still needs an operator to sign in
# inside it (or a future credential-mount fix, see Justfile's `agy)` staging
# case) before it can do unattended work.
ARG AGY_VERSION=1.4.0-5281842794987520
ARG AGY_SHA256_AMD64=fd96967583c1eed94733c039638fa59b71ddbd823c75ebc8dd0e677463565aad
ARG AGY_SHA256_ARM64=cf953adcc69f87d00d71f97c3f35dc723a8669a350accf9a199df781f0523f56
ARG AGY_VERSION=1.5.0-5269980577660928
ARG AGY_SHA256_AMD64=f65e365a67be49abdaf92f5669c3157bd4b9c569f6b9f448340b00ca261b0f01
ARG AGY_SHA256_ARM64=87e73a5ab4ecb3a9668660d259dafd13f5443149da0113664d59129a21a62ba4
RUN ARCH="${TARGETARCH:-$(dpkg --print-architecture)}" \
&& case "$ARCH" in \
amd64) AGY_PLATFORM=linux-x64; AGY_TARBALL=cli_linux_x64.tar.gz; AGY_SHA256="$AGY_SHA256_AMD64" ;; \
Expand Down
13 changes: 8 additions & 5 deletions src/cmd/hive/agent_runtime_supervise.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ type cruxRuntimeSupervision struct {
prober runtimeProber
supervisor *cruxruntime.Supervisor
logger *slog.Logger
interval time.Duration
observe func(class, key, message, diagnostics string)
clear func(class, key string)
// interval is the poll-loop period; probeTimeout is the per-probe HTTP
// deadline. They are decoupled so a fast test ticker cannot starve the probe.
interval time.Duration
probeTimeout time.Duration
observe func(class, key, message, diagnostics string)
clear func(class, key string)
}

// newCruxRuntimeSupervision prepares supervision for rt under cfg. It
Expand All @@ -76,7 +79,7 @@ func newCruxRuntimeSupervision(cfg cruxconfig.RuntimeConfig, rt crux.Runtime, lo
return nil
}
}
s := &cruxRuntimeSupervision{cfg: cfg, prober: p, logger: logger, interval: cruxRuntimeProbeInterval, observe: fleetreport.Observe, clear: fleetreport.Clear}
s := &cruxRuntimeSupervision{cfg: cfg, prober: p, logger: logger, interval: cruxRuntimeProbeInterval, probeTimeout: cruxRuntimeProbeInterval, observe: fleetreport.Observe, clear: fleetreport.Clear}
if cfg.Supervise == cruxconfig.SuperviseChild {
s.supervisor = &cruxruntime.Supervisor{Config: cfg, Logger: logger}
}
Expand Down Expand Up @@ -121,7 +124,7 @@ func (s *cruxRuntimeSupervision) watch(ctx context.Context) {
// probe makes one health call so the client's Status reflects the socket
// even when no agent traffic has exercised it.
func (s *cruxRuntimeSupervision) probe(ctx context.Context) {
pctx, cancel := context.WithTimeout(ctx, s.interval)
pctx, cancel := context.WithTimeout(ctx, s.probeTimeout)
defer cancel()
_, _ = s.prober.Client().Health(pctx)
}
Expand Down
14 changes: 14 additions & 0 deletions src/cmd/hive/agent_runtime_supervise_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,20 @@ func TestCruxRuntimeSupervision_NilOutsideSidecar(t *testing.T) {
}
}

func TestCruxRuntimeSupervision_ProbeDeadlineIndependentOfInterval(t *testing.T) {
_, ts := liveServe(t)
s, _, _ := newSupervisionFor(t, ts.URL, cruxconfig.SuperviseExternal)
s.interval = time.Nanosecond

s.probe(context.Background())
if down := s.reconcile(false); down {
t.Fatal("live server reported down with a tiny poll interval")
}
if !s.prober.Status().Reachable {
t.Fatal("prober unreachable with a tiny poll interval")
}
}

func TestCruxRuntimeSupervision_ConditionFollowsReachability(t *testing.T) {
_, ts := liveServe(t)
s, cl, log := newSupervisionFor(t, ts.URL, cruxconfig.SuperviseExternal)
Expand Down
19 changes: 0 additions & 19 deletions src/crux/cli/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -444,25 +444,6 @@ func TestRunStopErrorAndOutputError(t *testing.T) {
}
}

func TestNewTail(t *testing.T) {
cases := []struct {
prev, cur, want []string
}{
{nil, []string{"a", "b"}, []string{"a", "b"}},
{[]string{"a", "b"}, []string{"a", "b"}, nil},
{[]string{"a", "b"}, []string{"a", "b", "c"}, []string{"c"}},
{[]string{"a", "b", "c"}, []string{"b", "c", "d", "e"}, []string{"d", "e"}},
{[]string{"a", "b"}, []string{"x", "y"}, []string{"x", "y"}},
{[]string{"a", "b"}, []string{"b"}, nil},
}
for _, c := range cases {
got := newTail(c.prev, c.cur)
if strings.Join(got, ",") != strings.Join(c.want, ",") {
t.Errorf("newTail(%v, %v) = %v, want %v", c.prev, c.cur, got, c.want)
}
}
}

func hiveYAML(t *testing.T) string {
t.Helper()
dir := t.TempDir()
Expand Down
31 changes: 2 additions & 29 deletions src/crux/cli/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"time"

"github.com/hivecommons/hive/crux"
"github.com/hivecommons/hive/crux/internal/streamtail"
)

// subFlags builds a subcommand flag set that reports to stderr and never
Expand Down Expand Up @@ -130,42 +131,14 @@ func (e *Env) stream(ctx context.Context, rt crux.Runtime, name string, interval
fmt.Fprintf(e.Stderr, "crux: output %s: %v\n", name, err)
return
}
for _, line := range newTail(prev, cur) {
for _, line := range streamtail.Fresh(prev, cur) {
fmt.Fprintln(e.Stdout, line)
}
prev = cur
}
}
}

// newTail returns the lines of cur that were not already printed from prev,
// treating both as windows onto the same append-only buffer: the longest
// suffix of prev that is a prefix of cur is the overlap.
func newTail(prev, cur []string) []string {
max := len(prev)
if len(cur) < max {
max = len(cur)
}
for k := max; k > 0; k-- {
if equalLines(prev[len(prev)-k:], cur[:k]) {
return cur[k:]
}
}
return cur
}

func equalLines(a, b []string) bool {
if len(a) != len(b) {
return false
}
for i := range a {
if a[i] != b[i] {
return false
}
}
return true
}

// processRow is the ps projection of a crux.Process: the columns an operator
// reads at a glance, and the JSON shape --json emits.
type processRow struct {
Expand Down
67 changes: 67 additions & 0 deletions src/crux/cline/provider_file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,70 @@ func TestProviderStagingRootAndRedactionFailures(t *testing.T) {
t.Fatal("nested or overlapping secret redaction failed")
}
}

func TestMountedProviderWorkerDenials(t *testing.T) {
root, workspace := t.TempDir(), t.TempDir()
t.Setenv("HOME", root)
t.Setenv("HIVE_CLINE_CONFIG_DIR", "")
source := filepath.Join(root, "source")
credentials(t, source, providerConfig)
p, err := StageProviderFile(source, "openrouter/test", workspace)
if err != nil {
t.Fatal(err)
}
defer p.Close()
mounted, err := p.MountFile(workspace)
if err != nil {
t.Fatal(err)
}
narrowed, err := os.ReadFile(mounted)
if err != nil {
t.Fatal(err)
}
// A denied provider file must never reach inference: the stub leaves a
// marker when launched, and none of the cases below may create it.
launched := filepath.Join(root, "launched")
binary := fakeCLI(t, "touch "+launched+`; cat >/dev/null; echo '{"type":"run_result","finishReason":"completed","text":"done"}'`)
write := func(path string, body []byte) string {
t.Helper()
if err := os.WriteFile(path, body, 0o600); err != nil {
t.Fatal(err)
}
return path
}
inWorkspace := write(filepath.Join(workspace, "providers.json"), narrowed)
viaSymlink := filepath.Join(root, "outside-link")
if err := os.Symlink(inWorkspace, viaSymlink); err != nil {
t.Fatal(err)
}
unreadable := filepath.Join(root, "directory-not-file")
if err := os.Mkdir(unreadable, 0o700); err != nil {
t.Fatal(err)
}
cases := []struct {
name, file, want string
}{
{"inside workspace", inWorkspace, "outside the Git workspace"},
{"symlink into workspace", viaSymlink, "outside the Git workspace"},
{"missing", filepath.Join(root, "missing"), "cannot resolve"},
{"unreadable", unreadable, "cannot read the mounted selected Cline provider"},
{"unsupported schema", write(filepath.Join(root, "schema.json"), []byte(`{"version":2}`)), "unsupported Cline providers.json schema"},
{"other provider only", write(filepath.Join(root, "other.json"), []byte(`{"version":1,"providers":{"other":{"settings":{"apiKey":"test-key"}}}}`)), "not configured"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
var out, errOut bytes.Buffer
code := Run([]string{"--cline", binary, "--model", "openrouter/test", "--provider-file", tc.file,
"--cwd", workspace, "--state-dir", filepath.Join(root, "state")}, strings.NewReader("bounded task"), &out, &errOut)
if code != 1 || !strings.Contains(errOut.String(), tc.want) {
t.Fatalf("code %d, stderr %q", code, &errOut)
}
if strings.Contains(errOut.String(), "test-key") || strings.Contains(out.String(), "test-key") {
t.Fatal("denial leaked the provider credential")
}
if _, err := os.Stat(launched); !os.IsNotExist(err) {
t.Fatal("denied provider file still launched the Cline CLI")
}
})
}
}
30 changes: 30 additions & 0 deletions src/crux/internal/streamtail/streamtail.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Package streamtail computes the unseen part of a polled output window.
package streamtail

// Fresh returns the lines of cur that were not already seen in prev, treating
// both as windows onto the same append-only buffer: the longest suffix of prev
// that is a prefix of cur is the overlap.
func Fresh(prev, cur []string) []string {
max := len(prev)
if len(cur) < max {
max = len(cur)
}
for k := max; k > 0; k-- {
if equalLines(prev[len(prev)-k:], cur[:k]) {
return cur[k:]
}
}
return cur
}

func equalLines(a, b []string) bool {
if len(a) != len(b) {
return false
}
for i := range a {
if a[i] != b[i] {
return false
}
}
return true
}
25 changes: 25 additions & 0 deletions src/crux/internal/streamtail/streamtail_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package streamtail

import (
"strings"
"testing"
)

func TestFresh(t *testing.T) {
cases := []struct {
prev, cur, want []string
}{
{nil, []string{"a", "b"}, []string{"a", "b"}},
{[]string{"a", "b"}, []string{"a", "b"}, nil},
{[]string{"a", "b"}, []string{"a", "b", "c"}, []string{"c"}},
{[]string{"a", "b", "c"}, []string{"b", "c", "d", "e"}, []string{"d", "e"}},
{[]string{"a", "b"}, []string{"x", "y"}, []string{"x", "y"}},
{[]string{"a", "b"}, []string{"b"}, nil},
{[]string{"a", "b", "c"}, []string{"c"}, nil},
}
for _, c := range cases {
if got := Fresh(c.prev, c.cur); strings.Join(got, ",") != strings.Join(c.want, ",") {
t.Errorf("Fresh(%v, %v) = %v, want %v", c.prev, c.cur, got, c.want)
}
}
}
30 changes: 0 additions & 30 deletions src/crux/serve/log_tail.go

This file was deleted.

3 changes: 2 additions & 1 deletion src/crux/serve/serve_follow.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/hivecommons/hive/crux"
"github.com/hivecommons/hive/crux/api"
"github.com/hivecommons/hive/crux/internal/streamtail"
)

// followWindow is how many ring-buffer lines each follow poll asks for when
Expand Down Expand Up @@ -74,7 +75,7 @@ func (s *Server) followLogs(w http.ResponseWriter, r *http.Request, name string,
flusher.Flush()
return
}
if fresh := newTail(prev, cur); len(fresh) > 0 {
if fresh := streamtail.Fresh(prev, cur); len(fresh) > 0 {
if api.WriteEvent(w, api.EventLog, api.LogChunk{Agent: name, Lines: fresh}) != nil {
return
}
Expand Down
14 changes: 1 addition & 13 deletions src/crux/serve/serve_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,7 @@ func TestWriteJSONLogsEncodeFailures(t *testing.T) {

func slogTo(w io.Writer) *slog.Logger { return slog.New(slog.NewTextHandler(w, nil)) }

func TestIsTrueAndNewTail(t *testing.T) {
func TestIsTrue(t *testing.T) {
for _, v := range []string{"1", "true", "YES", "on"} {
if !isTrue(v) {
t.Errorf("%q should be true", v)
Expand All @@ -1232,16 +1232,4 @@ func TestIsTrueAndNewTail(t *testing.T) {
t.Errorf("%q should be false", v)
}
}
cases := []struct{ prev, cur, want []string }{
{nil, []string{"a"}, []string{"a"}},
{[]string{"a", "b"}, []string{"a", "b"}, nil},
{[]string{"a", "b"}, []string{"b", "c"}, []string{"c"}},
{[]string{"a", "b"}, []string{"x", "y"}, []string{"x", "y"}},
{[]string{"a", "b", "c"}, []string{"c"}, nil},
}
for _, c := range cases {
if got := newTail(c.prev, c.cur); strings.Join(got, ",") != strings.Join(c.want, ",") {
t.Errorf("newTail(%v,%v) = %v, want %v", c.prev, c.cur, got, c.want)
}
}
}
2 changes: 2 additions & 0 deletions src/docs/github-app-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ github:
app_signed_commits: true # opt-in; needs an installed App
```

In the dashboard the same switch is **Settings β†’ Forge App β†’ Re-author agent PRs as GitHub-signed commits** (Owner role required to save).

With it on, the PR-request watcher (the choke point every `hive-open-pr` request passes through) re-authors the head branch before it opens the PR: it reads the `base...head` diff, builds one commit through the mutation with the App installation token β€” same tree, the agents' original commit messages and DCO trailers as the message β€” force-updates the branch to it, and then opens the PR. The PR arrives with a single commit, signed by GitHub, authored by `<app_slug>[bot]`, that a `required_signatures` rule accepts.

**DCO.** The mutation takes no author: GitHub stamps its own bot account on the commit (`<app_slug>[bot] <id+slug[bot]@users.noreply.github.com>`). That is fine for the DCO checks - probot-dco exempts a commit whose GitHub author resolves to a Bot account, and Prow's `dco` plugin only requires a `Signed-off-by` line to be present. The `Signed-off-by` trailers copied from the agents' commits are what the hive controls, and they are re-addressed to the bracket-free form the pane identity uses since #6276: a `<slug>[bot]@users.noreply.github.com` sign-off (with or without GitHub's numeric prefix) becomes `<slug>@hive.kubestellar.io` (`HIVE_GIT_BOT_EMAIL_DOMAIN`), because probot-dco rejects the bracketed local-part as "not a valid email address" wherever it does validate it (#6251). Every other sign-off address, a human's or the legacy `hive-bot@kubestellar.io`, is copied unchanged.
Expand Down
Loading
Loading