Skip to content

📖 docs: app_signed_commits is a Settings toggle; add operator-reference row - #16684

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
docs/app-signed-commits-drift
Nov 5, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
docs/app-signed-commits-drift

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

Prompted by torch-spyre/spyre-inference#1507 (agent PR blocked by required_signatures; the operator asked whether a UI toggle exists). It does, but the docs disagreed with each other:

  • src/docs/running-at-level-6.md G8 said github.app_signed_commits is "not a dashboard switch" — stale; the toggle is under Settings → Forge App → Re-author agent PRs as GitHub-signed commits.
  • src/docs/operator-reference/README.md had no row for github.app_signed_commits. Added one: default off, App-only (PAT hives ignore it), what the rewrite does, the signed_skipped fallbacks, the reconcile pass, Settings location, link to github-app-setup.md#signed-commits-on-agent-prs-app_signed_commits.
  • src/docs/github-app-setup.md now names the dashboard location next to the YAML snippet.

Changelog fragment: changelog.d/changed-app-signed-commits-docs.md. check-docs-citations.py --fix: clean.

Docs only; no code changes.

…ce row

running-at-level-6.md G8 called github.app_signed_commits YAML-only, but the
dashboard has had the switch under Settings → Forge App since the toggle
landed, and operator-reference/README.md had no row for the key at all.
Add the row (default off, App-only, what it rewrites, fallbacks, Settings
location, link to github-app-setup.md) and name the dashboard location in
github-app-setup.md next to the YAML snippet.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16607 ✨ feat(github): enforce pin-only exception in merge-request relay same files src/docs/operator-reference/README.md
#16680 ✨ feat(settings): expose merge-train controls in Auto-merge same files src/docs/operator-reference/README.md

@hivecommons-hive

hivecommons-hive Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build (linux/amd64, true, false, 60)
  • build (linux/arm64, true, true, 75)
  • docker (hive)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#1668422a13bf` sha256:132a9b279f108dc35d2fef8b4b7a2644c05d182ca1169946b90f9ea3f7592287 — download from the dashboard or `hivectl review evidence #16684`.

@hivecommons-hive
hivecommons-hive Bot merged commit 05ba6f5 into v5 Nov 5, 2026
75 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the docs/app-signed-commits-drift branch November 5, 2026 01:20
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 22a13bf.

hivecommons-hive Bot added a commit that referenced this pull request Nov 5, 2026
…ce row (#16684)

running-at-level-6.md G8 called github.app_signed_commits YAML-only, but the
dashboard has had the switch under Settings → Forge App since the toggle
landed, and operator-reference/README.md had no row for the key at all.
Add the row (default off, App-only, what it rewrites, fallbacks, Settings
location, link to github-app-setup.md) and name the dashboard location in
github-app-setup.md next to the YAML snippet.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant