Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-16654-navigation-label.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Label the narrow dashboard's navigation drawer button so operators can find sidebar sections and version details without guessing what the menu icon does (#16654).
4 changes: 2 additions & 2 deletions src/pkg/dashboard/static-src/html/topbar.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!-- Light top bar (hidden by default) -->
<header id="oc-topbar" class="oc-topbar">
<div class="oc-topbar-left">
<button id="oc-drawer-toggle" class="nav-chip nav-chip--icon nav-chip--action" type="button" aria-label="Open menu"
<button id="oc-drawer-toggle" class="nav-chip nav-chip--action" type="button" aria-label="Open navigation"
aria-expanded="false" aria-controls="oc-sidebar"
title="Menu">&#9776;</button>
title="Open navigation"><span class="nav-chip__icon" aria-hidden="true">&#9776;</span><span class="nav-chip__label">Navigation</span></button>
<span id="oc-project-name" class="oc-project-title"></span>
<button type="button" id="acmm-badge" class="nav-chip nav-chip--level nav-chip--gold" data-action="openACMMDialog" aria-haspopup="dialog" aria-controls="acmm-overlay" title="Change the current ACMM autonomy level" aria-label="Change ACMM autonomy level"></button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion src/pkg/dashboard/static-src/js/chat.js
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,8 @@
sidebar.classList.toggle('open', open);
backdrop.classList.toggle('open', open);
toggle.setAttribute('aria-expanded', open ? 'true' : 'false');
toggle.setAttribute('aria-label', open ? 'Close menu' : 'Open menu');
toggle.setAttribute('aria-label', open ? 'Close navigation' : 'Open navigation');
toggle.title = open ? 'Close navigation' : 'Open navigation';
}
function closeDrawer() { if (isOpen()) setOpen(false); }

Expand Down
7 changes: 4 additions & 3 deletions src/pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7963,9 +7963,9 @@ <h2 class="config-title">🐝 Getting Started<span id="welcome-progress" class="
<!-- Light top bar (hidden by default) -->
<header id="oc-topbar" class="oc-topbar">
<div class="oc-topbar-left">
<button id="oc-drawer-toggle" class="nav-chip nav-chip--icon nav-chip--action" type="button" aria-label="Open menu"
<button id="oc-drawer-toggle" class="nav-chip nav-chip--action" type="button" aria-label="Open navigation"
aria-expanded="false" aria-controls="oc-sidebar"
title="Menu">&#9776;</button>
title="Open navigation"><span class="nav-chip__icon" aria-hidden="true">&#9776;</span><span class="nav-chip__label">Navigation</span></button>
<span id="oc-project-name" class="oc-project-title"></span>
<button type="button" id="acmm-badge" class="nav-chip nav-chip--level nav-chip--gold" data-action="openACMMDialog" aria-haspopup="dialog" aria-controls="acmm-overlay" title="Change the current ACMM autonomy level" aria-label="Change ACMM autonomy level"></button>
</div>
Expand Down Expand Up @@ -66694,7 +66694,8 @@ <h4>${model.editIndex === null ? 'Add Event trigger' : 'Edit Event trigger'}</h4
sidebar.classList.toggle('open', open);
backdrop.classList.toggle('open', open);
toggle.setAttribute('aria-expanded', open ? 'true' : 'false');
toggle.setAttribute('aria-label', open ? 'Close menu' : 'Open menu');
toggle.setAttribute('aria-label', open ? 'Close navigation' : 'Open navigation');
toggle.title = open ? 'Close navigation' : 'Open navigation';
}
function closeDrawer() { if (isOpen()) setOpen(false); }

Expand Down
Loading