Repository navigation
π Accept triage advances the issue to 010 actionable in the same request - #16656
Conversation
Clicking Accept triage added triage/accepted but wrote no stage label, so an issue the reporter-trust gate had parked at 000-new (no stage label, no engine record) kept reading "New" until the stage engine's next pass; the tracker's 015β010 override only covered a stored 015 record. The handler now writes stage/010-actionable with the accept label when the issue carries no stage label or stage/015 (removes before adds, so a single stage label; never regresses a later stage; skipped on a held issue), and a retry on an accepted-but-unstaged issue adds the stage label instead of no-op'ing. The tracker derives 010 for triage/accepted with no stage label and no record rather than 000-new. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at eb2a3bf. |
Fixes #16655
Root cause
"Accept triage" added
triage/acceptedand removedneeds-triage/stage/015-triage-needed, but never wrote a stage label β it relied on the stage engine's next pass. The tracker's compensating 015 -> 010 override only fired for a stored 015 record. An issue the reporter-trust gate had parked at 000-new (no stage label, no record β #16652) therefore stayed at "New" after the click, derived purely from the absence of a stage label.Fix
api_repo_item_accept_triage.go): writesstage/010-actionablealongside the accept label when the issue has no stage label or wears 015 (removes before adds, so a single stage label; never regresses a later stage; skipped on a held issue). A retry on an accepted-but-unstaged issue now adds the stage label instead of no-op'ing.stage_tracker_build.go):triage/acceptedwith no awaiting label, no stage label and no engine record derives 010 Actionable, not 000-new.triage/acceptedwithout a stage label is not "New".go test ./pkg/dashboard/ -run 'Decision|StageTracker|Triage|AcceptTriage'passes locally.