Skip to content

πŸ› Accept triage advances the issue to 010 actionable in the same request - #16656

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/accept-triage-advances-stage
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/accept-triage-advances-stage

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16655

Root cause

"Accept triage" added triage/accepted and removed needs-triage/stage/015-triage-needed, but never wrote a stage label β€” it relied on the stage engine's next pass. The tracker's compensating 015 -> 010 override only fired for a stored 015 record. An issue the reporter-trust gate had parked at 000-new (no stage label, no record β€” #16652) therefore stayed at "New" after the click, derived purely from the absence of a stage label.

Fix

  • Handler (api_repo_item_accept_triage.go): writes stage/010-actionable alongside the accept label when the issue has no stage label or wears 015 (removes before adds, so a single stage label; never regresses a later stage; skipped on a held issue). A retry on an accepted-but-unstaged issue now adds the stage label instead of no-op'ing.
  • Tracker (stage_tracker_build.go): triage/accepted with no awaiting label, no stage label and no engine record derives 010 Actionable, not 000-new.
  • Tests: handler writes the stage label (000-new, 015, retry, no regression of 020, held issue); tracker row for triage/accepted without a stage label is not "New".

go test ./pkg/dashboard/ -run 'Decision|StageTracker|Triage|AcceptTriage' passes locally.

Clicking Accept triage added triage/accepted but wrote no stage label, so
an issue the reporter-trust gate had parked at 000-new (no stage label,
no engine record) kept reading "New" until the stage engine's next pass;
the tracker's 015β†’010 override only covered a stored 015 record.

The handler now writes stage/010-actionable with the accept label when
the issue carries no stage label or stage/015 (removes before adds, so a
single stage label; never regresses a later stage; skipped on a held
issue), and a retry on an accepted-but-unstaged issue adds the stage
label instead of no-op'ing. The tracker derives 010 for triage/accepted
with no stage label and no record rather than 000-new.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16662 πŸ› Review and CI chevrons state what the head waits on, never "activity unknown" same files src/pkg/dashboard/stage_tracker_build.go

@hivecommons-hive
hivecommons-hive Bot merged commit 2a16238 into v5 Nov 4, 2026
79 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/accept-triage-advances-stage branch November 4, 2026 20:14
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#16656eb2a3bf` sha256:beb03e330bc25f6290e5827d23cb3c85125469d6071c02e712c6da7e0f3c7b22 β€” download from the dashboard or `hivectl review evidence #16656`.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at eb2a3bf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Accept triage adds triage/accepted but the issue stays at 000-new

1 participant