Repository navigation
🐛 fix: require sign-off for workflow review questions - #16646
Conversation
Hive-Run: hivecommons#16638 Hive-Plan: workflow review policy sign-off Hive-Spec: reviewer-question-auto-decide#policy-sign-off Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Read the classifier and its caller; this looks correct to me, and it is a strict tightening.
ClassifyDecisionQuestion(src/pkg/review/decision_question_class.go:118) now returnsPolicySignOfffor.github/workflows/**/.github/actions/**on any PR, not only forks. The check sits before the policy-path and scope branches, so nothing earlier can route a workflow edit to auto-decide. Nothing is widened; per #16638 (the hive's own security finding) this is the requested behaviour, so no maintainer decision is needed.- Tests updated for fork, same-repo workflow (with a
permissions: contents: writepatch) and same-repo action cases. - Operator reference and the
security-changelog fragment say "regardless of PR origin". - Builds at
4a99585;go testis CI-only here.
Two notes, neither blocking:
DecisionQuestionInput.FromFork(decision_question_class.go:46) is still set atsrc/pkg/dashboard/review_question_autodecide.go:348but no longer read. Keeping the field is fine for compatibility; a follow-up could drop or document it.- #16638 is marked blocked on #16524 for
v6; this targetsv5, where the file already exists, so it will carry forward with the v5→v6 merge.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Reviewed by Reviewer notesRead
No findings. One note for the maintainer: the issue is — hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88 stage 095-pre-merge-soak → 060-reviewed: untrusted-author-role Evidence bundle `#166464fb80e0` sha256:abdb4ce43726e6676175fc3094fb29d9c9a1477f789a7bdced098e3c6951fec9 — download from the dashboard or `hivectl review evidence #16646`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Ready for a human merge: verdict approved @4a99585, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
merged by Hive on behalf of @clubanderson, who approved this head (operator-approval:clubanderson) with "Approve and let hive merge": author @Karibhou holds no trusted-author role; CI green at 4fb80e0. |
Fixes #16638
Reviewer questions on workflow and action edits now require human policy sign-off for same-repository PRs as well as forks. This prevents bare permission-scope questions from being automatically delegated.
Verification: ran a Go smoke program against the classifier for same-repository and fork workflows, same-repository actions, and an ordinary scope question; gofmt -l reported no files. Repository policy reserves tests for CI.
— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:4a9958511