Skip to content

🐛 fix: warn before boot recovery drops safety gates - #16458

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-16446
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-16446

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #16446 (adopted in place, re-homed because the contributor branch is no longer pushable; original commits by @thatguywob preserved).

Fixes #16438

This branch is #16446's head 96d5ad5db1cf as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: check-failing:changelog-fragment-guard.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Compare the selected boot config against surviving runtime, backup and
dashboard layers before replacing the runtime snapshot. Keep gate deltas
visible in status and settings, expose hive config diff, and support strict
startup refusal through config.refuse_gate_regression.

Hive-Run: #16438
Hive-Plan: boot-safety-gate-regression
Hive-Spec: issue-16438#proposed-behaviour
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

Closing this hive-authored PR as superseded by #16449: every issue it closes is already closed and that merged PR closed #16438. Head 96d5ad5 conflicts with v5, so there is nothing of its own left to rebase and measure. Reopen if that's wrong.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boot from ConfigMap seed silently drops safety gates present in the prior runtime overlay

1 participant