Repository navigation
🌱 test(integration-materialize): disable auto gc and retry rmSync in fixture teardown - #16416
Conversation
…xture teardown Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Evidence bundle `#164165af6d97` sha256:bd9f529b831176dff3d40390270c2f326e591b8a40924e46728c55a0fb7affa3 — download from the dashboard or `hivectl review evidence #16416`. |
There was a problem hiding this comment.
Looks correct to me, and complete.
The one question this change raises is whether the module under test can still fork a gc --auto through its own unguarded wrapper (.github/scripts/integration-materialize.cjs:120-121, which runs fetch at :223/:237 — and fetch does trigger auto-maintenance). It cannot here: the test replaces f.git (integration-materialize.test.cjs:319-323) with a stub that short-circuits fetch/push and routes every other call through the fixture's wrapper, which now carries gc.auto=0 / maintenance.auto=false. So every git process that writes to the throwaway repo is covered.
Matches the guard #16412 put on integration-governance.test.cjs:87 and :149 line for line.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16414
Why: #16412 fixed a race in integration-governance.test.cjs where a background git gc --auto spawned by the fixture's commits could still hold the throwaway repo open while fs.rmSync removed it recursively, failing the run with ENOTEMPTY. integration-materialize.test.cjs builds its fixture the same way (several commits through a per-call -c core.hooksPath=/dev/null wrapper, then an un-retried recursive rmSync) and so has the same race. This applies the same two guards there: gc.auto=0 / maintenance.auto=false on the wrapper and maxRetries/retryDelay on the teardown.
Test-fixture-only change; no behaviour change.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88