Skip to content

🌱 test(integration-materialize): disable auto gc and retry rmSync in fixture teardown - #16416

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16414
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16414

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #16414

Why: #16412 fixed a race in integration-governance.test.cjs where a background git gc --auto spawned by the fixture's commits could still hold the throwaway repo open while fs.rmSync removed it recursively, failing the run with ENOTEMPTY. integration-materialize.test.cjs builds its fixture the same way (several commits through a per-call -c core.hooksPath=/dev/null wrapper, then an un-retried recursive rmSync) and so has the same race. This applies the same two guards there: gc.auto=0 / maintenance.auto=false on the wrapper and maxRetries/retryDelay on the teardown.

Test-fixture-only change; no behaviour change.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…xture teardown

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Evidence bundle `#164165af6d97` sha256:bd9f529b831176dff3d40390270c2f326e591b8a40924e46728c55a0fb7affa3 — download from the dashboard or `hivectl review evidence #16416`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, and complete.

The one question this change raises is whether the module under test can still fork a gc --auto through its own unguarded wrapper (.github/scripts/integration-materialize.cjs:120-121, which runs fetch at :223/:237 — and fetch does trigger auto-maintenance). It cannot here: the test replaces f.git (integration-materialize.test.cjs:319-323) with a stub that short-circuits fetch/push and routes every other call through the fixture's wrapper, which now carries gc.auto=0 / maintenance.auto=false. So every git process that writes to the throwaway repo is covered.

Matches the guard #16412 put on integration-governance.test.cjs:87 and :149 line for line.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 33def76 into v5 Nov 3, 2026
87 of 92 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16414 branch November 3, 2026 10:51
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (style): integration-materialize.test.cjs fixture has the same gc/rmSync race shape

0 participants