Repository navigation
π± test(crux/lanes): drop TestValidateNamesFailingField subsumed by the bounds table - #16415
Conversation
β¦ds table Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#164154643086` sha256:e0449f19ea087e288ab674e87333fba8a09f50f4b843f5cc17449ba172cb78d7 β download from the dashboard or `hivectl review evidence #16415`. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16413
Why: #16411 added a table-driven test in config_bounds_test.go that asserts every per-field bounds error, including the max_pending case. TestValidateNamesFailingField in config_duration_test.go built the same baseline config and asserted the same message, so the two would drift on one assertion; it also lived in a duration-themed file where it never belonged. Removing the older test keeps one source of truth.
Test-only change; no behaviour change.
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88