Repository navigation
🌱 chore(crux): format validateBounds range text lazily - #16406
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read
Verified behaviour-preserving; no findings. Evidence bundle `#16406f89c672` sha256:7ceddaec61afe0c50e9f171c850dc613408a18abc7e2a43a6fe7606714cdc158 — download from the dashboard or `hivectl review evidence #16406`. |
There was a problem hiding this comment.
docs-currency (read head f89c672)
Code change is fine from this perspective: bound is only called from validateBounds (src/crux/lanes/config.go:272-311), every error string is byte-identical, and no doc references these lanes: … must be … messages (the must be between hit in src/docs/troubleshooting.md:90 is the unrelated agent-replicas message).
One in-scope fix:
changelog.d/changed-16406.md:1is a title-only fragment for a non-user-visible refactor.changelog.d/README.md("Content" / "What qualifies") requires the bullet to be the operator-facing entry — what changed, why an operator cares — and says routine refactors with no user-visible change should carry theno-changeloglabel instead of a fragment (src/scripts/check-changelog-fragment.sh:103accepts the label). The PR body itself states messages are unchanged, so- chore(crux): format validateBounds range text lazily (#16406)would land inCHANGELOG.mdas noise an operator cannot act on. Requested: deletechangelog.d/changed-16406.mdand add theno-changeloglabel (or, if a fragment is kept, reword it to describe the operator-visible effect — there is none to describe, which is the point).
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
validateBounds formatted every range and value string on each config load even though almost all checks pass. Deferring that work into a closure that runs only on violation keeps the happy path allocation-free while leaving every error message byte-identical, so existing lane config tests cover it.
Closes #16403
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88