Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ RUN ARCH="${TARGETARCH:-$(dpkg --print-architecture)}" && \
# Tolerant of failure like the copilot/codex layers: agents configured for
# backend: pi simply won't launch if this is absent, same degradation as
# any other missing backend binary.
ARG PI_VERSION=1.4.0
ARG PI_VERSION=1.5.0
RUN npm install -g --ignore-scripts --no-fund --no-audit \
"@earendil-works/pi-coding-agent@${PI_VERSION}" && npm cache clean --force || \
echo "WARN: pi CLI install failed — skipping"
Expand Down
2 changes: 1 addition & 1 deletion src/Dockerfile.contributor
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
# NODESOURCE_KEY_SHA256 is the digest of the raw ASCII-armored key as
# published at the URL below; re-verify against NodeSource's documented
# fingerprint (6F71F5252828 41EEDAF851B4 2F59B5F99B1B E0B4) before bumping.
ARG NODESOURCE_KEY_SHA256=b42e0321dabdc24e892115da705cf061167eac12a317f23d329862d0aa0a271d

Check warning on line 222 in src/Dockerfile.contributor

View workflow job for this annotation

GitHub Actions / build-contributor (linux/amd64, true, false, 60)

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NODESOURCE_KEY_SHA256") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 222 in src/Dockerfile.contributor

View workflow job for this annotation

GitHub Actions / build-contributor (linux/arm64, true, true, 75)

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NODESOURCE_KEY_SHA256") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
RUN mkdir -p /etc/apt/keyrings \
&& curl -fsSL -o /tmp/nodesource.key https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
&& echo "${NODESOURCE_KEY_SHA256} /tmp/nodesource.key" | sha256sum -c - \
Expand Down Expand Up @@ -486,7 +486,7 @@
# installer here: it is mutable and executes remote shell as root. Pi publishes
# npm-shrinkwrap.json, so install a pinned npm package with lifecycle scripts
# disabled and fail the image build if the binary is absent.
ARG PI_CODING_AGENT_VERSION=1.4.0
ARG PI_CODING_AGENT_VERSION=1.5.0
# Registry tarballs can briefly return 404 while a release propagates. npm's
# fetch retries do not cover 404s, so retry the install with a bounded delay.
RUN for attempt in 1 2 3; do \
Expand Down
2 changes: 1 addition & 1 deletion src/pkg/config/dockerfile_contributor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestContributorDockerfileInstallsPiWithoutCurlPipeShell(t *testing.T) {
t.Fatal("Dockerfile.contributor must not execute the mutable pi.dev installer with curl|sh")
}
for _, want := range []string{
"ARG PI_CODING_AGENT_VERSION=1.4.0",
"ARG PI_CODING_AGENT_VERSION=1.5.0",
"@earendil-works/pi-coding-agent@${PI_CODING_AGENT_VERSION}",
"npm install -g --ignore-scripts",
"which pi",
Expand Down
Loading