Skip to content

🌱 chore(dependabot): prefix commit messages so PR Type passes without retitling - #16338

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16336
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16336

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #16336

The PR Type check rejects Dependabot titles that start with bare build(deps): because it expects a 🌱 emoji prefix for dependency-related changes. This fix adds commit-message.prefix: "🌱 build(deps)" to all five Dependabot update entries in .github/dependabot.yml, ensuring Dependabot generates titles with the correct format and passes the PR Type validation without requiring manual retitling.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

… retitling

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
ddff5ae

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head ddff5ae34662) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/dependabot.yml
  • security_policy_edit — edits security policy, scanner config, rulesets or hooks (Edits SECURITY.md, dependabot/CodeQL config, rulesets or git hooks)
    • .github/dependabot.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#163388237ed2` sha256:ca5a08d70999e1414ee3f4efd189871114397fff229e99f12ad192fababe55e3 — download from the dashboard or `hivectl review evidence #16338`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm that adding commit-message.prefix: "🌱 build(deps)" to all five entries of .github/dependabot.yml is acceptable, since dependabot config is a trust-surface file that CODEOWNERS does not cover and the hive's automerge would otherwise land it unattended.

The change itself is correct; I am routing it only because .github/dependabot.yml is a trust-surface file.

What I verified:

  • .github/dependabot.yml on v5 HEAD has five updates entries (lines 3, 21, 31, 42, 55) and none already carries a commit-message key, so the five insertions add no duplicate YAML keys.
  • Dependabot's prefixer (dependabot-core common/lib/dependabot/pull_request_creator/pr_name_prefixer.rb, prefix_from_explicitly_provided_details) appends : when the prefix ends in [A-Za-z0-9)\]] and then a space, so "🌱 build(deps)" produces titles of the form 🌱 build(deps): bump X from A to B — the same shape as #16188, which already passes PR Type. No include: scope is set, so the scope stays (deps) rather than becoming (deps)(deps).
  • The diff touches nothing but commit-message.prefix: no allow/ignore/target-branch/registry changes, so the set of dependencies Dependabot may bump and where it opens PRs is unchanged.
  • The PR body matches the diff and the finding in #16336.

.github/CODEOWNERS does not list dependabot.yml, so no mandatory review would otherwise attach to this file. I have not approved or merged anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @ddff5ae
  • the review found: sensitive-paths question from the correctness review
  • reviewer question: @clubanderson should confirm that adding commit-message.prefix: "🌱 build(deps)" to all five entries of .github/dependabot.yml is acceptable, since dependabot config is a trust-surface file that CODEOWNERS does not cover and the hive's automerge would otherwise land it unattended.
  • the automerge lane will not merge this unattended

Head: verdict requires_human @ddff5ae, 49/49 checks green, DCO yes, soak 0s of 10m0s.

What to do: approve this head (ddff5ae) to merge as-is, or leave a changes requested review (or reply /hive decision <what to change>) and the hive will push the fix.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner-authorized decision following clubanderson request: approve ONLY the prefix-only metadata change at ddff5ae, answering #16336.

All five entries add only commit-message.prefix: "🌱 build(deps)". Removing those five blocks reproduces the current PR base file exactly; schedules, directories, ecosystems, labels, limits, ignores, registries, permissions and update scope are unchanged. The title classifier supports 🌱/build(deps), the integration title guard accepts 🌱, and all 52 latest check names at this head are success/skipped, including PR Type and attribution/DCO checks.

This is an owner-delegated agent review, not a claim that the owner personally reviewed the code. No CODEOWNERS/trust-policy weakening, future-head approval, CI bypass or merge instruction is authorized.

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: bd85dcd73eb2b6004672cda7b1486b493df349be

@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@clubanderson

Copy link
Copy Markdown
Member

/lgtm
/approve

Owner-authorized decision following clubanderson request, scoped ONLY to reviewed prefix-only head 8237ed2. The native owner-authenticated decision recorded approval and admission for this exact head, but Prow correctly rejected Hive's self-LGTM and non-OWNERS bot approval. This authenticated maintainer comment supplies the supported Prow commands; it does not spoof labels or claim the owner personally inspected code. All five prefix-only blocks preserve the rest of the current base configuration exactly. Pending CI, soak and all remaining merge gates still apply; no merge command, future-head approval or trust-policy weakening.

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 6f2a42d191abef7a889d04ba1b852e75cc2ce072

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson, hivecommons-hive[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 736b4bc into v5 Nov 3, 2026
62 of 69 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16336 branch November 3, 2026 01:46
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (style): dependabot.yml has no commit-message prefix, so every Dependabot PR fails PR Type until retitled

1 participant