Skip to content

πŸ› fix(packs): follow live gateway backend overrides when placing the reviewer - #16301

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-14678
Nov 2, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-14678

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #14678

Why #14777 did not fix it

#14777 taught ApplyPack to move a pack-owned CLI agent (the L2 reviewer) onto the gateway the operator's agents share. But the vote (hiveAgentBackends) read only each agent's config backend. On the reporter's hive the operator moved scanner/quality/guide onto LiteLLM through the dashboard switch, which is a live BackendOverride persisted in /data/hive-state.json; their config backend is still the pack's copilot. The dashboard cards show the effective (override) backend, so every agent looked like LiteLLM, while the pack saw only copilot, found no gateway, and left the reviewer on copilot β€” on every restart/upgrade.

Fix

hiveAgentBackends now uses each agent's live BackendOverride (via AgentMgr.GetStatus(name)) when it differs from the config backend, and counts it as an operator pick β€” the same effective backend the dashboard and launcher use.

Verified by reading the code

  • Boot order (cmd/hive/boot_sequence.go): bootState β†’ restoreAgentRuntimeState replays SetBackendOverride from hive-state.json, and runs before bootPolicies β†’ ApplyPack, so the override is visible to the vote at boot-time apply.
  • crux.Runtime.GetStatus(name) (*crux.Process, error) returns a snapshot with BackendOverride; the manager resolves override-over-config the same way in effectiveBackend/CountAgentsWithModel.
  • The reviewer itself is excluded from the vote (except), and an operator override that is a CLI still makes hiveGatewayBackend return "" (no move), preserving existing behavior.
  • New TestApplyPackFollowsGatewayBackendOverrides covers both a reviewer created by the level and an existing pack-owned copilot reviewer being repaired. Local test runs are not permitted in this environment; CI is the verdict.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@MikeSpreitzer

hivecommons-hive Bot and others added 2 commits November 2, 2026 16:10
…reviewer

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: MikeSpreitzer <14296719+MikeSpreitzer@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 2, 2026
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

hivecommons-hive Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16301a605dcd` sha256:8c691b68d0ddecf94f77e53256f8b9d91369eccf6e753d322e3a5a1c6764da97 β€” download from the dashboard or `hivectl review evidence #16301`.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 2, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 7443ce4 into v5 Nov 2, 2026
81 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-14678 branch November 2, 2026 22:55
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› bug: reviewer agent has mysteriously inconsistent configuration for inference

0 participants