Repository navigation
π fix(packs): follow live gateway backend overrides when placing the reviewer - #16301
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16301a605dcd` sha256:8c691b68d0ddecf94f77e53256f8b9d91369eccf6e753d322e3a5a1c6764da97 β download from the dashboard or `hivectl review evidence #16301`. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #14678
Why #14777 did not fix it
#14777 taught
ApplyPackto move a pack-owned CLI agent (the L2reviewer) onto the gateway the operator's agents share. But the vote (hiveAgentBackends) read only each agent's configbackend. On the reporter's hive the operator moved scanner/quality/guide onto LiteLLM through the dashboard switch, which is a liveBackendOverridepersisted in/data/hive-state.json; their config backend is still the pack'scopilot. The dashboard cards show the effective (override) backend, so every agent looked like LiteLLM, while the pack saw only copilot, found no gateway, and left the reviewer on copilot β on every restart/upgrade.Fix
hiveAgentBackendsnow uses each agent's liveBackendOverride(viaAgentMgr.GetStatus(name)) when it differs from the config backend, and counts it as an operator pick β the same effective backend the dashboard and launcher use.Verified by reading the code
cmd/hive/boot_sequence.go):bootStateβrestoreAgentRuntimeStatereplaysSetBackendOverridefrom hive-state.json, and runs beforebootPoliciesβApplyPack, so the override is visible to the vote at boot-time apply.crux.Runtime.GetStatus(name) (*crux.Process, error)returns a snapshot withBackendOverride; the manager resolves override-over-config the same way ineffectiveBackend/CountAgentsWithModel.except), and an operator override that is a CLI still makeshiveGatewayBackendreturn "" (no move), preserving existing behavior.TestApplyPackFollowsGatewayBackendOverridescovers both a reviewer created by the level and an existing pack-owned copilot reviewer being repaired. Local test runs are not permitted in this environment; CI is the verdict.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@MikeSpreitzer