Repository navigation
🐛 fix(ci): run pinned PR verifier on native ARM64 - #16290
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read the diff against v5 and independently checked the premise. Looks correct to me.
Verified:
ghcr.io/hivecommons/pr-verifier@sha256:8c2b6381…is a singleapplication/vnd.docker.distribution.manifest.v2+json(nomanifestslist) whose config blob saysos=linux arch=arm64; tagv1returns the samedocker-content-digest. So theexec format erroron the amd64 pool is real and QEMU-lessdocker runcannot fix it — native ARM64 is the only option without republishing..github/workflows/pr-verifier.yml:20— the selector reuses the existingvars.HIVE_ARM64_RUNNERJSON convention (docker.yml:284,src/docs/ci-runner-labels.md:133), and the fork branch is a literalubuntu-24.04-arm, so apull_request_targetfrom a fork can never land on a repository-variable runner.permissions:is unchanged.pr-verifier.yml:46-56— preflight runs under the defaultbash -e, so a faileddocker pullor a non-linux/arm64inspect result exits non-zero andcontinue-on-errorroutes it to the "unavailable or incompatible" warning rather than running the verifier. The seven mocked cases insrc/deploy/test_pr_verifier_advisory.sh:152-160cover exactly those branches (arch gate before pull, platform gate after), andtest-native-queue-workflows.py:71now finds the verifier step by name instead of assuming it is last — needed becauseReport verifier failureis now the final step.
One low-severity docs note: src/docs/ci-runner-labels.md:133-134 still describes HIVE_ARM64_RUNNER as "only an explicit hosted-runner fallback" for QEMU builds, while this PR's comment, test (test_pr_verifier_advisory.sh:89) and hivecommons-migration.md call it a "self-hosted override". Since the fleet is amd64 (LKE), same-repo verifier runs will in practice be GitHub-hosted too — which also means the "Required on v5 … survive a GitHub-hosted outage" rationale the old comment carried no longer holds for this check. That's a deliberate trade-off given the image, but worth one sentence in ci-runner-labels.md so the two docs agree on what the variable is for.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Conclusion: The diagnosis is right and the code does what it says; the one thing I cannot settle is a runner-availability trade-off on a workflow file, so I am routing that to an approver rather than judging it. What I verified independently (before reading the body):
The open point (medium, not a defect in the diff):
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
e413f7e
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
|
Needs a decision, not a merge:
Head: verdict requires_human @e413f7e, 76/76 checks green, DCO yes, soak 10m0s elapsed. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Decision (owner): approved — GitHub-hosted |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Verified cause and publisher ownership
The optional PR Type provider on #16188 failed before validating metadata: run 41499101162/job 125461658689 logged
linux/arm64image versuslinux/amd64/v4host, followed byexec /verifypr: exec format error. The required wrapper was intentionally advisory; its green result was not proof of child-check success. This is not established as the dominant backlog cause.Public OCI inspection verified the existing pinned
ghcr.io/hivecommons/pr-verifier@sha256:8c2b63817c4bfa7de510ab699b154637f27a42f87826c98083903daf2a539943is a SINGLE linux/arm64 manifest, not an index. Tag v1 resolves to that exact digest. Labels identify upstream kubebuilder-release-tools v0.4.3 and source kubestellar/infra; hivecommons/infra mirrors the same consumer pin. The original upstream GCR v0.4.3 image is retired/404. No unpublished image, guessed digest, or mutable-tag repoint is proposed.Normal source fix
Validation and rollout boundary
One bounded independent read-only review found no significant issues. No local test/build/linter/repository guard was run, per AGENTS; CI is the executable verdict. The production pull_request_target verifier uses the BASE workflow, so this PR cannot itself prove the proposed workflow executed live: contract CI validates routing/preflight, and native provider behavior must be observed after legitimate source delivery on a natural event. Existing stale child checks are not overwritten or forced successful.
No manual base refresh/rerun/title edit/label/reconcile/lease release, individual backlog merge, App permission grant, alternate credential, deployment/restart, or capacity/budget change accompanies this source PR. #16277 recovery/operator handoff and #16288 reservation safety remain separate.