Repository navigation
🐛 fix(ci): name the TRUSTED_SCRIPTS_TREE pin and the re-pin remedy in the governance assertion - #16156
Conversation
…he governance assertion Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Looks correct to me; refusal behaviour is unchanged, only the message is split. What I verified against the tree at
Note for whoever runs this locally: test 5 ( |
…nd the re-pin remedy Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read the diff against v5 at .github/scripts/integration-governance.cjs:95-104, the fixture test, and the workflow wiring. This looks correct to me.
What I verified:
- Gate semantics unchanged. The
HEAD:src/scriptscheck is only moved out of the combined condition into its ownifdirectly after it (integration-governance.cjs:101-104); every path that threw before still throws, andverify()never reachesverifyContents/member checks without both the source-SHA and HEAD pins matching. The specific message is only reachable once thesourceSHAchecks have passed, so a forged source still gets the opaqueclosure unavailableerror (the test atintegration-governance.test.cjs:143now asserts exactly that). - The drift assertion matches what the fixture produces.
check()runs the helper viaexecFileSyncwith stderr piped, so the innerconsole.error(error)lands in the thrownCommand failedmessage and/is not the pinned TRUSTED_SCRIPTS_TREE .*re-pin the literal/matches on one line. - New pin test is live on PR runs.
node --test .github/scripts/integration-*.test.cjsruns inbuild-and-test(integration-technical-v2-ci.yml:336) andci-build-and-test(integration-candidate.yml:470), so the AGENTS.md claim that an un-re-pinnedsrc/scriptsedit failsbuild-and-testis accurate. Onv5todaygit rev-parse HEAD:src/scriptsequals the pinned literal, so the new test is green at this head.
No findings.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The
TRUSTED_SCRIPTS_TREEpin requirement was undocumented, and theverify()assertion failed with an opaque 'closure unavailable' error naming neither the pin nor the remedy, so everysrc/scriptsPR re-diagnosed it from a stack trace (see #16151).verify()now throws a specific error naming both tree hashes and the re-pin remedy whenHEAD:src/scriptsdiffers from the pin.Pin semantics and the pinned literal are unchanged; the source-SHA checks keep the existing opaque error.
Closes #16154
— hive: agent=scanner backend=copilot model=claude-sonnet-5.5