Repository navigation
π docs(hub): reframe activityForgetAfter as a backstop for silent hives - #16039
Conversation
Since hivecommons#16007, removing a hive from the registry purges its activity block immediately via activityStore.forget (removeRegistryEntry and the admin registry DELETE handler). The 24h sweep is now only a backstop for hives that stopped reporting while still registered, so drop the "or left the registry" wording that still framed departure as a time-based eviction. Comment-only change; no behavior change. Closes hivecommons#16009 Hive-Run: hivecommons#16009 Hive-Plan: reviewer backlog docs-currency (from review of hivecommons#16007) Hive-Spec: hub-activity#activityForgetAfter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRH6kif1Xa5LCs6yXPcSgw Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR only changes a comment in β hive: backend=claude |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should add the no-changelog label to #16039 (comment-only change, author's token could not apply it) so changelog-fragment-guard and native-queue-policy go green.
Comment change is accurate; the PR is blocked only on a label a maintainer has to add.
Verified against the tree at 0480034:
src/pkg/hub/server.go:4284(removeRegistryEntry) andsrc/pkg/hub/server.go:4350(admin registry DELETE) both calls.activity.forget(id), so the new wording insrc/pkg/hub/activity.go:35-38β immediate purge on registry removal, 24h sweep only as a backstop for still-registered silent hives β matches what the code does since #16007.activityStore.forgetexists atactivity.go:121; the sweep isforgetOldLockedatactivity.go:130. No behaviour touched.
Why CI is red: changelog-fragment-guard fails with src/ code changed without a changelog.d fragment or a no-changelog label (#5675), and native-queue-policy fails downstream of it (Unhandled error: changelog-fragment-guard: failure). The PR body says the author tried to apply no-changelog but the fork token could not; the PR currently carries only dco-signoff: yes and size/XS. Adding the label re-runs the guard (it listens for labeled, see .github/workflows/changelog-fragment-guard.yml:50).
Looks correct to me otherwise; nothing to change in the diff. I have not labelled or approved anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read the tree at v5 The only thing blocking this is procedural: hive/awaiting-ci: added π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16039dedcf96` sha256:7e8152e3ab561659ac1bf7975e767cb83c8e586fe927fbf704dcf56e546f94c5 β download from the dashboard or `hivectl review evidence #16039`. |
There was a problem hiding this comment.
Read against the tree at the PR head, not just the diff: activityStore.forget exists at src/pkg/hub/activity.go:118-127 and is called from both registry-removal paths at src/pkg/hub/server.go:4284 and :4350, so the rewritten comment on activityForgetAfter describes what the code actually does now β the 24h sweep (forgetOldLocked, activity.go:130) is only the backstop for still-registered hives that stopped reporting. Comment-only, no behaviour change, no-changelog is the right call. Looks correct to me.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for β₯10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry. |
Summary
Since #16007 merged, removing a hive from the registry purges its activity block immediately via
activityStore.forget(bothremoveRegistryEntryatsrc/pkg/hub/server.go:4284and the admin registry DELETE handler atsrc/pkg/hub/server.go:4350). TheactivityForgetAfterconstant doc insrc/pkg/hub/activity.gostill said the 24h sweep exists so hives that "stopped reporting (or left the registry)" cannot pin memory forever, which frames registry departure as a time-based eviction.This PR rewrites the comment: the 24h sweep is now described as a backstop for hives that stopped reporting while still registered, and it points to the immediate purge on registry removal.
src/pkg/hub/activity.go; no behavior change.changelog.d/fragment. This needs theno-changeloglabel, which I'll try to apply; a maintainer may need to add it if my token can't.Closes #16009
Test plan
gofmt -l src/pkg/hub/activity.gois cleanπ€ Generated with Claude Code
https://claude.ai/code/session_01HRH6kif1Xa5LCs6yXPcSgw
β hive: backend=claude