Skip to content

πŸ“– docs(hub): reframe activityForgetAfter as a backstop for silent hives - #16039

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:docs/16009-activity-forget-after-comment
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:docs/16009-activity-forget-after-comment

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Summary

Since #16007 merged, removing a hive from the registry purges its activity block immediately via activityStore.forget (both removeRegistryEntry at src/pkg/hub/server.go:4284 and the admin registry DELETE handler at src/pkg/hub/server.go:4350). The activityForgetAfter constant doc in src/pkg/hub/activity.go still said the 24h sweep exists so hives that "stopped reporting (or left the registry)" cannot pin memory forever, which frames registry departure as a time-based eviction.

This PR rewrites the comment: the 24h sweep is now described as a backstop for hives that stopped reporting while still registered, and it points to the immediate purge on registry removal.

  • Comment-only change in src/pkg/hub/activity.go; no behavior change.
  • Not user-visible, so no changelog.d/ fragment. This needs the no-changelog label, which I'll try to apply; a maintainer may need to add it if my token can't.

Closes #16009

Test plan

  • gofmt -l src/pkg/hub/activity.go is clean
  • CI green (per AGENTS.md, CI is the only test verdict)

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01HRH6kif1Xa5LCs6yXPcSgw

β€” hive: backend=claude

Since hivecommons#16007, removing a hive from the registry purges its activity block
immediately via activityStore.forget (removeRegistryEntry and the admin
registry DELETE handler). The 24h sweep is now only a backstop for hives
that stopped reporting while still registered, so drop the "or left the
registry" wording that still framed departure as a time-based eviction.

Comment-only change; no behavior change.

Closes hivecommons#16009

Hive-Run: hivecommons#16009
Hive-Plan: reviewer backlog docs-currency (from review of hivecommons#16007)
Hive-Spec: hub-activity#activityForgetAfter
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kif1Xa5LCs6yXPcSgw
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2026
@Karibhou

Copy link
Copy Markdown
Contributor Author

This PR only changes a comment in src/pkg/hub/activity.go and has no user-visible change, so it needs the no-changelog label instead of a changelog.d/ fragment. My token can't apply labels (AddLabelsToLabelable permission denied). Could a maintainer add it so changelog-fragment-guard passes?

β€” hive: backend=claude

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • native-queue-policy

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay could not take this as a fix-pr task (Hub is not the active polling slot); the hive will retry it from your relay fix queue.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16049 ✨ feat(hub): carry bounded activity events through the heartbeat and hub ring same files src/pkg/hub/activity.go

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should add the no-changelog label to #16039 (comment-only change, author's token could not apply it) so changelog-fragment-guard and native-queue-policy go green.

Comment change is accurate; the PR is blocked only on a label a maintainer has to add.

Verified against the tree at 0480034:

  • src/pkg/hub/server.go:4284 (removeRegistryEntry) and src/pkg/hub/server.go:4350 (admin registry DELETE) both call s.activity.forget(id), so the new wording in src/pkg/hub/activity.go:35-38 β€” immediate purge on registry removal, 24h sweep only as a backstop for still-registered silent hives β€” matches what the code does since #16007.
  • activityStore.forget exists at activity.go:121; the sweep is forgetOldLocked at activity.go:130. No behaviour touched.

Why CI is red: changelog-fragment-guard fails with src/ code changed without a changelog.d fragment or a no-changelog label (#5675), and native-queue-policy fails downstream of it (Unhandled error: changelog-fragment-guard: failure). The PR body says the author tried to apply no-changelog but the fork token could not; the PR currently carries only dco-signoff: yes and size/XS. Adding the label re-runs the guard (it listens for labeled, see .github/workflows/changelog-fragment-guard.yml:50).

Looks correct to me otherwise; nothing to change in the diff. I have not labelled or approved anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the tree at v5 cf008a5c (post-#16007): both registry-removal paths call s.activity.forget(id) β€” src/pkg/hub/server.go:4284 (removeRegistryEntry) and src/pkg/hub/server.go:4350 (handleRegistryDelete) β€” and activityStore.forget at src/pkg/hub/activity.go:120 is the immediate purge. The rewritten comment on activityForgetAfter (activity.go:35-38) now describes what the code does: the 24h sweep (forgetOldLocked, activity.go:131) is the only path for still-registered silent hives, and registry departure is no longer a time-based eviction. Looks correct to me; no behaviour change.

The only thing blocking this is procedural: changelog-fragment-guard fails because src/ changed with neither a changelog.d/ fragment nor the no-changelog label (src/scripts/check-changelog-fragment.sh:101-110). A comment-only change qualifies for no-changelog; the author's token cannot apply labels. @hanthor β€” applying no-changelog is the one action needed here.

hive/awaiting-ci: added no-changelog (comment-only change in src/pkg/hub/activity.go, nothing user-visible). changelog-fragment-guard and the dependent native-queue-policy re-evaluate on the next run; the sweep merges when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16039dedcf96` sha256:7e8152e3ab561659ac1bf7975e767cb83c8e586fe927fbf704dcf56e546f94c5 β€” download from the dashboard or `hivectl review evidence #16039`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against the tree at the PR head, not just the diff: activityStore.forget exists at src/pkg/hub/activity.go:118-127 and is called from both registry-removal paths at src/pkg/hub/server.go:4284 and :4350, so the rewritten comment on activityForgetAfter describes what the code actually does now β€” the 24h sweep (forgetOldLocked, activity.go:130) is only the backstop for still-registered hives that stopped reporting. Comment-only, no behaviour change, no-changelog is the right call. Looks correct to me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit bb61e80 into hivecommons:v5 Oct 31, 2026
63 of 64 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry.

@Karibhou
Karibhou deleted the docs/16009-activity-forget-after-comment branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (docs-currency): activityForgetAfter comment still frames registry departure as a time-based eviction

1 participant