Skip to content

🌱 chore: cache negative RFC classification of PRs by head SHA - #15974

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15960
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15960

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Busy unrelated PRs had ListFiles called on every poll in which they were updated, because the detector forgets non-RFC items and nothing remembered the negative classification.

This caches "not an RFC" per PR keyed by head SHA, so a changed head (possibly changed files) is re-classified. The cache is in memory and bounded (cleared past 512 entries). Tests cover a repeat poll at the same SHA (no second ListFiles), a new SHA (re-classified), and the cap.

Closes #15960

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15973 ✨ feat: render RFC notices as summary-card embeds when rfc_format: card same files src/cmd/hive/rfcnotify_wire.go
src/cmd/hive/rfcnotify_wire_test.go

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit fd50502 into v5 Oct 31, 2026
80 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15960 branch October 31, 2026 05:55
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#159741494ba8` sha256:13b8466d329688d6db5febb2a80a927d3948a46d10f89bd602833cfc88824a37 — download from the dashboard or `hivectl review evidence #15974`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (correctness): Non-RFC PR classification is re-derived every poll

0 participants