Repository navigation
✨ feat: establish job-bound Integration-aware candidate CI - #15921
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
1aab9f5
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
…receipts Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
13d2315
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Exact producer source head |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
docs-currency review @ 6fa1775 — verdict: approve (advisory).
Verified: src/docs/integration-orchestration.md matches the code it describes — generate-integration-ci.py --check and node --test .github/scripts/integration-materialize.test.cjs are wired into v2-ci.yml/v2-tests.yml, the three integration-technical-*.yml callees regenerate byte-identical from head, integration-candidate.yml:66-67,97,132-144 implements the documented tag-ref/GraphQL/three-callee flow, and integration-producer-policy.json is disabled with empty actorIDs/scopes as stated. No branches: filters in the new workflows, so .github/release-lines.yml needs no entry.
Low (in-scope): generated callees emit 11 run: scripts as single escaped lines.
.github/scripts/generate-integration-ci.py:62-66 chooses | style for multi-line strings, but yaml.dump (line 156) defaults to allow_unicode=False, so any script containing non-ASCII (the ─ box-drawing in the coverage-floor comments) falls back to a double-quoted one-liner — e.g. integration-technical-v2-tests.yml:1001 is the entire ~200-line coverage gate as one "THRESHOLD=90\nFAILED=..." string (2 such in integration-technical-v2-ci.yml, 9 in -v2-tests.yml). These are the security-sensitive read-only candidate workflows reviewers are asked to audit; an unreadable diff defeats that. Fix, then regenerate (the --check gate will require it):
return HEADER + yaml.dump(
document, Dumper=WorkflowDumper, sort_keys=False, width=10000,
allow_unicode=True,
)
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
ACTUAL SOURCE MERGE: #15921 merged 2026-10-31T04:00:33Z, squash 1b66a34, tested immutable head 6fa1775. All required checks SUCCESS; all 20 latest workflow/event suites COMPLETED/SUCCESS or explicit scope SKIP, including complete Docker/ARM 41163772801, v2 CI 41163772746, Tests 41163772683, security 41163772755 and native policy 41165630919. Actual merge commit DCO sign-off verified via fetched Git object. Historical draft-native rejection/canceled ready event have a successful same-head policy replacement; no manual rerun or weakened gate. Producer policy remains disabled. No runtime/deployment/config/permissions/rules activation or protected-production qualification. Whole orchestration controller remains in progress separately. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Style / maintainability review (read head 6fa1775, Go sources + generator + workflows). No blockers; three small in-scope items the author may want to fold in. 1. and add 2. Error text renders 3. Minor: Review findings from Security perspective (head 6fa1775): no blocking findings. Trust-boundary design checks out — enrolled-actor gate with policy shipped disabled ( One low advisory, not blocking: Receipt artifact persists a live OIDC bearer JWT for 30 days — |
Trusted immutable-candidate producer source
Built on landed native #15853, preserving merge_group semantics and default ordinary PR/push behavior. Completes deterministic real-Git ordered-prefix materialization, controlled create-only initial-dispatch claim, distinct materializer/candidate OIDC roles, three generated isolated read-only technical CI graphs, immutable artifact receipts, bounded actual run/job/check/artifact consumers, historic signer archival, and real-Git/Node/Go security and contract regressions. Initial claim is cooperating designated execution, not failover fencing or exactly-once Actions delivery; bootstrap overhead and duplicate ambiguity remain explicit.
Exact source CI receipt
Tested immutable head 6fa1775. All required checks pass. All 20 latest workflow/event suites are terminal SUCCESS or an explicit scope SKIP, including complete Docker/ARM images, Go/security/lint/coverage, v2 CI/Tests, and native policy 41165630919. Actual earlier native failure 41163770446 rejected this PR while draft; ready-for-review reevaluation passed. Canceled 41165628687 has that successful same-head replacement. No blind reruns or gate changes.
Not activation or whole-controller completion
Producer policy remains disabled with no actors/scopes. No live controlled candidate invocation, production policy-equivalence/protected promotion qualification, controller runtime, image deployment, configuration, permissions, protection, or concurrency changes. The separate execution/admission/promotion controller is still being implemented; this source PR does not claim it delivered or ready. No local suites/builds/guards run per AGENTS; CI is the sole verdict.