Repository navigation
š agent: recognise bob 2.x "Processing⦠(Enter to steer)" as an in-progress turn - #15868
Conversation
ā¦ogress turn Bob-Shell 2.x keeps the ⯠input box painted while a response streams and signals busy only with "ā Processing⦠(Enter to steer, Tab to queue)", which matched none of the working markers. paneShowsTurnEnded therefore fired ~30s after delivery: the kick outcome settled while bob was still working and the turn-end kick log archive was a mid-run snapshot. Add the steer hint to agentWorkingMarkers so both the delivery busy gate and turn-end classification see a streaming bob. Closes #15864 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
hive/awaiting-ci: pushed a fixup moving the blocking-prompt table/helpers out of src/crux/agent/manager_pane_signals.go (931 > 920-line ratchet baseline) into src/crux/agent/manager_pane_blocking_prompts.go; CI pending ā sweep will merge when green. š Hive Agent: ā hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
@clubanderson this PR is back in your court (
Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
@clubanderson ā either re-sign that commit as yourself: or drop it ( š Hive Agent: ā hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
ā¦atisfy the crux file-size ratchet Signed-off-by: Andrew Anderson <andy@clubanderson.com>
cf8ba20 to
d28e04f
Compare
|
Test gap (quality review @d28e04f): Suggested, both small:
Fork/author branch ā comment only, not pushing. š Hive Agent: ā hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read it against the callers ā looks correct to me, and the body matches the diff.
- The behavioural change is a single marker:
bobBusyMarker = "Enter to steer"appended toagentWorkingMarkers(src/crux/agent/manager_pane_signals.go:122-130). It is consumed by the same whole-visible-panestrings.Containsloop as"esc interrupt"/"ā Working"(manager_pane_signals.go:158-162), so every caller ā delivery gatemanager_kick.go:290,paneShowsTurnEndedatkick_outcome.go:148,busy_visibility.go:520,session_recycle.go:205,pr_session_resume.go:134ā picks it up consistently; nothing bob-specific was bolted onto one path. - The rest of the diff (
manager_pane_blocking_prompts.goāmanager_pane_signals.go) is a pure move:git diff --color-movedshows only the marker, its comment and the package/import header as non-moved lines. TestPaneShowsAgentWorking_BobProcessing(agent_working_test.go) asserts both directions on live captures and the idle capture has noEnter to steertext, so the marker does not pin an idle pane as working.
One thing I did not verify and leave as an open question, not a finding: the marker shares the existing markers' exposure to a steer hint that survives in the visible region after the turn ends (e.g. a scrolled-back Processing⦠line). The idle capture in #15864 shows bob erases it, so this is the same risk class the Claude markers already carry.
ā hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8b98841. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #15864
Why
Bob-Shell 2.x keeps the
āÆinput box painted while a response streams and signals busy only withā Processing⦠(Enter to steer, Tab to queue). None ofagentWorkingMarkers,cliBusyEscapeFooterRe,cliWorkingMarker,cliActiveCounterMarker,Workingā¦/Runningā¦match it, sopaneShowsTurnEndedfired as soon as the pane changed afterkickOutcomeGrace.Observed live on hosted-available-vllmd-260731-fikn (hive 5.186.4-973, Bob-Shell 2.0.5):
kick turn ended ⦠seconds_since_kick=29and a 112 KBturn-endkick log archive taken at 22.6k tokens, while the turn actually finished ~10 minutes later at 31.9k tokens. The kick outcome settled early (governor observer, shared-pool eviction) and š past kicks shows a mid-run snapshot ā the artifact #15270 made durable for #15264.What
bobBusyMarker = "Enter to steer"added toagentWorkingMarkers, sopaneShowsAgentWorking(the š Kick interrupts a busy agent: ⯠input box is present while working, so the readiness gate passesĀ #7085 delivery busy gate) andpaneShowsTurnEndedboth recognise a streaming bob 2.x pane.TestPaneShowsAgentWorking_BobProcessing: live busy and idle bob captures; busy must read working / not turn-ended, idle the opposite. Fails without the marker.