Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-tracker-let-hive-decide-feedback.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Stage tracker: *Let hive decide* now shows at once that it is working — the button goes busy and reads "Asking the hive…" with the acting glyph and the row wears the acting wash until the preview opens, with no double-fire; an issue covered by a PR drawn under another issue shows a passive "decision pending on #N" chip that jumps to the PR's row instead of repeating the PR's button; and a 👤 on a chevron now says why a person is wanted ("PR in progress · #15759 needs a decision", "Ready for human merge · workflow files") ([#15773](https://github.com/hivecommons/hive/issues/15773)).
8 changes: 6 additions & 2 deletions src/docs/dashboard-sections/activity-monitor.md
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,10 @@ Plain words throughout — working / waiting on X / set back by Y / merged — n

A row whose next move is yours does not hide its answer behind three dots. Beside the chips on the right of the header (and on a nested PR sub-row's own header), the row renders its **lead action** as a real `<button class="ham-lead-act">` — `[Accept triage]` on *Triage needed* (000-new hold or 015), `[Merge now]` (or the server's lead answer) on *Ready for human merge*, `[Let hive decide]` on *Needs human decision* and a duplicate's *Needs a pick*, `[Adopt…]` on a returned contributor PR whose adoption is due, `[Close now]` on an advisory issue. `stageTrackerLeadAction(item, ctx)` picks it from the same `stageTrackerRowActions(...)` list the ⋯ menu shows: the entry flagged `lead`, else the first *Decide…* option, else Adopt / Adopt now / *Let hive decide — all N PRs*; one button only, everything else stays in ⋯. It carries the menu entry's id, its hint as the hover and its enable/disable reason: a viewer without write access sees it greyed with *Sign in with write access to this repo*, a non-merger sees a merge action greyed with the role reason, never hidden. Clicking runs `runRowAction(action, row)` — the menu's own path, so the busy chevron, the acting caption, the toast and the history badge are the same. A row the server marks as the maintainer's move (`actor: maintainer` or `new.next_mover: maintainer`) that yields no lead is a bug: a development host logs a console warning, and `TestStageTrackerMaintainerRowsHaveLeadAction` runs the real fixtures through the picker.

**Let hive decide shows it is working** ([#15773](https://github.com/hivecommons/hive/issues/15773)). *Let hive decide* first asks the server for a plan (`POST …/decide-delegated/plan`, a few seconds on a PR). From the click until the preview opens, the button is `disabled` and `aria-busy`, reads **Asking the hive…** beside the acting glyph, and the row (and the PR it decides) wears the acting wash with the same caption; a second click meanwhile does nothing, and the button comes back if the fetch fails. Once you pick *Let hive do that*, the row reads *Hive deciding…* as before.

**Covered issues point at the PR's row** ([#15773](https://github.com/hivecommons/hive/issues/15773)). An issue whose covering PR is drawn under another issue (`drawn_under`) and waits on a person's decision does not repeat the PR's button: only the PR's row carries *Let hive decide*. The covered issue shows a passive **decision pending on #N** chip that scrolls to the PR's row, and its caption reads *Covered by PR #N — waiting for a decision on the PR*.

#### Row actions (right-click, ⋯, Shift+F10)

Right-clicking a row — or a nested PR sub-row — opens an in-app context menu of the actions that fit that item's current state; the ⋯ button in the row's left gutter (every nested PR sub-row has its own gutter with its own checkbox and ⋯) opens the same menu for pointer-free use, and so do **Shift+F10** and the context-menu key while the row or anything in it has focus (every row is a tab stop).
Expand Down Expand Up @@ -420,7 +424,7 @@ Nothing the dialog would have said is lost: the result toast carries the same

The small icon after the lit pill's words names whose move the row is, and it comes from the payload — `stage_actor: {kind, login, since, why}`, derived server-side for every item and every nested PR — never from a guess on a login string. `kind` is one of **hive** (⬡ honeycomb: a hive lane or agent acts next; `login` is the agent when one is on it right now), **clanker** (robot head: a registered contributor agent must push), **human** (the person glyph the *Needs human decision* pill uses: the author, approver or a maintainer must act; `login` names them when known), **bot** (cog: a non-hive automation account such as `github-actions[bot]` or renovate authored the PR; the hive does not fix bot PRs, it waits for the bot's next run), or **none** (no icon: nobody is working on it — the pill's tooltip then reads *no one is working on this right now — <why>*).

`why` is a short sentence the tooltip appends after *Next move: <kind> @<login>*. A `070` Fixing pill is only shown as **Fixing** when someone can fix it; a bot-authored or unowned red PR reads its state in plain words instead — **Conflicting · bot PR**, **Red · nobody on it** — with the matching icon, so a row such as hivecommons/docs#500 (a nightly resync PR that conflicts with its base) no longer looks like active hive work.
`why` is a short sentence the tooltip appends after *Next move: <kind> @<login>*. When the next move is a person's, the lit chevron also says why after the 👤 in at most 40 characters — *PR in progress 👤 · #15759 needs a decision*, *Ready for human merge 👤 · workflow files*, *Fixing 👤 · @sam must push a fix* — with the full reason (the decision's question, the human-merge reason, or `why`) as its hover; a chevron whose word already is the ask (*Needs human decision*, *Triage needed*) does not repeat it ([#15773](https://github.com/hivecommons/hive/issues/15773)). A `070` Fixing pill is only shown as **Fixing** when someone can fix it; a bot-authored or unowned red PR reads its state in plain words instead — **Conflicting · bot PR**, **Red · nobody on it** — with the matching icon, so a row such as hivecommons/docs#500 (a nightly resync PR that conflicts with its base) no longer looks like active hive work.

Issues riding one covering PR take that PR's actor; nested PR sub-rows carry their own.

Expand All @@ -430,7 +434,7 @@ The icon says what kind of actor holds the row; the `claimant` says *who*. On a

#### One row per PR

A pull request that closes several open issues (`Closes #A` and `Closes #B`) is drawn once, under the issue the server names in each linked entry's `drawn_under` (its `nested_under`, the lowest-numbered open issue it closes). The other issues keep their own strip and show a compact **↳ #N · under #M** chip beside the title (tooltip: *PR #N covers this issue too; its row is drawn under #M*) instead of a second identical sub-row, so hivecommons/hive#14921 appears once under #14910 and #14911 points at it.
A pull request that closes several open issues (`Closes #A` and `Closes #B`) is drawn once, under the issue the server names in each linked entry's `drawn_under` (its `nested_under`, the lowest-numbered open issue it closes). The other issues keep their own strip and show a compact **↳ #N · under #M** chip beside the title (tooltip: *PR #N covers this issue too; its row is drawn under #M*) instead of a second identical sub-row, so hivecommons/hive#14921 appears once under #14910 and #14911 points at it. When that parked PR waits on a person's decision, the covered issue also wears the passive **decision pending on #N** chip described under *Covered issues point at the PR's row* above — never the PR's own *Let hive decide* button.

Payloads without `drawn_under` draw as before.

Expand Down
Loading
Loading