Skip to content

🌱 refactor: split src/docs/labels-and-control-signals.md into per-section pages - #15712

Merged
hivecommons-hive[bot] merged 16 commits into
v5from
scanner/fix-15675
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 16 commits into
v5from
scanner/fix-15675

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

src/docs/labels-and-control-signals.md (2.6k lines) is a merge hotspot: 6 PRs touched it in 7 days, 6 concurrent pairs.

Layout

src/docs/labels-and-control-signals.md stays as the index (path unchanged) and links the pages under src/docs/labels-and-control-signals/:

  • reference.md β€” first use, label axes, categories, reference table
  • stage-labels.md β€” stage labels and the pipeline state machine
  • glossary-and-operations.md β€” decision glossary, blockers, matching rules, config, question auto-close, examples, follow-ups

3 pages (each 150+ lines), within the issue's 4-file cap. Section bodies are moved verbatim; only relative links were prefixed with ../ and in-page anchors that now cross files were pointed at the new file.

Inbound links

  • Anchored links from other docs were retargeted to the new page.
  • The index keeps <a id> anchors for every ## section and the regressed marker anchor, so links that still use the old path (e.g. dashboard-sections.md, which is being edited elsewhere and was not touched) keep resolving.
  • stageengine diagram test and Go comments now point at stage-labels.md, where the mermaid diagram lives; file:line citations in the ADR/plan were repointed.

Docs-only move, no behaviour change.

Closes #15675

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…tion pages

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15717 πŸ› fix: never-policy 072 row stops promising adoption it can't back CONFLICT src/docs/labels-and-control-signals.md
#15308 ✨ feature: enqueue eligible PRs into GitHub native merge queues CONFLICT src/docs/labels-and-control-signals.md
#15516 πŸ“– docs: split the operator reference same files src/docs/operator-reference.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the stage/stalled In its current stage longer than expected label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15405:2/2:0/0:operator-reference.md

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet stage/stalled In its current stage longer than expected labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the move is lossless; looks correct to me.

  • Diffed the merge-base src/docs/labels-and-control-signals.md (2630 lines) against the concatenation of the three new pages, normalising only the ../ link prefix and cross-file anchor targets: the only differences are the three new page # … titles and their "Part of …" lines. No section body changed.
  • The three anchored links still pointing at the old path (src/docs/dashboard-sections/activity-monitor.md:18, :100, :637 β†’ #stage-labels-…, #the-regressed-marker-…, #decision-glossary) all land on <a id> anchors the index now carries, so leaving that file alone was safe.
  • src/pkg/stageengine/transition_table_test.go:15 diagramDoc now points at stage-labels.md, which is where the single ```mermaid block moved; the comments in transition.go / transition_table.go were repointed to match.

CI: everything green except the arm64 build still running at eec3106.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 7710c23 into v5 Oct 30, 2026
75 of 76 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15675 branch October 30, 2026 11:51
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#157122b2d0c8` sha256:c21fa4855b36a3f6f7c235da3e7faa385543844743444eba392fca8ca4fc835d β€” download from the dashboard or `hivectl review evidence #15712`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 30, 2026
hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
…ll wordings

Review follow-up for #15738.

- stageTrackerAdoptionText: the two never-only cases repeated the
  AutoDue / AutoAdoptAt branches verbatim save for a trailing clause.
  stageTrackerAdoptionNeverHedge now computes that clause once and the
  two existing branches append it, so the countdown text has a single
  source of truth. Rendered strings are unchanged.
- docs/dashboard-sections/activity-monitor.md: the 072 pill vocabulary
  now lists the two pre-due never wordings (… unless a new head lands
  or the author maintains this repository / … on the next sweep unless
  the author maintains this repository), matching the code.
- Rebased onto v5: the hedge paragraph moved with the split page to
  docs/labels-and-control-signals/stage-labels.md (#15712).

Hive-Fix-Attempt: 1/6
Hive-Run: #15692

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
…15738)

* πŸ› fix: never-policy 072 row stops promising adoption it can't back

The engine only reads a contributor's repository permission once
adoption is due (adoptContributorPR gates maintainerHoldsAdoption
behind the due check), so a stage/072 row under
maintainer_policy: never had no AdoptionBlocked record before that
moment and nothing to tell it apart, in the dashboard's own data,
from a row the hive will truly auto-adopt. The tracker read "hive
adopts it in Nm" right up to the due moment for a maintainer's own
PR, then flipped to "not adopted: maintainer_policy is never".

stageTrackerAdoptionText now names the exception for the never
policy's auto-adopt countdown instead of promising an outcome it
cannot back for every author: "… unless the author maintains this
repository".

Hive-Run: #15692
Hive-Plan: review-backlog-correctness
Hive-Spec: issue-15692#stage_tracker_adoption_never_policy_text
Signed-off-by: onkar717 <shelkeonka@gmail.com>

* πŸ› fix: fold never-policy hedge into one countdown source; document pill wordings

Review follow-up for #15738.

- stageTrackerAdoptionText: the two never-only cases repeated the
  AutoDue / AutoAdoptAt branches verbatim save for a trailing clause.
  stageTrackerAdoptionNeverHedge now computes that clause once and the
  two existing branches append it, so the countdown text has a single
  source of truth. Rendered strings are unchanged.
- docs/dashboard-sections/activity-monitor.md: the 072 pill vocabulary
  now lists the two pre-due never wordings (… unless a new head lands
  or the author maintains this repository / … on the next sweep unless
  the author maintains this repository), matching the code.
- Rebased onto v5: the hedge paragraph moved with the split page to
  docs/labels-and-control-signals/stage-labels.md (#15712).

Hive-Fix-Attempt: 1/6
Hive-Run: #15692

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: onkar717 <shelkeonka@gmail.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: onkar717 <shelkeonka@gmail.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/docs/labels-and-control-signals.md is a merge hotspot β€” split into 4 sections

0 participants