Repository navigation
π± refactor: split src/docs/labels-and-control-signals.md into per-section pages - #15712
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:Sign-off survives the squash |
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15405:2/2:0/0:operator-reference.md |
There was a problem hiding this comment.
Verified the move is lossless; looks correct to me.
- Diffed the merge-base
src/docs/labels-and-control-signals.md(2630 lines) against the concatenation of the three new pages, normalising only the../link prefix and cross-file anchor targets: the only differences are the three new page# β¦titles and their "Part of β¦" lines. No section body changed. - The three anchored links still pointing at the old path (
src/docs/dashboard-sections/activity-monitor.md:18, :100, :637β#stage-labels-β¦,#the-regressed-marker-β¦,#decision-glossary) all land on<a id>anchors the index now carries, so leaving that file alone was safe. src/pkg/stageengine/transition_table_test.go:15diagramDocnow points atstage-labels.md, which is where the single```mermaidblock moved; the comments intransition.go/transition_table.gowere repointed to match.
CI: everything green except the arm64 build still running at eec3106.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
β¦ll wordings Review follow-up for #15738. - stageTrackerAdoptionText: the two never-only cases repeated the AutoDue / AutoAdoptAt branches verbatim save for a trailing clause. stageTrackerAdoptionNeverHedge now computes that clause once and the two existing branches append it, so the countdown text has a single source of truth. Rendered strings are unchanged. - docs/dashboard-sections/activity-monitor.md: the 072 pill vocabulary now lists the two pre-due never wordings (β¦ unless a new head lands or the author maintains this repository / β¦ on the next sweep unless the author maintains this repository), matching the code. - Rebased onto v5: the hedge paragraph moved with the split page to docs/labels-and-control-signals/stage-labels.md (#15712). Hive-Fix-Attempt: 1/6 Hive-Run: #15692 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦15738) * π fix: never-policy 072 row stops promising adoption it can't back The engine only reads a contributor's repository permission once adoption is due (adoptContributorPR gates maintainerHoldsAdoption behind the due check), so a stage/072 row under maintainer_policy: never had no AdoptionBlocked record before that moment and nothing to tell it apart, in the dashboard's own data, from a row the hive will truly auto-adopt. The tracker read "hive adopts it in Nm" right up to the due moment for a maintainer's own PR, then flipped to "not adopted: maintainer_policy is never". stageTrackerAdoptionText now names the exception for the never policy's auto-adopt countdown instead of promising an outcome it cannot back for every author: "β¦ unless the author maintains this repository". Hive-Run: #15692 Hive-Plan: review-backlog-correctness Hive-Spec: issue-15692#stage_tracker_adoption_never_policy_text Signed-off-by: onkar717 <shelkeonka@gmail.com> * π fix: fold never-policy hedge into one countdown source; document pill wordings Review follow-up for #15738. - stageTrackerAdoptionText: the two never-only cases repeated the AutoDue / AutoAdoptAt branches verbatim save for a trailing clause. stageTrackerAdoptionNeverHedge now computes that clause once and the two existing branches append it, so the countdown text has a single source of truth. Rendered strings are unchanged. - docs/dashboard-sections/activity-monitor.md: the 072 pill vocabulary now lists the two pre-due never wordings (β¦ unless a new head lands or the author maintains this repository / β¦ on the next sweep unless the author maintains this repository), matching the code. - Rebased onto v5: the hedge paragraph moved with the split page to docs/labels-and-control-signals/stage-labels.md (#15712). Hive-Fix-Attempt: 1/6 Hive-Run: #15692 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: onkar717 <shelkeonka@gmail.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: onkar717 <shelkeonka@gmail.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Why
src/docs/labels-and-control-signals.md(2.6k lines) is a merge hotspot: 6 PRs touched it in 7 days, 6 concurrent pairs.Layout
src/docs/labels-and-control-signals.mdstays as the index (path unchanged) and links the pages undersrc/docs/labels-and-control-signals/:reference.mdβ first use, label axes, categories, reference tablestage-labels.mdβ stage labels and the pipeline state machineglossary-and-operations.mdβ decision glossary, blockers, matching rules, config, question auto-close, examples, follow-ups3 pages (each 150+ lines), within the issue's 4-file cap. Section bodies are moved verbatim; only relative links were prefixed with
../and in-page anchors that now cross files were pointed at the new file.Inbound links
<a id>anchors for every##section and theregressedmarker anchor, so links that still use the old path (e.g.dashboard-sections.md, which is being edited elsewhere and was not touched) keep resolving.stageenginediagram test and Go comments now point atstage-labels.md, where the mermaid diagram lives;file:linecitations in the ADR/plan were repointed.Docs-only move, no behaviour change.
Closes #15675
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88