Skip to content

πŸ› ci-maintainer: cap open merge-hotspot refactor issues (default 2) - #15684

Merged
clubanderson merged 3 commits into
v5from
fix/hotspot-issue-cap
Oct 30, 2026
Merged

clubanderson merged 3 commits into
v5from
fix/hotspot-issue-cap

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #15682

The hotspot filer had only per-file dedupe, so one pass could open five refactor: … is a merge hotspot issues while three older ones still had PRs in flight.

  • governor.hotspot_max_open (default 2): no new hotspot issue while that many advisor-filed issues are open for the repo (PR-covered ones count); the highest-ranked uncapped hotspot is filed when a slot frees.
  • governor.hotspot_max_per_pass (default 1): at most this many new issues per pass.
  • Existing dedupe/refile unchanged; one INFO line per pass when the cap holds.
  • Store.OpenIssues, config accessors, operator-reference docs, changelog fragment, unit test (no sleeps).

Note: hotspot knobs live under governor.hotspot_* (there is no agents.ci_maintainer config section), so the new ones follow that convention.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15516 πŸ“– docs: split the operator reference CONFLICT src/docs/operator-reference.md
#15405 πŸ› fix: require verified signature for email-only hive commit identity match same files src/docs/operator-reference.md
#15673 πŸ› issues the hive files carry the filing agent in the title same files src/pkg/hotspot/hotspot_test.go
src/pkg/hotspot/issue.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 2/4)
  • test (dashboard shuffle 2/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 071-needs-author: optional-check-failing:test (dashboard 2/4)

…-only)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One verified correctness problem; the caps themselves behave as the test pins them.

hotspot_max_open slots leak for issues whose file stops being a hotspot (medium) β€” src/pkg/hotspot/store.go:248 (OpenIssues) counts every record with ClosedAt zero. The only place a record is ever marked closed is Filer.File at src/pkg/hotspot/issue.go:251-263, and that branch is reached only for a file that is still in the current hs and Actionable(). Once a modularize issue does its job β€” the split lands, the path shrinks or cools below hotspot_min_prs β€” the file drops out of hs, the record is never reconciled, and Prune (store.go:266-272) deliberately keeps open records. Each such record permanently consumes one slot; with the default of 2, two of them stop the advisor filing anything for that repo, and nothing logs why beyond the per-pass "not filing" line. Before this PR a stale record only affected refile for that one file; the cap turns it into a repo-wide stop.

Suggested fix: at the top of File, walk Store records for repo with zero ClosedAt and run them through Stater.HotspotIssueState (marking closed as the per-file branch does) before OpenIssues is consulted. The test's pass 4 doesn't cover this because a is still in hs when its issue closes.

Everything else checked out: OrDefault accessors, allowlist, operator-reference table and fragment are consistent with the body.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the review swarm requested changes

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 071-needs-author: reviewer-verdict:changes_requested

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@clubanderson
clubanderson merged commit add671f into v5 Oct 30, 2026
73 checks passed
@clubanderson
clubanderson deleted the fix/hotspot-issue-cap branch October 30, 2026 05:38
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› [ci-maintainer] hotspot filer opens 5 refactor issues per pass with no cap on open ones

1 participant