Repository navigation
π ci-maintainer: cap open merge-hotspot refactor issues (default 2) - #15684
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: optional-check-failing:test (dashboard 2/4) |
β¦-only) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
One verified correctness problem; the caps themselves behave as the test pins them.
hotspot_max_open slots leak for issues whose file stops being a hotspot (medium) β src/pkg/hotspot/store.go:248 (OpenIssues) counts every record with ClosedAt zero. The only place a record is ever marked closed is Filer.File at src/pkg/hotspot/issue.go:251-263, and that branch is reached only for a file that is still in the current hs and Actionable(). Once a modularize issue does its job β the split lands, the path shrinks or cools below hotspot_min_prs β the file drops out of hs, the record is never reconciled, and Prune (store.go:266-272) deliberately keeps open records. Each such record permanently consumes one slot; with the default of 2, two of them stop the advisor filing anything for that repo, and nothing logs why beyond the per-pass "not filing" line. Before this PR a stale record only affected refile for that one file; the cap turns it into a repo-wide stop.
Suggested fix: at the top of File, walk Store records for repo with zero ClosedAt and run them through Stater.HotspotIssueState (marking closed as the per-file branch does) before OpenIssues is consulted. The test's pass 4 doesn't cover this because a is still in hs when its issue closes.
Everything else checked out: OrDefault accessors, allowlist, operator-reference table and fragment are consistent with the body.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: reviewer-verdict:changes_requested |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #15682
The hotspot filer had only per-file dedupe, so one pass could open five
refactor: β¦ is a merge hotspotissues while three older ones still had PRs in flight.governor.hotspot_max_open(default 2): no new hotspot issue while that many advisor-filed issues are open for the repo (PR-covered ones count); the highest-ranked uncapped hotspot is filed when a slot frees.governor.hotspot_max_per_pass(default 1): at most this many new issues per pass.Store.OpenIssues, config accessors, operator-reference docs, changelog fragment, unit test (no sleeps).Note: hotspot knobs live under
governor.hotspot_*(there is noagents.ci_maintainerconfig section), so the new ones follow that convention.