Skip to content

πŸ› fix: select latest merged issue closer - #15634

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
hive/adopt-15609
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
hive/adopt-15609

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15609 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Fixes #15606
Fixes #15607

This branch is #15609's head 4cd8b23c5e90 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: optional-check-failing:overlayfs-exec-guard.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Choose the latest merged same-repository closing reference so GraphQL node ordering does not decide which pull request is reported.

Hive-Run: #15606

Hive-Plan: issue-15606

Hive-Spec: issue-15606#latest-merged-closer
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15609 πŸ› fix: select latest merged issue closer same files changelog.d/fixed-15606-latest-issue-closer.md
src/pkg/github/pr_supersession_closer_test.go
src/pkg/github/pr_supersession_sweep.go

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 060-reviewed β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read src/pkg/github/pr_supersession_sweep.go and its callers at this head. closedByPullRequestReference (lines 468-485) now keeps the same-repo merged node with the latest MergedAt instead of returning on the first one; the three callers (pr_supersession_sweep.go:418, advisory_work.go:105, decomposed_parents.go:283) only consume the single (closer, ok) result, so the change is contained. The new test exercises unmerged, cross-repo and earlier-merged nodes together. Looks correct to me.

One observation, not a defect: the REST fallback in resolveIssueClosingPR (pr_supersession_sweep.go:429-434) still returns the first merged PR for the closing commit. It only runs when GraphQL returned no closer, and a commit normally maps to one merged PR, so I would not hold this PR for it.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit b4e5992 into v5 Oct 30, 2026
78 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15609 branch October 30, 2026 03:49
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15634b475b07` sha256:5c835dab1610b59eb41de575c088f0ac73a0472e45de68bf6e838c26ec20de3d β€” download from the dashboard or `hivectl review evidence #15634`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

1 participant