Repository navigation
π fix: select latest merged issue closer - #15634
Conversation
Choose the latest merged same-repository closing reference so GraphQL node ordering does not decide which pull request is reported. Hive-Run: #15606 Hive-Plan: issue-15606 Hive-Spec: issue-15606#latest-merged-closer Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
stage 060-reviewed β 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Read src/pkg/github/pr_supersession_sweep.go and its callers at this head. closedByPullRequestReference (lines 468-485) now keeps the same-repo merged node with the latest MergedAt instead of returning on the first one; the three callers (pr_supersession_sweep.go:418, advisory_work.go:105, decomposed_parents.go:283) only consume the single (closer, ok) result, so the change is contained. The new test exercises unmerged, cross-repo and earlier-merged nodes together. Looks correct to me.
One observation, not a defect: the REST fallback in resolveIssueClosingPR (pr_supersession_sweep.go:429-434) still returns the first merged PR for the closing commit. It only runs when GraphQL returned no closer, and a commit normally maps to one merged PR, so I would not hold this PR for it.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15609 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Fixes #15606
Fixes #15607
This branch is #15609's head
4cd8b23c5e90as pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:optional-check-failing:overlayfs-exec-guard.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.