Repository navigation
π ci: stream-image writes multi-line tags output with a heredoc - #15610
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
349d188
βΉοΈ Sentinel notice β informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm this workflow change to .github/workflows/stream-image.yml (multi-line GITHUB_OUTPUT heredoc, no permission or trigger changes) may land.
Routing to a human because this edits a workflow file, which the review policy treats as a trust surface regardless of content. The facts, for whoever decides:
- The change is correct.
.github/workflows/stream-image.yml:94-100previously wrotetags=<img>:<sha>\n<img>:<branch>-latestto$GITHUB_OUTPUT; the second line has nokey=so the runner rejects the output file ("Invalid format"). The heredoc form (tags<<EOF_TAGSβ¦EOF_TAGS) is the documented multi-line syntax, and the consumerdocker/build-push-action(:122) accepts a newline-separatedtagslist. The pull_request branch at:87-88is single-line and unchanged. - Nothing else changes: no
permissions:, triggers, secrets, or action pins are touched (4 lines added, 1 removed). - Author is the repository owner.
Nothing further needed from me.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
The push-branch path wrote a two-line
tags=value to$GITHUB_OUTPUTas a plainkey=valueline, which Actions rejects (Invalid format 'ghcr.io/hivecommons/hive-stream:v5-latest'), so the first v5 run of Stream Image failed before building. Use the documented heredoc delimiter form for multi-line outputs. Follow-up to #15595.