Skip to content

πŸ› ci: stream-image writes multi-line tags output with a heredoc - #15610

Merged
clubanderson merged 1 commit into
v5from
fix/stream-image-output-heredoc
Oct 30, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/stream-image-output-heredoc

Conversation

@clubanderson

Copy link
Copy Markdown
Member

The push-branch path wrote a two-line tags= value to $GITHUB_OUTPUT as a plain key=value line, which Actions rejects (Invalid format 'ghcr.io/hivecommons/hive-stream:v5-latest'), so the first v5 run of Stream Image failed before building. Use the documented heredoc delimiter form for multi-line outputs. Follow-up to #15595.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
349d188

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head 349d1880a181) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/stream-image.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@clubanderson
clubanderson merged commit 9e23992 into v5 Oct 30, 2026
79 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/stream-image-output-heredoc branch October 30, 2026 01:50
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm this workflow change to .github/workflows/stream-image.yml (multi-line GITHUB_OUTPUT heredoc, no permission or trigger changes) may land.

Routing to a human because this edits a workflow file, which the review policy treats as a trust surface regardless of content. The facts, for whoever decides:

  • The change is correct. .github/workflows/stream-image.yml:94-100 previously wrote tags=<img>:<sha>\n<img>:<branch>-latest to $GITHUB_OUTPUT; the second line has no key= so the runner rejects the output file ("Invalid format"). The heredoc form (tags<<EOF_TAGS … EOF_TAGS) is the documented multi-line syntax, and the consumer docker/build-push-action (:122) accepts a newline-separated tags list. The pull_request branch at :87-88 is single-line and unchanged.
  • Nothing else changes: no permissions:, triggers, secrets, or action pins are touched (4 lines added, 1 removed).
  • Author is the repository owner.

Nothing further needed from me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant