Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/docs/dashboard-sections.md
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ The tooltip lists the PRs ahead and the overlapping files. Waiting siblings are

Before the merge gate, the tracker defers general `sentinel`, `needs human` and `unauthorized` pills so they do not distract from work still in motion. **Exception:** `unauthorized:approve-workflow-runs` appears immediately, because a person must approve the held run before CI can start.

The server splits markers by `ActionableNow` (`stageTrackerModifiers` in `stage_tracker.go`). The payload puts drawn pills in `modifiers` and held-back pills in `deferred_modifiers`.
The server splits markers by `ActionableNow` (`stageTrackerModifiers` in `stage_tracker_caption.go`). The payload puts drawn pills in `modifiers` and held-back pills in `deferred_modifiers`.

A deferred pill is simply absent — no chip, no breathing chevron, no **Needs attention** count — until the PR's stage reaches the merge-gate band (`stage/080` and later: 080, 085, 090, 095, 100, the same boundary adoption yields at), when it renders exactly as before and counts; the row tooltip alone says "Pending at merge gate: sentinel, needs-human". The merge-gate cell's own words ("Sentinel alert · needs human", "Awaiting human: …") are unchanged — they only appear at the gate anyway.

Expand Down
4 changes: 2 additions & 2 deletions src/pkg/dashboard/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ type Server struct {
// the tracker's "Merging" rows (stage_tracker_merge_gate.go); tests only.
mergeAttempts func() []github.MergeAttempt
// stageTrackerCache is the last /api/stage-tracker payload built from
// the status snapshot, served until its TTL lapses (stage_tracker.go).
// the status snapshot, served until its TTL lapses (stage_tracker_build.go).
stageTrackerCache stageTrackerCache
stageTrackerCacheMu sync.Mutex
// stageTrackerBuild is the one rebuild in flight, nil when none; it is
Expand All @@ -160,7 +160,7 @@ type Server struct {
// build they can hold open; nil in production.
stageTrackerBuildFn func(status *StatusPayload, store *stagelabels.Store, now time.Time) StageTrackerResponse
// stageTrackerLinks memoises the issue lookups that title the tracker's
// untitled links across rebuilds (stage_tracker.go).
// untitled links across rebuilds (stage_tracker_links.go).
stageTrackerLinks stageTrackerLinkMemo
// evidenceHB is the background-refreshed evidence aggregate the hub
// heartbeat reads (evidence_heartbeat.go); zero value is ready to use.
Expand Down
Loading
Loading