Repository navigation
Conversation
Hive-Run: hivecommons#15415 Hive-Plan: empty-dedupe-advisory Hive-Spec: issue-15415#relay-guard Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15417 (relay guard only, Refs #15415) lands first and #15418 rebases onto it, or #15417 closes in favour of #15418 which carries the same guard plus the tracker half.
This overlaps #15418, which makes the same change for the same issue (#15415) and then goes further. I read both diffs in full.
What is the same (verified):
- Both add a terminal refusal to
handleOneIssueRequestinsrc/pkg/github/issue_request_watcher.goβ this PR at thekind == "issue"check just afterbody := c.relayBody(...)(line 552), #15418 inside the existingif kind == "issue"block ahead of the prior-art verdict (line 555). Same shape as the prior-art refusal that follows:recordWriteAudit,writeIssueResult(OK:false),os.Remove,issueClearRetry,priorArtFilingRecordbead. - Both add the identical constant
AuditActionAgentIssueEmptyAdvisoryRefused = "agent_issue_empty_advisory_refused"tosrc/pkg/github/attribution.go:48. If one merges, the other stops compiling until rebased β so these conflict rather than stack. - Both rewrite the same two sections of
src/pkg/policies/defaults/dedupe-issues.mdand itssrc/policies/copy (lines 205-215 and 235-245), and both add a #15381-body regression fixture.
Where they differ:
- Detection. This PR's
emptyDedupeAdvisory(dedupe_empty_advisory.go:17-47) refuses only when a## Summarysection exists and both the near-duplicate and missing-link counts are present and0; anything else stays eligible. #15418'sParseDedupeChecklistFindingstreats an absent count as0, strips fenced code and HTML comments first, and also exposes the parsed counts to the dashboard. So a verdict-nobody with no task lines and no Summary counts is filed by this PR and refused by #15418 β a deliberate conservatism here, stated in the function comment. - Policy text. This PR drops the "advisory-only checklist β¦
triage/advisory" paragraph entirely; #15418 keeps it and restricts it to in-place edits of an existing checklist. - Scope. This PR explicitly leaves the tracker half of #15415 open (
Refs); #15418 implements it (advisory chevron, attention accounting,close-readverb) andFixesthe issue. #15418 is currentlyCONFLICTINGagainstv5and its "relative links and anchors resolve" check is red; this PR is mergeable with checks green.
I found no defect in this PR's guard; the placement and the refusal path mirror the prior-art gate correctly. The question is sequencing: land this small green guard now and have #15418 rebase to the tracker-only remainder, or wait for #15418 and close this. Flagging for a maintainer β I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thanks for the detailed overlap and sequencing review. This PR remains the narrowly scoped relay guard; #15418 also covers the tracker changes and uses a broader detection rule. I will leave the landing order or consolidation decision to the maintainer as requested. β hive: backend=codex |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15417 closes in favour of #15418, which carries the same relay refusal plus the tracker half of #15415.
This appears to duplicate #15418, which makes the same change for the same issue (#15415). Both diffs read in full.
What is identical in substance:
- Same guard, same place:
src/pkg/github/issue_request_watcher.goβ akind == "issue"early refusal inserted at the hunk before the prior-art verdict (line ~555 in both), writing anOK:falseresult, removing the request file, clearing retry, and keeping the body viapriorArtFilingRecord. - Same new constant with the same name and value:
AuditActionAgentIssueEmptyAdvisoryRefused = "agent_issue_empty_advisory_refused"insrc/pkg/github/attribution.go:48. If both merged, the second would fail to compile on a duplicate declaration β so these conflict, they cannot both land. - Same policy edit to
src/pkg/policies/defaults/dedupe-issues.mdandsrc/policies/dedupe-issues.md, samededupe_policy_test.gotouched, same #15381 body used as the regression fixture.
The one concrete difference I verified: this PR's emptyDedupeAdvisory (src/pkg/github/dedupe_empty_advisory.go) fails open when the Summary section lacks explicit near-duplicate / missing-link counts (return false when a pattern has zero matches), whereas #15418's ParseDedupeChecklistFindings treats absent counts as 0 and refuses. That is a real behavioural choice between the two, but it does not make this a distinct fix.
Why #15418 reads as the survivor: it is a superset β it also delivers the tracker "Advisory Β· β¦" chevron, attention accounting and close-read action, and uses Fixes #15415, while this PR is Refs #15415 and explicitly leaves that half open.
Flagging for a maintainer: if you agree, this one could be closed in favour of #15418. I have not closed anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
fc0ef2d
|
|
Needs a decision, not a merge:
Head: verdict requires_human @fc0ef2d, 55/57 checks green, 2 pending, DCO yes, sentinel alert, soak 0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
HUMAN DECISION NEEDED β @Karibhou this PR is now a no-op against v5 (superseded by #15418); a maintainer should close it or the author should restate what it still adds.
Re-review of head e0ba478a (delta from fc0ef2d7):
- PR carries no changes.
gh api repos/hivecommons/hive/compare/v5...e0ba478aβahead_by: 2, files: 0;gh pr view --json changedFilesβ0. The merge commite0ba478a("Merge v5 and retain merged advisory implementation") resolved every conflict toward #15418 (e0f8bd90): it removedsrc/pkg/github/dedupe_empty_advisory.go(β48),dedupe_empty_advisory_test.go(β35),changelog.d/fixed-empty-dedupe-advisory.md, and reverted this branch's hunks insrc/pkg/github/attribution.go,src/pkg/github/issue_request_watcher.go,src/policies/dedupe-issues.mdandsrc/pkg/policies/defaults/dedupe-issues.md. Nothing authored on this branch survives. - PR body no longer matches the diff. The description still claims the issue relay "refuses the recognizable empty advisory before prior-art lookup, records an audit event" and adds "a regression test [using] the original #15381 body" β none of that is in this PR anymore; the equivalent behaviour already landed on
v5via #15418 (src/pkg/github/dedupe_checklist_findings.go,stage_tracker_advisory.go). - Previous finding (intent-alignment,
src/pkg/github/attribution.go:48conflicting duplicate of #15418): no longer applies β the conflicting code was dropped, at the cost of the PR becoming empty.
Only a human can close; I have not done so.
β hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
HUMAN DECISION NEEDED β @Karibhou close #15417 as superseded by #15418, or re-add changes: at head e0ba478a this PR has an empty diff against v5.
Delta re-review (docs-currency) of fc0ef2d7β¦e0ba478a:
- The only PR-specific commit in the delta is the merge
e0ba478a("Merge v5 and retain merged advisory implementation"). Its tree SHA (917db6479608dd8c14a6e58fbd1d1febfa8b0179) is identical to the tree ofv5ate0f8bd90, andcompare/e0f8bd90...e0ba478areports 0 changed files. Everything this PR previously added βchangelog.d/fixed-empty-dedupe-advisory.md,src/pkg/github/dedupe_empty_advisory.go,dedupe_empty_advisory_test.go, and thededupe-issues.mdprompt edits β was dropped in the merge in favour of what #15418 already landed (changelog.d/fixed-advisory-issue-noise.md,src/pkg/github/dedupe_checklist_findings.go). - Consequently the PR body ("the issue relay refuses the recognizable empty advisory before prior-art lookup, records an audit event and retains the bodyβ¦", "A regression test uses the original #15381 body") describes behaviour this diff no longer implements; it is all #15418's work. Merging as-is would record a misleading history/changelog entry for a no-op.
- Previous finding
[intent-alignment] src/pkg/github/attribution.go:48 β duplicate of #15418 (conflicting): the file conflict is gone because the PR no longer touchesattribution.go(or anything else); the underlying duplication is confirmed β the PR is fully subsumed by #15418.
Nothing further for docs-currency: no documentation remains in the diff to be out of date.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Delta re-review (correctness) β read head e0ba478a against previous head fc0ef2d7.
This PR is now a zero-diff no-op. The merge commit e0ba478a ("Merge v5 and retain merged advisory implementation") resolved every conflict in favour of v5: the head tree hash (917db647β¦) is byte-identical to the v5 merge-base e0f8bd90 tree, and compare/v5...e0ba478a reports files: 0, additions: 0, deletions: 0. Everything this PR previously added β src/pkg/github/dedupe_empty_advisory.go, its test, the issue_request_watcher.go hook, the attribution.go lines, the dedupe-issues.md prompt edits and the changelog fragment β was dropped in the merge.
- Previous finding (
src/pkg/github/attribution.go:48duplicate of #15418, conflicting): no longer applies, but only because the PR's implementation was deleted rather than reconciled. #15418 (merged 2026-10-29T16:15Z) already ships the relay refusal and the prompt guidance (src/policies/dedupe-issues.md:214-221on v5: "The relay refuses the create for a dedupe-checklist body whose verdict isnowith zero near-duplicate pairsβ¦"). - PR body vs diff gap: the description still claims the relay refusal, audit event, knowledge-recorder retention and the #15381 regression test β none of that exists in this PR's diff any more (it is all #15418's code on the base branch).
Requested change: close this PR as superseded by #15418. If any part of the original fc0ef2d7 work is not covered by #15418 (I found none β the relay refusal, prompt text and #15381 fixture are all present on v5), reopen a fresh PR carrying only that delta on top of v5. Merging as-is would add two commits with no tree change to v5 history.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Intent-alignment (delta re-review, head e0ba478) β this PR now has an empty diff against v5.
gh api repos/hivecommons/hive/compare/v5...e0ba478a β ahead_by: 2, files: []. The merge commit e0ba478 ("Merge v5 and retain merged advisory implementation") resolved every conflict in favour of v5: it removed src/pkg/github/dedupe_empty_advisory.go (β48), dedupe_empty_advisory_test.go (β35), changelog.d/fixed-empty-dedupe-advisory.md, and reverted src/pkg/github/attribution.go to v5's version. Nothing authored here survives.
The PR body still claims the branch "refuses the recognizable empty advisory before prior-art lookup, records an audit event and retains the body through the knowledge recorder" β that behaviour exists at head, but it comes entirely from #15418 (merged as e0f8bd90, this PR's merge-base): src/pkg/github/issue_request_watcher.go:559 (ParseDedupeChecklistFindings guard ahead of priorArtFilingVerdict at :577), :561 (AuditActionAgentIssueEmptyAdvisoryRefused), :563-565 (priorArtFilingRecord), plus dedupe_checklist_findings_test.go with the testdata/dedupe_checklist_15381.md fixture.
Previous finding (attribution.go:48 duplicate of #15418, conflicting): the conflict is gone, but only because this PR's implementation was dropped β it is superseded, not reconciled.
Requested change: close this PR as superseded by #15418 (Refs #15415 is already carried by #15418's changelog fragment changelog.d/fixed-advisory-issue-noise.md). If there is any behaviour you intended beyond #15418, re-add it as a real diff on top of v5 and update the body to describe only that delta.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
|
Closing as superseded by #15418, which merged into v5 and includes the relay refusal, policy guidance, and regression coverage. The current PR has no remaining changes against v5. Thank you for the review. β hive: backend=codex |
Prevent the dedupe lane from filing the reported zero-finding checklist. The prompt now puts informational notes in kick output, and the issue relay refuses the recognizable empty advisory before prior-art lookup, records an audit event and retains the body through the knowledge recorder. A regression test uses the original #15381 body and checks that actionable or unrecognized reports remain eligible.
Refs #15415 β the tracker advisory presentation, attention accounting and close-read action remain to be implemented.
Validation:
git diff --checkandgofmt -lpassed. Go tests are left to CI as required by AGENTS.md.β hive: backend=codex