Repository navigation
🌱 chore(crux): move tmux session accessors out of manager.go - #15330
Conversation
SessionMissing and TmuxSession are tmux-session queries; they belong with the rest of the tmux boundary in manager_tmux.go. #15270 grew agent/manager.go to 1696 lines, over the 1689-line baseline enforced by crux's Go file-size ratchet, so every crux-publish sync since then fails that check on crux main. Pure move, no behaviour change. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Looks correct to me. Verified it is a pure move, not just by eye:
- Extracted the
-lines fromsrc/crux/agent/manager.goand the+lines fromsrc/crux/agent/manager_tmux.goin this diff anddiffed them: the only differences are blank-line placement.SessionMissingandTmuxSessionbodies and doc comments are byte-identical, samepackage agent, no build constraints onmanager_tmux.go(manager_tmux.go:1). - Ratchet effect checked against crux's
.github/go-file-size-ratchet.txt:agent/manager.gobaseline is 1689 (line 18); this PR takes it to 1658.agent/manager_tmux.gois not listed, so the 800-line limit applies, and at heada309c03it is 706 lines — under the limit with room to spare.
One body/diff mismatch, not a defect: the body says "no changelog fragment", but the diff adds changelog.d/changed-15330.md. Fine to keep (the fragment guard wants it); just the sentence in the body is stale.
The cancelled "Sign-off survives the squash" check looks like a run cancelled by a superseding push rather than a failure of this diff.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me — verified as a pure move, and it does clear the crux ratchet.
- Diffed
SessionMissingandTmuxSessionbetweensrc/crux/agent/manager.go(removed at old lines 1640-1677) andsrc/crux/agent/manager_tmux.go:670-706: bodies and doc comments are byte-identical; same package, no new imports needed.go build ./agent/passes ata309c03. - Ran crux
main's.github/scripts/check-file-size-ratchet.shagainstsrc/cruxat this head:agent/manager.gois 1658 lines (baseline 1689) →ok.manager_tmux.gogrows to 706 lines, under the 800 limit and not in the baseline, so no new entry is needed. - #15332 (the hive-side ratchet workflow) is currently red for exactly the breach this PR fixes; landing this one first turns that check green.
One body/diff mismatch, informational: the body says "no behaviour change — so no changelog fragment", but the diff does add changelog.d/changed-15330.md. Harmless either way (the fragment guard likely required it), just noting that the prose is stale.
Small follow-up for whoever syncs crux: the ratchet now prints a notice suggesting the baseline be lowered to 1658 agent/manager.go in crux's .github/go-file-size-ratchet.txt. Optional — the gate passes without it.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
manager.go sits at 1696 lines against crux's ratchet baseline of 1689, so the new crux-file-size-ratchet check fails on the branch itself. Move the ManagerOption block and UID-map path helpers into manager_options.go to bring the file back under the baseline. Refs #15330 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…15332) * 🌱 ci: run crux's Go file-size ratchet against src/crux on hive PRs Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * crux/agent: move Manager options out of manager.go manager.go sits at 1696 lines against crux's ratchet baseline of 1689, so the new crux-file-size-ratchet check fails on the branch itself. Move the ManagerOption block and UID-map path helpers into manager_options.go to bring the file back under the baseline. Refs #15330 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Why
hivecommons/cruxmainhas been red on Go file-size ratchet since the last two publish syncs (job 123276178637):#15270 added seven lines (the
kickLogArchivedKick/kickLogArchivedPathfields) tosrc/crux/agent/manager.go. That is correct code, but crux's ratchet (.github/go-file-size-ratchet.txt, crux#20) only lives in the crux repository — the publish sync replaces every other path — so hive CI cannot see it and the breach only surfaces after the sync lands on cruxmain.This moves
SessionMissingandTmuxSessionfrommanager.gointomanager_tmux.go, where the rest of the tmux-session boundary (tmuxBaseArgs,newSessionCommands,tmuxSessionExistsForAgent's callers) already lives.manager.gogoes 1696 → 1658 lines, comfortably under the baseline with room for the next small field. Pure move: identical bodies and doc comments, same package, no behaviour change — so no changelog fragment.The crux check turns green on the next
🌱 sync: hive@…after this merges; nothing needs to change in the crux repository itself.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88