Skip to content

🐛 dashboard: merge toast renders above the chat button - #15290

Merged
clubanderson merged 2 commits into
v5from
fix/toast-zorder
Oct 29, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/toast-zorder

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15288

The merged-toast stack (#merge-banners) and the .cue-flight glyph are appended to <body>, but their layer tokens --z-merge-banner / --z-cue-flight were declared on #activity-monitor-section. Outside the section they resolved to nothing, so the stack fell back to z-index: auto and the chat FAB (z-index: 9000) painted over the lowest toast's close × and truncated its text.

Fix: hoist both tokens to :root (10001 / 10000, above the FAB at 9000). Toast content/behaviour unchanged; .merge-banners stays pointer-events: none with each .merge-banner pointer-events: auto, so the close × is clickable.

Verification (headless Chrome, 1600×1000, two stacked banners built via stageTrackerMergeBanner, FAB forced solid):

#merge-banners z-index elementFromPoint at FAB centre at lowest toast's close ×
before auto hive-chat-fab hive-chat-fab
after 10001 merge-banner merge-banner-close

Adds TestStageTrackerMergeBannersAboveChatFab as a static guard.

The merged-toast stack (#merge-banners) and the .cue-flight glyph are
appended to <body>, but their layer tokens --z-merge-banner /
--z-cue-flight were declared on #activity-monitor-section. Outside the
section they resolved to nothing, so the stack had z-index:auto and the
chat FAB (z-index 9000) painted over the lowest toast's close × and
truncated its text. Hoist both tokens to :root; add a static guard.

Fixes #15288

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15104 🐛 Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/static/index.html
#15253 🐛 decision toast: issue decisions no longer read as 'approved for merge' same files src/pkg/dashboard/static/index.html
#15134 🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot added stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 1/4)
  • test (dashboard 2/4)
  • test (dashboard shuffle 1/3)
  • test (dashboard shuffle 2/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot removed the stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act label Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the tree at 982eb5d:

  • #merge-banners is created and appended to document.body (index.html:19941) and the .cue-flight glyph likewise (:19907), so custom properties declared on #activity-monitor-section were indeed out of scope for both — var(--z-merge-banner) at .merge-banners (:1728) and var(--z-cue-flight) at .cue-flight (:1699) resolved to the guaranteed-invalid value, i.e. z-index: auto. Hoisting to :root (:1338) is the minimal fix.
  • .hive-chat-fab is position: fixed; z-index: 9000 (:4298), so 10001 clears it; .merge-banners keeps pointer-events: none and .merge-banner re-enables them, so the close × stays reachable.
  • The test asserts the exact document.body.appendChild(box) line and the :root declaration, so it fails on the pre-fix file and on a future re-scoping.

One thing for the author to be aware of, not a defect: with the tokens now actually resolving, the toast stack ties .cred-dialog-overlay and #toast-container at 10001 (:1199, :3551) and sits above .config-overlay/.acmm-dialog-overlay at 10000. That is what the original token values intended ("above the modal chrome"), but it is the first time it takes effect.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified the mechanism in the tree at 982eb5d rather than from the description:

  • .merge-banners is created and appended to document.body (src/pkg/dashboard/static/index.html:19941), and the .cue-flight glyph likewise (index.html:19907). Neither is a descendant of #activity-monitor-section, so custom properties declared on that selector (the old line 1334) never inherited to them; z-index: var(--z-merge-banner) on .merge-banners (index.html:1728) and var(--z-cue-flight) on .cue-flight (index.html:1699) were invalid at computed-value time → auto, below .hive-chat-fab { z-index: 9000 } (index.html:4298). Moving the two tokens to :root (index.html:1338) is the minimal fix; --ham-sticky-bar-h correctly stays section-scoped.
  • The new test reuses cssRule/indexHTML from gh_app_banner_test.go in the same package and pins the FAB at 9000 so a future FAB bump can't silently re-cover the toasts.
  • Changelog fragment name fixed-15288-… matches the guard's <category>-<pr-or-slug>.md form.

CI hadn't run on this head when I read it; nothing in the diff should affect it.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@clubanderson
clubanderson merged commit e126c4a into v5 Oct 29, 2026
91 of 98 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/toast-zorder branch October 29, 2026 04:29
@hivecommons-hive hivecommons-hive Bot removed the stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot added the stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: merged toast renders behind the chat FAB (close × covered, text truncated)

1 participant