Repository navigation
🐛 dashboard: merge toast renders above the chat button - #15290
Conversation
The merged-toast stack (#merge-banners) and the .cue-flight glyph are appended to <body>, but their layer tokens --z-merge-banner / --z-cue-flight were declared on #activity-monitor-section. Outside the section they resolved to nothing, so the stack had z-index:auto and the chat FAB (z-index 9000) painted over the lowest toast's close × and truncated its text. Hoist both tokens to :root; add a static guard. Fixes #15288 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
Looks correct to me. Read the tree at 982eb5d:
#merge-bannersis created and appended todocument.body(index.html:19941) and the.cue-flightglyph likewise (:19907), so custom properties declared on#activity-monitor-sectionwere indeed out of scope for both —var(--z-merge-banner)at.merge-banners(:1728) andvar(--z-cue-flight)at.cue-flight(:1699) resolved to the guaranteed-invalid value, i.e.z-index: auto. Hoisting to:root(:1338) is the minimal fix..hive-chat-fabisposition: fixed; z-index: 9000(:4298), so 10001 clears it;.merge-bannerskeepspointer-events: noneand.merge-bannerre-enables them, so the close × stays reachable.- The test asserts the exact
document.body.appendChild(box)line and the:rootdeclaration, so it fails on the pre-fix file and on a future re-scoping.
One thing for the author to be aware of, not a defect: with the tokens now actually resolving, the toast stack ties .cred-dialog-overlay and #toast-container at 10001 (:1199, :3551) and sits above .config-overlay/.acmm-dialog-overlay at 10000. That is what the original token values intended ("above the modal chrome"), but it is the first time it takes effect.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me. Verified the mechanism in the tree at 982eb5d rather than from the description:
.merge-bannersis created and appended todocument.body(src/pkg/dashboard/static/index.html:19941), and the.cue-flightglyph likewise (index.html:19907). Neither is a descendant of#activity-monitor-section, so custom properties declared on that selector (the old line 1334) never inherited to them;z-index: var(--z-merge-banner)on.merge-banners(index.html:1728) andvar(--z-cue-flight)on.cue-flight(index.html:1699) were invalid at computed-value time →auto, below.hive-chat-fab { z-index: 9000 }(index.html:4298). Moving the two tokens to:root(index.html:1338) is the minimal fix;--ham-sticky-bar-hcorrectly stays section-scoped.- The new test reuses
cssRule/indexHTMLfromgh_app_banner_test.goin the same package and pins the FAB at 9000 so a future FAB bump can't silently re-cover the toasts. - Changelog fragment name
fixed-15288-…matches the guard's<category>-<pr-or-slug>.mdform.
CI hadn't run on this head when I read it; nothing in the diff should affect it.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15288
The merged-toast stack (
#merge-banners) and the.cue-flightglyph are appended to<body>, but their layer tokens--z-merge-banner/--z-cue-flightwere declared on#activity-monitor-section. Outside the section they resolved to nothing, so the stack fell back toz-index: autoand the chat FAB (z-index: 9000) painted over the lowest toast's close × and truncated its text.Fix: hoist both tokens to
:root(10001 / 10000, above the FAB at 9000). Toast content/behaviour unchanged;.merge-bannersstayspointer-events: nonewith each.merge-bannerpointer-events: auto, so the close × is clickable.Verification (headless Chrome, 1600×1000, two stacked banners built via
stageTrackerMergeBanner, FAB forced solid):#merge-bannersz-indexelementFromPointat FAB centreautohive-chat-fabhive-chat-fab10001merge-bannermerge-banner-closeAdds
TestStageTrackerMergeBannersAboveChatFabas a static guard.