Repository navigation
π docs: decision glossary Rules table lists capability-gap and human-merge - #15259
Conversation
β¦ary Rules table Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Content is correct; one convention gap to close before this fully fixes the drift it targets.
Verified against src/pkg/delegatedecision/decision_glossary.go at v5 (385cd9a):
capability-gaprow β Plain/Detail text matchesdecision_glossary.go:99-100verbatim; placed in the Rules table, alphabetical beforeci-ratchet. Correct.human-mergerow β text matchesdecision_glossary.go:191-192verbatim. It isKind: GlossaryReason, not a Rule, and the diff puts it in the Reasons table (betweenholdandlabel:needs-human), which is right even though the title/issue say "Rules table".
Finding (low) β src/docs/labels-and-control-signals.md:1513, the new human-merge Token cell lists only the slug. decision_glossary.go:193 declares four aliases: untrusted-author, ready-for-human-merge, contributor-lane:author-association, author-association. Every other aliased entry in these tables lists slug + aliases sorted in the Token cell (e.g. label:needs-human, needs-human, requires_human β decision_glossary.go:173; dco, dco-missing β :170; the changes-requested row β :153). A reader who sees untrusted-author or author-association in a lane reason and searches this table will not find the entry. Suggested Token cell: `author-association`, `contributor-lane:author-association`, `human-merge`, `ready-for-human-merge`, `untrusted-author`.
Follow-up, not this PR's fault: #15206 merged at a18c523 four minutes after this head and added two more Reasons β workflow-path (decision_glossary.go:174-176, aliases contributor-lane:workflow-path, adoption-stalled:contributor-lane:workflow-path, capability:workflows-permission) and adoption-executing (:177-178). Neither has a row, so the body's "the table matches the code again" is already stale on v5. Since this PR is one line from touching that table anyway, adding both rows here would save a third drift PR; otherwise it needs its own follow-up.
I have not approved or changed anything; the alias fix is the only thing I'd want before this lands.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦he glossary tables Review follow-up for #15259: the human-merge Reasons row now carries its glossary aliases (author-association, contributor-lane:author-association, ready-for-human-merge, untrusted-author) like every other aliased row, and the three Reasons #15206 added to decision_glossary.go β workflow-path (with its aliases), adoption-executing and adoption-undone β get rows so the table matches the code on v5. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Looks correct to me. Checked each new row against the source of truth at v5:
capability-gapβpkg/delegatedecision/decision_glossary.go:99(Rules table; Plain and Detail text match verbatim).adoption-executingβ:177,adoption-undone, and thehuman-mergerow (:191, with aliasesauthor-association,contributor-lane:author-association,ready-for-human-merge,untrusted-author) β Reasons table, alias sets match theAliasesslices.workflow-pathrow aliases (adoption-stalled:contributor-lane:workflow-path,capability:workflows-permission) also appear inpkg/dashboard/operator_actions.go, so the tokens the dashboard emits are the ones documented.
Rows keep the table's alphabetical order. After this lands, every hyphenated glossary slug in decision_glossary.go has a row in the doc (I diffed the two sets; the only apparent gap, ci-red, is already an alias on the checks-failing row at :1506).
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The Rules table in labels-and-control-signals.md drifted behind decision_glossary.go: the capability-gap (#15127) and human-merge (#15078) rules were defined in code but had no row in the docs table. This adds the missing rows using the glossary's own wording so the table matches the code again.
Closes #15250
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88