Skip to content

πŸ› Let hive decide on a ready-for-human-merge PR approves and lets the sweep merge it - #15211

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-15191
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-15191

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15191 (adopted after CI went red and the contributor was unavailable; original commits by @clubanderson preserved).

Fixes #15173

This branch is #15191's head ad572a19f116 as pushed by @clubanderson (fork hivecommons/hive), unchanged. Last lane reason on the original: supersession-decision-pending.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

… sweep merge it

A contributor PR at stage/090 with a good review, green CI and a
mergeable head sat behind "I can't merge this" when a person delegated
it. The hive now decides: approve (the Approve β€” let hive merge path β€”
APPROVE review, automerge label, head admitted as operator-approval:<login>)
so the merge sweep merges the PR under its own number after soak. Adoption
in supersede mode is the fallback only when the head cannot merge as it is
(review not good, CI red, conflicting, sign-off missing). The decision
carries the path in plain words for the ledger and the βœ“ hover.

Fixes #15173

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#15173
  • Closing PR: #15181

Closing this hive-authored PR as superseded by #15181: every issue it closes is already closed and that merged PR closed #15173. Head ad572a1 conflicts with v5, so there is nothing of its own left to rebase and measure. Reopen if that's wrong.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether this adoption #15211 or the original #15191 carries the ad572a19 head forward, since they are byte-identical and the hive's requires_human verdict on #15191 applies to this head unchanged.

Conclusion: this PR is byte-identical to #15191 β€” same head commit ad572a19f1163a8337d0b4f66a6f9373c7f2a9bf, not merely the same files β€” so there is nothing new to review here. One of the two should close; I have not closed anything.

  • hive/adopt-15191 head == #15191 head (ad572a19), per gh pr view on both. The PR body confirms it was copied "unchanged".
  • The hive already recorded requires_human on #15191 at exactly this SHA; whatever question that review raised is the question for this PR too. Re-reviewing an identical tree would only duplicate it.
  • Both are currently mergeable_state=dirty against v5, so neither lands without a rebase regardless of which survives.

Flagging for a maintainer: pick the one to keep (the original keeps review history; the adoption is the branch the fix agent is instructed to push to) and close the other.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let hive decide on a ready-for-human-merge PR should approve and let the sweep merge it, not answer "I can't merge this" or adopt

1 participant