Repository navigation
π Let hive decide on a ready-for-human-merge PR approves and lets the sweep merge it - #15211
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
β¦ sweep merge it A contributor PR at stage/090 with a good review, green CI and a mergeable head sat behind "I can't merge this" when a person delegated it. The hive now decides: approve (the Approve β let hive merge path β APPROVE review, automerge label, head admitted as operator-approval:<login>) so the merge sweep merges the PR under its own number after soak. Adoption in supersede mode is the fallback only when the head cannot merge as it is (review not good, CI red, conflicting, sign-off missing). The decision carries the path in plain words for the ledger and the β hover. Fixes #15173 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
Closing this hive-authored PR as superseded by #15181: every issue it closes is already closed and that merged PR closed #15173. Head ad572a1 conflicts with This comment is edited in place by the supersession sweep; it is not duplicated. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether this adoption #15211 or the original #15191 carries the ad572a19 head forward, since they are byte-identical and the hive's requires_human verdict on #15191 applies to this head unchanged.
Conclusion: this PR is byte-identical to #15191 β same head commit ad572a19f1163a8337d0b4f66a6f9373c7f2a9bf, not merely the same files β so there is nothing new to review here. One of the two should close; I have not closed anything.
hive/adopt-15191head ==#15191head (ad572a19), pergh pr viewon both. The PR body confirms it was copied "unchanged".- The hive already recorded
requires_humanon #15191 at exactly this SHA; whatever question that review raised is the question for this PR too. Re-reviewing an identical tree would only duplicate it. - Both are currently
mergeable_state=dirtyagainst v5, so neither lands without a rebase regardless of which survives.
Flagging for a maintainer: pick the one to keep (the original keeps review history; the adoption is the branch the fix agent is instructed to push to) and close the other.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Supersedes #15191 (adopted after CI went red and the contributor was unavailable; original commits by @clubanderson preserved).
Fixes #15173
This branch is #15191's head
ad572a19f116as pushed by @clubanderson (forkhivecommons/hive), unchanged. Last lane reason on the original:supersession-decision-pending.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.