Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-decided-state.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Activity Monitor: a row the operator sent to *Let hive decide* now follows one post-decision state machine instead of showing a green ✓, a *Hive is deciding…* spinner and the stale striped *Ready for human merge · untrusted author* pill at once. The ✓ is the decision badge (tooltip names who chose, what hive decided, when and what comes next — never a merge celebration); the pill and chevron move to where hive actually is (*Adopted · opening hive copy…* at the merge gate, *Fixing · hive is addressing @reviewer's review* at 070), progress text names the recorded decision (*Approving…* only for an approve); toasts lead with the outcome in one line. *Let hive decide* previews first (`POST …/decide-delegated/plan`, no side effects) with **Let hive do that** / **Approve & merge as-is** / **Cancel**, and the chosen button is recorded. Adoption pairs render explicitly (dimmed *Adopted → #N · superseded* original, *↳ adopted from #N* chip on the copy; a closed original is one dimmed cached-title line, never a blank numbered row). Any recorded decision lifts `needs-human` and the 045/085 stage labels in the same write and the projection never leaves a decided row in 085. All operator-facing strings use the chevron's stage vocabulary through one shared mapping (no raw `060 reviewed` / `stage/…`); 060 *reviewed* is drawn in the CI / Review column as *Review passed · CI in progress* (the lane's recorded reason) — the merge gate column starts at 080. "The author's hive" is now "the author's clanker" everywhere; no-effect popover times are local relative times and *Merge as maintainer* is the in-tracker action when available.
151 changes: 151 additions & 0 deletions dashboard/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -29079,6 +29079,157 @@
}
}
},
"/api/repos/{owner}/{repo}/items/{number}/decide-delegated/plan": {
"post": {
"tags": [
"Status"
],
"summary": "Preview what *Let hive decide* would do on one parked item (dry run, no side effects)",
"description": "Backs the activity monitor's *Let hive decide* confirm popover. Runs the same owner-delegate policy as decide-delegated but writes nothing — no comment, no labels, no ledger entry, no job — and answers the decision the hive WOULD record in plain words (\"Hive would: re-author #15029 as a hive PR with the same commits and merge it; #15029 will be closed as superseded. Why: author @Karibhou is untrusted and their clanker is offline.\"), its consequences and the operator's alternatives (Approve & merge as-is when the requester may merge). The SPA shows Let hive do that / Approve & merge as-is / Cancel and only then posts decide-delegated with `chosen` naming the button. Same authorisation and feature gate as decide-delegated.",
"parameters": [
{
"name": "owner",
"in": "path",
"required": true,
"schema": {
"type": "string"
}
},
{
"name": "repo",
"in": "path",
"required": true,
"schema": {
"type": "string"
}
},
{
"name": "number",
"in": "path",
"required": true,
"schema": {
"type": "integer"
}
}
],
"requestBody": {
"required": false,
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"type": {
"type": "string",
"enum": [
"issue",
"pr"
],
"description": "What the number names; defaults to issue"
},
"reason": {
"type": "string",
"description": "The row's park reason code (why the hive stopped), read by the policy"
},
"caption": {
"type": "string",
"description": "The row's lit-chevron caption"
},
"sentinel_reason": {
"type": "string",
"description": "The sentinel finding summary when the PR is flagged"
}
}
}
}
}
},
"responses": {
"200": {
"description": "The plan",
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"repo": {
"type": "string"
},
"number": {
"type": "integer"
},
"type": {
"type": "string",
"enum": [
"issue",
"pr"
]
},
"would": {
"type": "string",
"description": "The verdict the hive would record (adopt-supersede, approve, direction, recommend-only, …)"
},
"rule": {
"type": "string",
"description": "The policy rule behind it"
},
"acting": {
"type": "string",
"description": "The pill / progress vocabulary for the verdict while it runs"
},
"summary": {
"type": "string",
"description": "One line: what hive would do"
},
"why": {
"type": "string",
"description": "The plain reason"
},
"consequences": {
"type": "array",
"items": {
"type": "string"
}
},
"alternatives": {
"type": "array",
"description": "The other buttons, in the needs-human popover's option shape",
"items": {
"type": "object"
}
},
"writes": {
"type": "boolean",
"description": "Always false: the plan has no side effects"
},
"prior": {
"type": "string",
"format": "date-time",
"description": "Set when the hive already recorded this decision"
},
"notes": {
"type": "array",
"items": {
"type": "string"
}
}
}
}
}
}
},
"400": {
"description": "Bad owner/repo/number or body"
},
"401": {
"description": "No signed-in GitHub user"
},
"403": {
"description": "Not permitted, or decisions.delegate disabled for the repository"
}
}
}
},
"/api/repos/{owner}/{repo}/items/{number}/accept-triage": {
"post": {
"tags": [
Expand Down
Loading
Loading