Skip to content

🐛 fix(selfreport): classify pacing deadline-miss refusals as benign - #15171

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15106
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15106

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #15109

#15142 classified the pacer's request-shed refusal, but the pacer has a second refusal (github pacing: slot would miss request deadline, pkg/github/slowstart.go) that the truncated #15109 diagnostic (...: github paci) is consistent with. Add it to the rate-limit substrings so the advisory path-existence WARN is no longer reported.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against the tree at 4d8cc08; this looks correct to me.

  • The new substring in src/pkg/fleetreport/fleetreport.go:808 matches the actual error text emitted at src/pkg/github/slowstart.go:221 ("github pacing: slot would miss request deadline: %w"), and IsGitHubRateLimited (fleetreport.go:815-823) lowercases and does a substring match, so the wrapped Get "…": github pacing: … form the test adds will classify.
  • Scope matches the body: the sibling request shed refusal was covered by #15142 and this adds the only other pacer refusal.

Three-line change, fragment present, no concerns.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit a2c2694 into v5 Oct 29, 2026
79 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15106 branch October 29, 2026 00:05
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#151714d8cc08` sha256:66e7a288cafbea8744b5da025fc76b21e9fbe98fc25790563737d42bd2ad85b1 — download from the dashboard or `hivectl review evidence #15171`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: advisory: path existence check failed

0 participants