Repository navigation
🐛 fix(selfreport): classify pacing deadline-miss refusals as benign - #15171
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read against the tree at 4d8cc08; this looks correct to me.
- The new substring in
src/pkg/fleetreport/fleetreport.go:808matches the actual error text emitted atsrc/pkg/github/slowstart.go:221("github pacing: slot would miss request deadline: %w"), andIsGitHubRateLimited(fleetreport.go:815-823) lowercases and does a substring match, so the wrappedGet "…": github pacing: …form the test adds will classify. - Scope matches the body: the sibling
request shedrefusal was covered by #15142 and this adds the only other pacer refusal.
Three-line change, fragment present, no concerns.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #15109
#15142 classified the pacer's request-shed refusal, but the pacer has a second refusal (
github pacing: slot would miss request deadline, pkg/github/slowstart.go) that the truncated #15109 diagnostic (...: github paci) is consistent with. Add it to the rate-limit substrings so the advisory path-existence WARN is no longer reported.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88