Repository navigation
π fix: record pending operator action before starting delegated job - #15069
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 095-pre-merge-soak β 060-reviewed: required-check-pending:Sign-off survives the squash |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@thatguywob the hive has adopted this PR ( |
Defer asynchronous delegated work until the response wrapper has recorded its pending ledger row, preventing fast jobs from settling before the row exists. Hive-Run: hivecommons#15064 Hive-Plan: pending-ledger-start-order Hive-Spec: hivecommons#15064#record-before-settle Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
705a634 to
2e1c8a8
Compare
|
hive/awaiting-ci: rebased onto v5 (resolved the appended-test conflict in api_repo_item_decide_delegated_test.go, kept both sides; original author and sign-off preserved). CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, head |
Fast delegated jobs can finish before the response wrapper records their pending operator-action row, leaving the activity monitor badge pending forever. Defer async startup until the wrapper finishes recording the response so settlement always has a row to update.
Adds coverage for immediate applied, no-op, and failed settlements, plus async fan-out when every nested PR already has a running job. Includes a changelog fragment.
Validation:
gofmt -lis clean for all changed Go files. Tests were not run locally per AGENTS.md; CI owns test execution.Fixes #15064
β hive: backend=codex
π Hive Agent:
contributor| SHA:705a6342d