Skip to content

✨ feat(review): run combined review heads as one kick per head - #15068

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-15058
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-15058

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Under review.combined_perspectives: true the planner dropped review_heads, so getting several independent models meant split perspectives and heads × perspectives record-only kicks per PR head (10 for 2 heads × 5 perspectives) plus the decision. Each kick re-read the same diff, so latency and model spend scaled with the perspective count, not with the number of independent opinions.

With combined perspectives each head now gets one record-only kick carrying every perspective it still owes (combined prompt body, one JSON verdict array via --record-verdict): 2 head kicks plus the decision instead of 11. Pending entries stay per (perspective, head), so settling, expiry, head_max_retries, re-asking only missing perspectives, and the decision step are unchanged. Split heads behave exactly as before.

Config: heads are now expected by the aggregate in both modes. A combined-mode reviewer set that mixes lanes with and without review_heads loaded fine before this change, so it still loads; the hive logs a review heads config warning at boot (config.ReviewHeadsWarnings) that the plain lanes receive no combined perspectives while the heads cover them. Split-mode validation, which rejects that mix, is unchanged. No new config gate.

Tests: one kick per head carrying all missing perspectives with per-pair pending; a 3-of-5 verdict array settles those pairs and the next plan re-asks only the other 2; the decision fires only once every head settled every perspective, with the same prompt as split heads; the combined mixed set loads and warns, while split still rejects it.

Closes #15058

Under review.combined_perspectives the planner dropped review_heads, so a
hive that wanted several independent models had to run split perspectives
and pay heads x perspectives record-only kicks per PR head (10 with two
heads and five perspectives) plus the decision kick. Every one re-read the
same diff, and review latency and spend scaled with the perspective count
instead of the number of independent opinions.

With combined perspectives each head now gets one record-only kick carrying
every perspective it still owes, using the combined prompt body, and
records a JSON array of per-perspective verdicts. Pending entries stay one
per (perspective, head), so settling, expiry, head_max_retries, re-asking
only the missing perspectives and the decision step are unchanged. Heads
are expected by the aggregate in both modes, and the mixed-reviewer-set
check now applies in both modes since head dispatch leaves nothing for a
plain lane either way.

Closes #15058

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: gregoryhunt <31053269+gregoryhunt@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15049 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/cmd/hive/main.go
#14921 ✨ feature: inline the linked Linear issue into review kicks same files src/cmd/hive/main.go
src/pkg/review/prompts.go
#14524 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/cmd/hive/main.go

…mbined heads

A reviewer set mixing lanes with and without review_heads loaded fine under
combined_perspectives before heads were dispatched there, so rejecting it at
load would break existing configs. Keep it loadable and log a boot warning
that the plain lanes receive no combined perspectives while the heads cover
them. Split-perspective validation is unchanged.

Refs #15058

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 9be2fee41

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit cac064e into v5 Oct 28, 2026
78 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15058 branch October 28, 2026 19:35
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#150683f9f5cd` sha256:99c987348e5f6ed26ca7b472370475200452fa0c0e1747a3ccd069e29db92ecc — download from the dashboard or `hivectl review evidence #15068`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
clubanderson added a commit that referenced this pull request Oct 29, 2026
…PR (#15480)

A PR row whose linked issue is already closed drew a bare `closed` chip
when the hive's merged ledger did not know the closer (a PR the owner
merged by hand; a merge lost across a roll), which read as the issue
having been closed before its fix merged — hive's #15422 under follow-up
#15425 and #15058 under #15431. The issues were in fact closed by GitHub
the second #15426 / #15068 merged.

The soft-link enrichment now asks GitHub which MERGED pull request closed
the issue (closedByPullRequestsReferences; an open PR with Fixes #N is
listed there too and is never named) and carries state_reason and
closed_by on the link, so the chip reads `closed by #N`. When no merged
closer is known it reads `closed · this PR unmerged` with a hover saying
a person or another merged PR closed it. Docs state the rule: the hive
closes an issue only after its PR has merged.

Fixes #15479

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson pushed a commit that referenced this pull request Oct 29, 2026
…ve (#15539)

* ✨ review: fan a combined head kick out to one sub-agent per perspective

A combined review head (#15068) judges every perspective in one record-only
kick, but nothing told it how to spend that kick, so a head walked the
perspectives one after another and its kick took the sum of all of them.

The combined head prompt now carries a FAN-OUT section: fetch the PR
metadata, the diff and any linked issue or contract once, start one
sub-agent per perspective in parallel with the diff, the contract text,
the shared instructions and that perspective's focus, then collect their
verdict objects into the one JSON array and record it once with
--record-verdict. Sub-agents post nothing, never call hive-review and do
not refetch the PR. Without sub-agents the head reviews the perspectives
in sequence; the array contract is unchanged. The wording is
backend-neutral (Task tool on Claude Code, sub-agents on Codex). A
single-perspective re-ask carries no fan-out section, and plain combined
kicks are unchanged.

Refs #15058

Signed-off-by: Gregory Hunt <greg@on-board.ai>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* 🐛 review: pin combined-head fan-out sub-agents to the head's model

The fan-out told a head to start one sub-agent per perspective without
naming a model, while the head's independent-review section pins a single
sub-agent to the head model. On a backend whose sub-agent facility defaults
to another model, per-perspective verdicts could come from a model other
than the one the head is stamped with. Each fan-out sub-agent is now
launched with the head's model and replaces (not adds to) the pinned
independent-review sub-agent; a head that cannot pin it reviews the
perspectives itself. Docs and test updated.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Gregory Hunt <greg@on-board.ai>

---------

Signed-off-by: Gregory Hunt <greg@on-board.ai>
Co-authored-by: Gregory Hunt <greg@on-board.ai>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review: support review_heads with combined_perspectives (one kick per head, not heads x perspectives)

0 participants